Commit Graph

3502 Commits

Author SHA1 Message Date
Marek Marczykowski-Górecki
84528b30c1
qvm-remove: don't fail on removing template which was never started
When a template never was started, it isn't defined in libvirt, so
attempt to undefine it will fail.

Fixes QubesOS/qubes-issues#2290
2016-09-09 12:47:11 +02:00
Marek Marczykowski-Górecki
7ae55d46b2
Merge remote-tracking branch 'qubesos/pr/50'
Edit in merge commit: remove trailing whitespaces.
2016-09-01 05:16:55 +02:00
HW42
32b4f9d4a4
qubes-hcl-report: add check for HAP/SLAT
bassed on
https://wiki.xenproject.org/wiki/Xen_Common_Problems#How_can_I_check_if_my_CPU_supports_HAP_.28Hardware_Assisted_Paging.29_.3F
2016-09-01 03:45:31 +02:00
Marek Marczykowski-Górecki
0e24d803f5
version 3.2.9 2016-08-31 13:08:59 +02:00
Nicklaus McClendon
b6416dcc4b
Updated manpages to match current tool options 2016-08-19 01:51:41 -05:00
Rusty Bird
3606fe64a4
qubesutils.py: pass readonly mode to libvirt
Fixes QubesOS/qubes-issues#2255
2016-08-18 12:54:26 +00:00
Marek Marczykowski-Górecki
4c1c57bcb7
qvm-backup-restore: add missing backslash
Reported by Ivan <ivan@c3i.bg>
2016-08-17 13:48:12 +02:00
Marek Marczykowski-Górecki
10c44e8722
version 3.2.8 2016-08-07 16:11:49 +02:00
Marek Marczykowski-Górecki
2908992741
prepare-volatile-img.sh: create volatile.img group accessible
Otherwise qvm-create-default-dvm may fail to include it in
saved-cows.tar, which will lead to DispVM being not really disposable.

Fixes QubesOS/qubes-issues#2200
2016-08-07 16:07:30 +02:00
Marek Marczykowski-Górecki
d0ddb3d17c
dispvm: error out on saved-cows.tar creation error
If it fails - for example because of too restrictive volatile.img
permissions, subsequent DispVM will not be really disposable.
The original permissions issue should be fixed by previous commit, this
one makes sure that such errors will not be ignored.

Fixes QubesOS/qubes-issues#2200
2016-08-07 00:41:59 +02:00
HW42
09b49feea6
prepare-volatile-img.sh: don't run as root
This is no longer necessary since volatile.img is formated inside the
VM. This also fixes DispVM creation if the user sets a restrictive umask
for root. Maybe related to #2200.
2016-08-07 00:41:59 +02:00
Marek Marczykowski-Górecki
0968c25486
tests: when creating AppVM based on whonix-ws, connect it to tor
Use sys-whonix if exists. This makes network-related tests more
realistic.
2016-08-07 00:41:59 +02:00
Marek Marczykowski-Górecki
5c9157be05
tests: fix newline input in DispVM editor tests
Just '\n' isn't enough for xdotool to enter newline.
2016-08-07 00:41:59 +02:00
Marek Marczykowski-Górecki
72d60788e4
tests: fix Debian repository format
Use SHA256 instead of SHA1 - apt-get in Debian 9 rejects SHA1.
Fix date format (according to apt-get in Debian 9).
2016-08-07 00:41:58 +02:00
Marek Marczykowski-Górecki
07ac6c9ba1
tests: fix handling LibreOffice in DispVM tests
It's first window is a splash screen.
2016-08-07 00:41:58 +02:00
Marek Marczykowski-Górecki
dca30e815b
tests: enable 'use-default-netvm' while restoring old backup
Firewall VM was named 'firewallvm' at that time.
2016-08-07 00:41:58 +02:00
Marek Marczykowski-Górecki
fd1b68166c
tests: add test for GUI memory issues
QubesOS/qubes-issues#1028
2016-08-07 00:41:58 +02:00
Marek Marczykowski-Górecki
fd5b357232
tests: split vm_qrexec_gui 2016-08-07 00:41:57 +02:00
Marek Marczykowski-Górecki
86a14b53fb
qvm-run: color untrusted stderr even when stdout is redirected
When stdout is redirected to some file or command two things will
happen:
 - qvm-run will not automatically color the output as stdout is not a
 TTY
 - even when coloring is forced, it will not work, as the control
 sequence (on stdout) will be redirected anyway

Fix this by handling stdout and stderr independently and output color
switching sequence to each of them.

Fixes QubesOS/qubes-issues#2190
2016-07-29 13:07:37 +02:00
Marek Marczykowski-Górecki
6a516caee2
tests: misc minor fixes 2016-07-29 13:07:37 +02:00
Marek Marczykowski-Górecki
0ee64c74f9
tests: cleanup after backup compatibility tests
Backup compat tests use 'test-' prefix (as it was initially for all the
tests. Since changing this right not may break those backups in
non-trivial way, simply add cleanup for 'test-*' VMs.
2016-07-29 13:07:36 +02:00
Marek Marczykowski-Górecki
9f7668af77
tests: allow LibreOffice as txt file editor 2016-07-19 02:07:14 +02:00
Marek Marczykowski-Górecki
9d1b7504da
qvm-sync-clock: allow colon in timezone spec
`date` in debian 9 puts colon there. Since the timezone is not used here
in any way (it operates on UTC time anyway), simply allow this format
too.
2016-07-19 00:46:48 +02:00
Marek Marczykowski-Górecki
f0489a3d5c
version 3.2.7 2016-07-18 15:24:25 +02:00
Marek Marczykowski-Górecki
c028df3e1e
QubesWatch: fix handling just removed domains
Really do not throw exception in such a case.
Reported by HW42.
2016-07-18 15:07:02 +02:00
HW42
b467dd6218
QubesWatch: do not create multiple dom0 QubesDB connections
When calling _register_watches() multiple times for dom0 (by passing
None or since 7e9c816b by passing the corresponding libvirt domain) the
check was missing if there is already a QubesDB in _qdb. Therefore a new
QubesDB was created and the old one is destroyed by the GC. As a
consequence the watch_fd is closed but the libvirt event handle for this
fd is still registered. So when libvirt calls poll() it returns
immediately POLLNVAL with the closed fd. This is not caught in libvirt
and the callback is called as if an event happened. _qdb_handler() now
calls read_watch() on the new fd for dom0 and thereby hangs the thread.
This leads (at leads) to qubes-manager to miss VM status updates and
block device events.

Fixes QubesOS/qubes-issues#2178
2016-07-18 15:03:14 +02:00
Marek Marczykowski-Górecki
9751981f69
version 3.2.6 2016-07-17 05:17:57 +02:00
Marek Marczykowski-Górecki
1a1ec88d29
tests: save qubes.xml befor launching qvm-block tests 2016-07-17 05:16:31 +02:00
Marek Marczykowski-Górecki
b5bee9470a
Merge remote-tracking branch 'qubesos/pr/44'
* qubesos/pr/44:
  Correct note regarding dom0 home-pre-restore directory
2016-07-17 03:56:39 +02:00
Marek Marczykowski-Górecki
6068c7bc50
core: fix handling uses_default_netvm property
- for netvm it doesn't make sense, but instead of removing it (which
        surely will break some code), make it always False
- when settings VM connections, uses_default_netvm is already loaded
- handle it properly during backup restore (really use default netvm,
        istead of assuming it's the same as during backup)
2016-07-17 03:56:11 +02:00
Marek Marczykowski-Górecki
6ccae83956
tests/backup: verify restored VM properties
QubesOS/qubes-issues#2106
2016-07-17 03:56:10 +02:00
Marek Marczykowski-Górecki
8222324146
backup: restore 'services' property
Fixes QubesOS/qubes-issues#2106
2016-07-17 03:56:10 +02:00
Marek Marczykowski-Górecki
c5d03cc32e
backup: ask user to update templates after restoring backup
To install all the fixes and to update applications + icons.

Fixes QubesOS/qubes-issues#2150
2016-07-17 03:56:10 +02:00
Andrew David Wong
3427621f43
Correct note regarding dom0 home-pre-restore directory 2016-07-16 18:26:15 -07:00
Marek Marczykowski-Górecki
521e96f2c3
Revert "core: detach PCI devices before shutting down VM"
Many drivers, including iwlwifi doesn't handle this well, resulting in
oopses etc. Also we're disabling PCI hotplug, which may be result in
more troubles here.
This reverts commit 2658c9a6e6.

QubesOS/qubes-issues#1673
2016-07-16 21:10:29 +02:00
Marek Marczykowski-Górecki
b3fb8ab59b
Merge remote-tracking branch 'qubesos/pr/44'
* qubesos/pr/44:
  Revise help and stderr messages
  Revise help and stderr messages
2016-07-16 18:10:17 +02:00
Andrew David Wong
1cb0f384fd
Revise help and stderr messages 2016-07-15 16:29:01 -07:00
Andrew David Wong
1d625b3570
Revise help and stderr messages 2016-07-15 16:20:11 -07:00
Marek Marczykowski-Górecki
f15ddf7801
backup: fix restoring on system without default netvm
Fixes QubesOS/qubes-issues#2168
2016-07-14 02:06:08 +02:00
Marek Marczykowski-Górecki
4072914b40
version 3.2.5 2016-07-12 06:28:36 +02:00
Marek Marczykowski-Górecki
bed5f5d88c
tests: regression test for #1990
QubesOS/qubes-issues#1990
2016-07-12 06:28:01 +02:00
Marek Marczykowski-Górecki
69e792d82c
usb_attach: improve error reporting
- specifically report when qubes-usb-proxy package is not installed
- include sanitized stderr output in error message
2016-07-12 06:27:53 +02:00
Marek Marczykowski-Górecki
da74d75e6b
core: collect stderr too when vm.run_service is called with passio_popen
Give access to all file descriptors when requested.
2016-07-12 06:24:07 +02:00
Marek Marczykowski-Górecki
7e9c816b7b
qubeswatch: use always "dom0" name for dom0
Libvirt reports dom0 as "Domain-0". Which is incompatible with how Qubes
and libxl toolstack names it ("dom0"). So handle this as a special case.
Otherwise reconnection retries leaks event object every iteration.

Fixes QubesOS/qubes-issues#860
Thanks @alex-mazzariol for help with debugging!
2016-07-01 19:16:07 +02:00
Marek Marczykowski-Górecki
78437f7012
qvm-ls: remove unused code 2016-07-01 03:08:42 +02:00
Marek Marczykowski-Górecki
8c7f072461
core: fix handling vm.start_time for just shutdown VM
That xenstore entry may be already removed even when libvirt still
reports the VM as running.

Fix QubesOS/qubes-issues#2127
2016-07-01 00:47:32 +02:00
Marek Marczykowski-Górecki
03210f6cfe
Merge remote-tracking branch 'qubesos/pr/34'
* qubesos/pr/34:
  qfile-daemon-dvm: Implement LAUNCH and FINISH actions
  qfile-daemon-dvm: Call static method by class name
  qfile-daemon-dvm: Move dispVM killing into cleanup function
2016-06-30 01:43:57 +02:00
Marek Marczykowski-Górecki
13a463b565
Merge remote-tracking branch 'qubesos/pr/33'
* qubesos/pr/33:
  And some more quoting to satisfy #1672
  Quoting all `cat`s as proposed in #1672
  Modifying support cpio as proposed in #1672
  Quoting the destination as proposed in #1672
2016-06-30 01:43:52 +02:00
HW42
f6bc97d65b
save pci_e820_host property 2016-06-29 23:51:51 +02:00
Marek Marczykowski-Górecki
ae2194da3b
tests: one more place to add xdotool --sync 2016-06-29 23:50:52 +02:00