Commit Graph

129 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
0bb92311ba
Fixed bug with hiding last visible column
Removed old buggy code, replaced it with disabling hiding the 'name'
column (because manager is useless without VM name).
2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
ddb70fe8ea
Added additional check for cloning a VM
An attempt to clone a VM to a name that is already in use will
fail more gracefully and with an explicit warning message.
2019-05-03 14:41:01 +02:00
Marek Marczykowski-Górecki
6585ab4f29
Merge remote-tracking branch 'origin/pr/166'
* origin/pr/166:
  Refactored QThread classes for more clarity and less code duplication
  Fixed inconsisted icon in Qube Manager messages
2019-04-05 00:53:32 +02:00
Marta Marczykowska-Górecka
6e10daa309
Refactored QThread classes for more clarity and less code duplication 2019-04-04 22:58:10 +02:00
Marek Marczykowski-Górecki
f4d0417e1a
Merge remote-tracking branch 'origin/pr/170'
* origin/pr/170:
  Fix error on reverting Qube Manager to an older version
2019-04-04 01:28:35 +02:00
Marek Marczykowski-Górecki
278a72d461
Merge remote-tracking branch 'origin/pr/167'
* origin/pr/167:
  More documentation and added another column for default_dispvm to Qube Manager
  Added DVM Template column to Qube Manager
  Rewritten Qube Manager widgets
2019-04-04 01:26:03 +02:00
Marta Marczykowska-Górecka
d2ad60edd2
Fix error on reverting Qube Manager to an older version
In rare case (when the Qube Manager was reverted to an older version
that does not have a column on which it was last sorted) downgrading
Qube Manager could result in a crash on start.
2019-04-03 20:49:33 +02:00
Marta Marczykowska-Górecka
c2e7010b25
More documentation and added another column for default_dispvm to Qube Manager
Including also a minor visual fix - the headers in Qube Manager
will now be multi-line when it looks needed.

fixes QubesOS/qubes-issues#4912
2019-04-03 19:21:25 +02:00
Marek Marczykowski-Górecki
1d65d692ad
Merge remote-tracking branch 'origin/pr/154'
* origin/pr/154:
  Fix too long lines
  Moved busy_cursor() inside save_changes()
  Removed unneded calls to Override/Restore cursor
  Removed duplicated call to save_changes()
  Removed unneeded Cursor override/restore
  Added busy_cursor()
  Added BusyCursor for notify manager is working
  Revert "Added progress bar to __save_changes__"
  Revert "Increase progress wait time to 2s"
  Increase progress wait time to 2s
  Added progress bar to __save_changes__
  Remove unneeded slot connections and reject overwrite
2019-04-03 16:19:10 +02:00
donoban
b7228e8419
Fix too long lines 2019-04-01 11:48:11 +02:00
donoban
8e383e3022
Added busy_cursor()
fix https://github.com/QubesOS/qubes-issues/issues/4744
2019-03-31 19:56:01 +02:00
Marta Marczykowska-Górecka
cf1dd0d355
Added DVM Template column to Qube Manager
It is labelled "Template for DispVMs" and behaves like every
other column.

fixes QubesOS/qubes-issues#4912
2019-03-29 19:04:45 +01:00
Marta Marczykowska-Górecka
2ce6e8b1cc
Rewritten Qube Manager widgets
Less duplicate code and more extendability - now most
widgets are based on a single class.
2019-03-29 18:33:51 +01:00
Marta Marczykowska-Górecka
fe810c5ad0
Fixed inconsisted icon in Qube Manager messages
Now success will not be accompanied by a 'warning'
icon.

fixes QubesOS/qubes-issues#4922
2019-03-29 17:01:15 +01:00
AJ Jordan
868632555b
Set the window title when cloning a qube 2019-03-27 21:37:27 -04:00
Marek Marczykowski-Górecki
9b8f5a460e
Apply DSA-4371 fix before launching updates
Script by @HW42 slightly modified.

QubesOS/qubes-issues#4752
2019-01-23 06:16:16 +01:00
Marta Marczykowska-Górecka
3cf9ff3ee2
Qube Manager conservative updating
Only update the widget changed, if possible; look at the event
that caused the update and update whatever was actually changed not
the whole VM row.
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
a9c8d524c7
Added label update to Qube Manager
Manager will now properly display label changes.

fixes QubesOS/qubes-issues#3675
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
13c4c748f1
Added links to template manager to qube manager
Added a shortcut to template manager to qube manager main window and some minor pylint fixes.
2018-12-03 18:25:49 +01:00
Marek Marczykowski-Górecki
334fefe559
Merge remote-tracking branch 'origin/pr/132'
* origin/pr/132: (48 commits)
  Fixed unreachable code thanks to travis
  Clear searchbox pressing esc without need of selecting it
  Fix errors when some domain fails to start
  wait thread to finish when aborting
  Don't terminate backup thread when aborting
  Fix iterating and removing over list
  Use 'qube' instead 'Qube'
  Qube -> qube
  Catch possible KeyError when starting dispVM
  Fix authorship and python version
  Create backup_window on the stack
  Removed sigchld_handler old code
  Fix pylint
  Do not terminate the thread
  Fix error/success message on dialog
  Fix opening settings/boot dialog after VM creation
  Add pylint disable too-few-methods
  Fix travis errors
  Removed unused import
  Workaround for backup dialog modeless behaviour
  ...
2018-11-28 01:13:48 +01:00
donoban
b2bdae2c2d
Clear searchbox pressing esc without need of selecting it 2018-11-25 19:28:07 +01:00
donoban
4deaedd1e0
Fix errors when some domain fails to start 2018-11-25 19:15:56 +01:00
donoban
22a9823871
Fix iterating and removing over list
Return after removing and raise exception if removable item not found
2018-11-25 18:37:34 +01:00
donoban
0ce73df57d
Use 'qube' instead 'Qube' 2018-11-25 18:16:40 +01:00
donoban
a39f3a64d0
Create backup_window on the stack
Otherwise it can casue an error:
RuntimeError: wrapped C/C++ object of type QProgressBar has been deleted
at line 1277
of file /usr/lib/python3.5/site-packages/qubesmanager/qube_manager.py.

I don't know how to avoid it.
2018-11-18 20:14:57 +01:00
Marta Marczykowska-Górecka
8098466a07
Fix error in qube manager
In some cases (when a VM quickly appears and disappears)
the events were handled in a wrong order.

fixes QubesOS/qubes-issues#4414
2018-10-29 23:00:59 +01:00
donoban
fd1e5d740a
Fix travis errors 2018-10-24 10:58:36 +02:00
donoban
971ec085ee
Workaround for backup dialog modeless behaviour
Since now it's modeless, user could have already it opened
but we have to destroy it and recreate when closed for vm list
being refreshed (at least for now)
2018-10-24 10:05:43 +02:00
donoban
23e9ae8d33
Remove loop since we have vm name 2018-10-24 00:03:17 +02:00
donoban
e124d83edc
Removed processEvents() calls 2018-10-23 00:07:55 +02:00
donoban
0e951dc156
Deleted unused method show_error()
clear_threads() handles messages now
2018-10-22 20:03:20 +02:00
donoban
edb13aec17
Thread.error renamed to Thread.msg
Since it could be used for both error or sucess
messages, I think msg is a better name
2018-10-22 20:00:37 +02:00
donoban
60af90ec5f
Adding # pylint: disable=too-few-public-methods 2018-10-22 10:14:26 +02:00
donoban
f93908f5b7
Fix travis build2 2018-10-20 23:23:06 +02:00
donoban
831769d2dd
Fix travis build 2018-10-20 23:01:35 +02:00
donoban
38051ad243
Fixes in ProgressDialogs and settings window close 2018-10-20 22:09:39 +02:00
donoban
2347f75633
Clear SearchBox with ESC key 2018-10-20 21:54:25 +02:00
donoban
11cc8b7a67
Remove debug print 2018-10-20 19:20:39 +02:00
donoban
29ca4eb3a8
Migration from python threads and to QThread obj
Simple design and better performance, just start() thread and finished
call back will show any error or msg, stop progress dialog and do cleanup.

Full remove of QT process_events() calls.
2018-10-20 18:34:15 +02:00
donoban
35cdf5e1e5
Modeless backup window
Let the main window work while doing backups
2018-10-20 16:50:45 +02:00
donoban
759dc5412c
Pylint ident warnings 2018-10-20 16:49:50 +02:00
donoban
76b6de9d00
removed subprocess.check_call()
This way modal works better (in KDE the main window goes gray).
2018-10-20 16:43:15 +02:00
donoban
612cfc15d6
Loading Qube Manager progress using setValue()
This is the recommended QT way for updating the progress bar.

setMininumDuration() sets the time when the progress dialog will appear,
if it finishes before it won't be shown. Qt default is 4 seconds, maybe
pretty high for this case.
2018-10-20 16:33:25 +02:00
donoban
228aaed2f4
Removed progress.setWindowFlags() call
I am not sure what this wants, but it seems that doesn't affect
xfce but on kde does the progress bar appear randomly in the screen

without it on both cases it appears at center of screen
2018-10-20 16:28:19 +02:00
Marta Marczykowska-Górecka
77cf9bf1d2
Fixed error in qube manager of change of global settings
Changing global properties fired an event that crashed qube
manager.

fixes QubesOS/qubes-issues#4385
2018-10-19 20:06:30 +02:00
donoban
b45f318a3a
Just moved method to better place 2018-10-18 14:13:06 +02:00
donoban
afcdba3029
Replaced python threading with QThreads 2018-10-18 14:11:25 +02:00
Marta Marczykowska-Górecka
f618716548
Fix error on refresh when a VM has vanished
Fixes error that can occur when VM-removed and VM-changed
events fire too closely together.

fixes QubesOS/qubes-issues#4317
2018-09-21 12:46:49 +02:00
Marta Marczykowska-Górecka
cbf2e2154d
Fixed a small bug with Qube Manager status refresh
On change of template Vm status, qube Manager errored
out. It no logner does that.
2018-09-14 18:01:20 +02:00
Marek Marczykowski-Górecki
8d99fdd11b
Remove all dbus references
Including package dependencies
2018-09-12 16:32:37 +02:00