Commit Graph

1582 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
fb0049f055
Fixed tab order in VM Settings
After some of recent fixes, tab order was no longer logical.

fixes QubesOS/qubes-issues#5356
2019-09-28 23:25:35 +02:00
Marta Marczykowska-Górecka
442066d96c
Fixed change in QFileDialog behavior in PyQt5
Return type of QFileDialog changed between PyQt4 and PyQt5.

fixes QubesOS/qubes-issues#5353
2019-09-28 22:06:29 +02:00
Saswat Padhi
4ee3c556c4
Show the previous VM name while renaming
Currently while renaming VMs, the default text is empty "". This change modifies this default text to the original name of the VM.
2019-09-26 18:29:31 -07:00
Marta Marczykowska-Górecka
5d88e5f851
Pylint fixes
Several minor fixes for updated pylint checker.
2019-09-26 22:44:05 +02:00
Marta Marczykowska-Górecka
32078242c9
Code deduplication and cleanup
Moved loop handling, exception handling and program
running methods of the gui tools to the utils file.

fixes QubesOS/qubes-issues#5342
2019-09-26 22:31:39 +02:00
Marta Marczykowska-Górecka
8a3653723d
Removed unused line in GUI Backup
File selection dialog in GUI backup was using an obsolete
(and possibly never working as intented) setReadOnly method.
Removed it, because it neither works nor is needed.

fixes QubesOS/qubes-issues#5348
2019-09-26 21:37:32 +02:00
Marek Marczykowski-Górecki
b51cd03481
version 4.1.0 2019-09-23 04:25:39 +02:00
Marek Marczykowski-Górecki
bdf0951c52
Merge remote-tracking branch 'origin/pr/198'
* origin/pr/198:
  Fixed new firewall rule window
2019-09-23 03:48:09 +02:00
Marek Marczykowski-Górecki
0dc73fd618
Merge remote-tracking branch 'origin/pr/196'
* origin/pr/196:
  Added an Advanced tab to Create New Qube dialog
2019-09-23 03:48:07 +02:00
Marta Marczykowska-Górecka
d85940c5a5
Added an Advanced tab to Create New Qube dialog
Tab contains a warning, provides_network checkbox,
install_system_after_creation checkbox, storage pool settings
and initial RAM.

references QubesOS/qubes-issues#5127
fixes QubeSOS/qubes-issues#5198
2019-09-20 17:59:23 +02:00
Marta Marczykowska-Górecka
2e152b8dfb
Fixed new firewall rule window
Now, an error will not close the window, enabling
the user to correct any mistakes.

fixes QubesOS/qubes-issues#bugfix5234
2019-09-20 17:50:31 +02:00
Marek Marczykowski-Górecki
b0d5263d5e
Merge remote-tracking branch 'origin/pr/199'
* origin/pr/199:
  Improved display of default disposable VM in Qube Manager
  Qube Manager now reacts to changing some global properties
2019-09-20 02:10:15 +02:00
Marta Marczykowska-Górecka
2d644c371f
Improved display of default disposable VM in Qube Manager
Now 'default' value will be correctly shown as default (vm name).
2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
9aeacce9c5
Qube Manager now reacts to changing some global properties
Properties checked are: default_netvm and default_dispvm. Qube Manager
will now properly update displayed values.

fixes QubesOS/qubes-issues#5328
2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
df9576a0f1
Fixed UI error
Qube Manager columns did not resize correctly in Qt5.

fixes QubesOS/qubes-issues#5278
2019-09-06 16:31:27 +02:00
Marek Marczykowski-Górecki
1ced452976
Merge remote-tracking branch 'origin/pr/177'
* origin/pr/177:
  Added menu position with Qubes Tools to XFCE Menu
2019-08-28 16:50:59 +02:00
Marek Marczykowski-Górecki
c32d63df58
Merge remote-tracking branch 'origin/pr/181'
* origin/pr/181:
  Add tooltip to application list in VM settings
2019-08-28 16:50:23 +02:00
Marek Marczykowski-Górecki
1edf363efe
Merge remote-tracking branch 'origin/pr/172'
* origin/pr/172:
  Say which repository caused the error in warnings
  Only make qrexec calls when necessary
  Squash more PyLint warnings
  Decode stderr in repo qrexec calls
  Fix error handling
  Fix `self` being undefined when showing warnings
  Only apply repo preferences when "OK" is clicked
  Don't use asserts for error handling
  Check that repo management succeeded
  Remove unnecessary assert
  Squash some PyLint warnings
  Add UI for managing Qubes update repositories
  Fix typo

Fixes QubesOS/qubes-issues#4550
2019-08-28 16:42:01 +02:00
Marek Marczykowski-Górecki
1e3c0bfcd8
Merge remote-tracking branch 'origin/pr/194'
* origin/pr/194:
  Fix arithmetic in init/max mem ratio correction
2019-08-28 15:52:22 +02:00
Marek Marczykowski-Górecki
6107a1fcbf
Merge remote-tracking branch 'origin/pr/192'
* origin/pr/192:
  Added virt mode column to Qube Manager
2019-08-28 15:50:29 +02:00
Marek Marczykowski-Górecki
b4b3588bf1
Minor fix qt4 -> qt5
Pylint detected one more missing QtGui->QtWidgets change.
2019-08-28 15:48:29 +02:00
Marek Marczykowski-Górecki
990e4abbbf
Merge remote-tracking branch 'origin/pr/178'
* origin/pr/178:
  Update Qt version used in qubesmanager to Qt5
2019-08-28 15:19:26 +02:00
Aras Ergus
bbe14f524d
Fix arithmetic in init/max mem ratio correction
Qubes Manager seems to try to guarantee that 10*init_mem is at
least max_mem by automatically adjusting init_mem to max_mem/10 if
inappropriate values are set. However, this may not guarantee that
10*init_mem >= max_mem due to rounding errors. This change fixes
these edge cases by basically rounding up the result of division
by 10.
2019-08-17 15:42:36 +02:00
Marek Marczykowski-Górecki
dde21e39ce
version 4.0.39 2019-08-10 04:05:03 +02:00
Marek Marczykowski-Górecki
3c9d7d3da4
firewall: service name can contain digits too 2019-08-10 03:54:35 +02:00
Marta Marczykowska-Górecka
dedde71d7a
Fixed bug with port numbers and services in VM settings
Opening an existing FW rule resulted in an invalid port number.
2019-08-09 14:16:30 +02:00
Marta Marczykowska-Górecka
1cd95fceb2
Added virt mode column to Qube Manager
Just another column that shows the
contents of virt_mode property.

fixes QubesOS/qubes-issues#4702
2019-08-08 17:30:15 +02:00
Marek Marczykowski-Górecki
f1a1c2cda3
version 4.0.38 2019-08-02 20:05:18 +02:00
Marek Marczykowski-Górecki
d5a4ddb7ef
Merge remote-tracking branch 'origin/pr/191'
* origin/pr/191:
  Fixed parsing port ranges in VM settings
  Better handling of port/service names for VM settings
2019-08-02 20:03:35 +02:00
Marta Marczykowska-Górecka
1d7d51eafd
Fixed parsing port ranges in VM settings
Now service names with dash ('-') in them will be parsed
correctly and not result in an error.

fixes QubesOS/qubes-issues#4766
2019-08-02 16:58:30 +02:00
Marta Marczykowska-Górecka
6cd02b47b3
Better handling of port/service names for VM settings
Now port will be displayed as port_number [(service name)]
, and not just service name. Also added a tooltip with explanation
of what can be put in the 'port/service' field, renamed
the field to 'Port/service' and added some examples of pure port
numbers to the drop down.

fixes QubesOS/qubes-issues#5211
2019-08-02 16:39:51 +02:00
Marek Marczykowski-Górecki
7c8b0d404d
version 4.0.37 2019-08-02 01:19:03 +02:00
Marta Marczykowska-Górecka
a1be2988ca
Fixed UI error
Default DispVM dropbown was displayed incorrectly.
Also fixed tab order.
2019-08-01 16:26:22 +02:00
Marta Marczykowska-Górecka
31e3f72ae0
Kernel sorting fix
Fixed bug with kernel versions ending with a letter,
hopefully now the sorting is even more robust and sensible.

fixes QubesOS/qubes-issues#5208
2019-07-31 23:00:00 +02:00
Marek Marczykowski-Górecki
1dadca8ed8
Merge remote-tracking branch 'origin/pr/189'
* origin/pr/189:
  Better settings for a newly created VM
  Changed checking for VM name in use
2019-07-31 17:29:00 +02:00
Marek Marczykowski-Górecki
1a147121f0
Merge remote-tracking branch 'origin/pr/188'
* origin/pr/188:
  Fixed silent fail in Boot from File window
2019-07-31 17:28:10 +02:00
Marek Marczykowski-Górecki
a1330e68ff
Merge remote-tracking branch 'origin/pr/186'
* origin/pr/186:
  Renamed DispVM and "Is DispVM template" for more readability
2019-07-31 17:27:00 +02:00
Marta Marczykowska-Górecka
4e9ed5e261
Better settings for a newly created VM
Now a standalone VM not cloned from a template
will not have a kernel and have HVM virt mode.

fixes QubesOS/qubes-issues#5203
2019-07-29 21:53:44 +02:00
Marta Marczykowska-Górecka
b19d9e1373
Changed checking for VM name in use
In near future the old way will stop working, so
this is a pre-emptive fix.
2019-07-29 21:52:40 +02:00
Marta Marczykowska-Górecka
349fb693be
Fixed silent fail in Boot from File window
Now, when selecting a file fails for some reason
(lack of installed file manager, VM crashed on start,
anything), the user will get an error message.

references QubesOS/qubes-issues#5202
2019-07-29 19:23:42 +02:00
Marta Marczykowska-Górecka
c0c9de75de
Renamed DispVM and "Is DispVM template" for more readability
Replaced instances of "Default DispVM" and "Is DVM Template" with
more readable "Default Disposable VM Template" and "Disposable VM Template"
respectively. Added tooltips.

fixes QubesOS/qubes-issues#4935
2019-07-18 22:28:01 +02:00
xaki23
61cb9acf3b
make else/default branch of version-detection non-fatal since any new-and-coming debian variants at this point probably are 4371 fixed to begin with 2019-07-09 23:37:26 +02:00
AJ Jordan
7245603628
Say which repository caused the error in warnings 2019-07-03 01:48:55 -07:00
AJ Jordan
352c0d0386
Only make qrexec calls when necessary
This helps in situations where the qrexec calls are forbidden; it also
prevents settings from being unintentionally changed and gives a
noticeable performance boost when the "OK" button is clicked.
2019-07-03 01:46:39 -07:00
AJ Jordan
e0919beec1
Squash more PyLint warnings
This definitely worked before, and I haven't touched this code recently
so I have no idea why these errors are just now popping up... but
whatever.
2019-07-02 16:04:04 -07:00
AJ Jordan
6a5823b74a
Decode stderr in repo qrexec calls
Before this change, "foobar\n" on stderr would be rendered (in the
warning dialog) as "b'foobar\n'", which is ugly. Now it'll be rendered
just as "foobar", followed by an actual newline character.
2019-07-02 13:45:21 -07:00
AJ Jordan
4931bf9401
Fix error handling
Apparently Python exceptions don't take **kwargs, so we just pass a
dictionary as the second (regular) argument. While we're at it, we
pretty-print said dictionary when displaying error messages.
2019-07-02 13:37:29 -07:00
AJ Jordan
33ef478626
Fix self being undefined when showing warnings 2019-07-02 13:07:06 -07:00
AJ Jordan
026a844a91
Only apply repo preferences when "OK" is clicked 2019-07-02 12:36:29 -07:00
AJ Jordan
f3305b8288
Don't use asserts for error handling 2019-07-02 12:36:22 -07:00