Marek Marczykowski-Górecki
146ce683f7
Merge remote-tracking branch 'qubesos/pr/122'
...
* qubesos/pr/122:
And also fixed problem with setting default template to None
Fixed problem with setting default_dispvm to None in Global Settings
2018-07-24 01:39:33 +02:00
Marta Marczykowska-Górecka
a4c63cc939
And also fixed problem with setting default template to None
...
The bug was the same.
2018-07-22 23:57:50 +02:00
Marta Marczykowska-Górecka
6377983f9a
Fixed problem with setting default_dispvm to None in Global Settings
...
fixes QubesOS/qubes-issues#4114
2018-07-22 23:55:09 +02:00
Marta Marczykowska-Górecka
7b29a044d6
Fixed column widths in Qube Manager
...
Columns were resizing incorrectly (with too large minimums).
fixes QubesOS/qubes-issues#4002
2018-07-20 23:14:06 +02:00
Marta Marczykowska-Górecka
5e52b16fd3
Minor changes as requested
...
Minor changes as requested by @marmarek
2018-07-20 17:48:39 +02:00
Marta Marczykowska-Górecka
027abd8ac3
Pylint corrections
...
Pylint 2.0 was complaining. Cosmetic fixes to make it stop.
2018-07-20 00:25:27 +02:00
Christopher Laprise
b2fdbb950a
Handling VM dependencies in GUI tools
...
Added the following reactions ot VM dependencies in GUI tools:
- Qube Manager will inform the user why they cannot delete a VM (which
properties of which VMS [or global] are using the VM)
- Settings window will try to intelligently rename VMs (change
properties to the new name, if possible, and inform the user what went
wrong if not)
- Settings window will inform the user why they cannot delete a VM
Also, renaming VM from Settings launched from Qube Manager will
refresh the VM list through a horrible hack, to be replaced by a neater
Admin API solution in some near future.
depends on ca848ca7bdfixes QubesOS/qubes-issues#3992
fixes QubesOS/qubes-issues#3993
fixes QubesOS/qubes-issues#3892
fixes QubesOS/qubes-issues#3499
2018-07-20 00:03:37 +02:00
Marta Marczykowska-Górecka
d46bf2aa8e
Improved communication on Remove VM in Qube Manager
...
When a user tries to remove a VM that's used by other VMs
or Global Settings from Qube Manager, they get information
about where the VM is used.
Depends on https://github.com/QubesOS/qubes-core-admin-client/pull/73
2018-07-18 23:51:37 +02:00
Marek Marczykowski-Górecki
b8c1ec8dac
Merge remote-tracking branch 'qubesos/pr/119'
...
* qubesos/pr/119:
Make Qube Manager remember its size from last time
2018-07-17 15:57:59 +02:00
Marek Marczykowski-Górecki
9bb6a8cc94
Merge remote-tracking branch 'qubesos/pr/118'
...
* qubesos/pr/118:
Fixed incorrect kernel display in VM settings
2018-07-17 15:56:09 +02:00
Marta Marczykowska-Górecka
e5dee2d70c
Make Qube Manager remember its size from last time
...
Qube Manager will now remember its size from last time it was run, and
also it will no longer force itself to appear at top left corner of
the screen.
fixes QubesOS/qubes-issues#4049
2018-07-16 18:47:07 +02:00
Marta Marczykowska-Górecka
af5aa233bb
Fixed incorrect kernel display in VM settings
...
Kernel set to 'None' was incorrectly displayed as 'default'.
fixes QubesOS/qubes-issues#4043
2018-07-16 17:35:35 +02:00
Marek Marczykowski-Górecki
18d45e53c6
Merge remote-tracking branch 'qubesos/pr/115'
...
* qubesos/pr/115:
Make 'NetVm' column in Qube Manager clearer with regars to defaults
2018-07-16 14:15:12 +02:00
Marta Marczykowska-Górecka
7fb41f5cd6
Make 'NetVm' column in Qube Manager clearer with regars to defaults
...
When a VM has netvm set to 'default', now Qube Manager will display
'(default)' in front of the netvm's name.
references QubesOS/qubes-issues#3567
2018-07-16 14:07:27 +02:00
Marek Marczykowski-Górecki
f62aeb51d6
Merge remote-tracking branch 'qubesos/pr/116'
...
* qubesos/pr/116:
Add a list of Suggested Services to VM settings
2018-07-16 13:52:47 +02:00
Marta Marczykowska-Górecka
6f4870bc8d
Changes to for pylint 2.0
...
Fixes to make pylint 2.0 stop complaining.
2018-07-16 02:17:48 +02:00
Marta Marczykowska-Górecka
63a202f3bd
Add a list of Suggested Services to VM settings
...
Added a list of suggested services to the Services tab in VM Settings.
The list is drawn from man qvm-services (manually, not automatically).
fixes QubesOS/qubes-issues#3891
2018-07-16 01:33:20 +02:00
Marta Marczykowska-Górecka
3f0af4498c
Fixed VM name validation in GUI tools (Create VM, Settings, Manager)
...
VM name validation in various places in Manager did not allow a
perfectly legal '_' character.
references QubesOS/qubes-issues#2422
2018-07-13 21:05:00 +02:00
Marek Marczykowski-Górecki
0a44c931da
Merge remote-tracking branch 'qubesos/pr/109'
...
* qubesos/pr/109:
Pylint whitespace fix
Fixed Backup GUI size
Add option to turn off computer after backup to Backup GUI
2018-07-12 23:47:35 +02:00
Marek Marczykowski-Górecki
0c103e08b7
Merge remote-tracking branch 'qubesos/pr/106'
...
* qubesos/pr/106:
Offset context menu in Manager to avoid accidental clicks
2018-07-12 23:42:55 +02:00
Marek Marczykowski-Górecki
5e4ac80ed2
Merge remote-tracking branch 'qubesos/pr/105'
...
* qubesos/pr/105:
Remove templates from listing in UpdateVM and ClockVm in Global Settings
2018-07-12 23:41:47 +02:00
Marek Marczykowski-Górecki
bd7d3e576a
Merge remote-tracking branch 'qubesos/pr/103'
...
* qubesos/pr/103:
Fixed identation and other problems on merge
Fix minor performance bug
Removed unneeded manual sort
Avoid lag on loading dialog
Removed unneeded try/except
Protect update() from accesing deleted domains
Sort performance boost
2018-07-12 23:40:15 +02:00
Marta Marczykowska-Górecka
9d16bec870
Pylint whitespace fix
...
Removed superfluous whitespace.
2018-07-12 23:31:30 +02:00
Marek Marczykowski-Górecki
635171c4f4
Merge remote-tracking branch 'qubesos/pr/100'
...
* qubesos/pr/100:
Modified Qube Manager menu for dom0
2018-07-12 23:27:53 +02:00
Marta Marczykowska-Górecka
80b3a82963
Add option to turn off computer after backup to Backup GUI
...
A simple checkbox to turn off the computer after backup finishes
successfully. It is off by default and must be switched on every time
(unexpected system shutdowns are a huge pain, much more problematic
than forgetting to shut down can be).
fixes QubesOS/qubes-issues#2039
2018-07-12 22:47:02 +02:00
Marta Marczykowska-Górecka
5bdca303b1
Offset context menu in Manager to avoid accidental clicks
...
Small fix to Qubes Manager to open the context menu slightly to the
right of the mouse to avoid accidental clicks. Originally created by
@unman , ported to 4.0 and including changes to context menu from
pull request#100.
fixes QubesOS/qubes-issues#1911
2018-07-12 21:47:01 +02:00
Marta Marczykowska-Górecka
efa2b2d858
Remove templates from listing in UpdateVM and ClockVm in Global Settings
...
A user should not be able to set a TemplateVM as an UpdateVM or ClockVM
in Global Settings.
fixes QubesOS/qubes-issues#1831
2018-07-12 21:22:15 +02:00
Marta Marczykowska-Górecka
2f2217060e
Modified Qube Manager menu for dom0
...
Instead of generic menu with almost everything grayed-out, now
context menu for dom0 has only Global Settings, Logs and update.
references QubesOS/qubes-issues#1382
fixes QubesOS/qubes-issues#1165
2018-07-12 15:38:27 +02:00
donoban
d886983c02
Fixed identation and other problems on merge
2018-07-12 02:00:17 +02:00
donoban
8096a50f7f
Merge remote-tracking branch 'upstream/master'
...
# Conflicts:
# qubesmanager/table_widgets.py
2018-07-12 01:42:36 +02:00
donoban
5ddd029d34
Fix minor performance bug
2018-07-12 01:26:34 +02:00
Marek Marczykowski-Górecki
b0e275bb3e
Merge remote-tracking branch 'qubesos/pr/101'
...
* qubesos/pr/101:
Removed 'close window' button in progress dialogs in Qube Manager
2018-07-12 01:23:45 +02:00
donoban
1d80837cd0
Removed unneeded manual sort
...
Same its called later during init process
2018-07-12 01:22:28 +02:00
donoban
14f58fe8c1
Avoid lag on loading dialog
2018-07-12 01:21:04 +02:00
donoban
632f23c298
Removed unneeded try/except
2018-07-12 01:19:20 +02:00
donoban
bd919e44c1
Protect update() from accesing deleted domains
2018-07-12 01:17:48 +02:00
donoban
06f7262140
Sort performance boost
...
Cached all variables used by sort functions
2018-07-12 01:10:00 +02:00
Marta Marczykowska-Górecka
ce80245626
Removed 'close window' button in progress dialogs in Qube Manager
...
The ability to close window suggested to the user (falsely) that
they can close the window and thus abort the operation (like deleting
a VM). To avoid confusion, the button has been exorcised.
fixes QubesOS/qubes-issues#1479
2018-07-11 17:58:56 +02:00
Marta Marczykowska-Górecka
d4ecd23d0a
Correct sorting of VMs in Qube Manager
...
Fixed two situations in which there was no sub-sorting alphabetically.
fixes QubesOS/qubes-issues#1022
2018-07-11 16:13:26 +02:00
Marek Marczykowski-Górecki
16ced0466a
Merge remote-tracking branch 'qubesos/pr/97'
...
* qubesos/pr/97:
Fixed error with large logs
Log dialog viewer as a separate tool
2018-06-27 03:28:32 +02:00
Marek Marczykowski-Górecki
7a5c304c1e
Merge remote-tracking branch 'qubesos/pr/95'
...
* qubesos/pr/95:
Revert last and removed pylint disables
Added BaseException
Show updates pending while running domain
Fix search coherence when adding a domain
Last no-member
Try with disable=no-member
Another try for travis
Disable no-name-in-module
Fix pylint warnings
Fix very unlikely case when user right clicks the VM in the exact moment he deletes it.
Don't close the settings window if something failed when renaming e.g. the VM name already exists
Revert "Since __lt__ methods are safe, is not needed to stop and reenable sorting."
Added standalone VM's to check_updates() Also added an initial call when creating the timer, most users will look for updates inmediately after start the manager
Since __lt__ methods are safe, is not needed to stop and reenable sorting. It causes a short freeze of the main window when reenabling, so better removing it.
Added try/except for all __lt__() methods since some VM could be deleted before the signal is received and handled.
2018-06-27 03:07:46 +02:00
Marta Marczykowska-Górecka
4933c6b580
Fixed error with large logs
...
Due to change in file.seek() behavior, the log
viewer errorer when faced with a very large file.
2018-06-20 23:08:22 +02:00
Marta Marczykowska-Górecka
6b206d2050
Log dialog viewer as a separate tool
...
Added entry point and main() to enable
using log viewer as a separate tool.
2018-06-20 21:01:49 +02:00
donoban
3b1057c2e9
Revert last and removed pylint disables
2018-06-14 01:28:07 +02:00
donoban
877eeaac2a
Added BaseException
2018-06-13 21:38:39 +02:00
Marta Marczykowska-Górecka
8de26419c1
Fixed a bug with warnings not modal in VM Settings
...
Warnings and error messages in VM settings were not
modal and thus could be erroneously hidden.
fixes QubesOS/qubes-issues#3959
2018-06-12 22:50:03 +02:00
donoban
34bcabd79a
Show updates pending while running domain
...
Maybe it is not useful for templates but I think it is better for StandaloneVMs since you will not notice pending updates until shutdown them with the other version.
2018-06-12 11:42:07 +02:00
donoban
52c38b67c6
Fix search coherence when adding a domain
...
A new domain was not properly filtered with the current
search string
2018-06-11 21:20:18 +02:00
donoban
9101f35245
Last no-member
2018-06-11 03:18:11 +02:00
donoban
b8d1cc4205
Try with disable=no-member
2018-06-11 03:06:35 +02:00
donoban
643147f525
Another try for travis
2018-06-11 02:46:31 +02:00
donoban
0c4047ffde
Disable no-name-in-module
...
Maybe travis works this way
2018-06-11 02:26:02 +02:00
donoban
2a437bcfc4
Fix pylint warnings
2018-06-11 01:56:10 +02:00
donoban
b8cb0f625b
Fix very unlikely case when user right clicks the VM in the exact moment he
...
deletes it.
2018-05-31 00:47:38 +02:00
donoban
cb5bc16948
Don't close the settings window if something failed when renaming
...
e.g. the VM name already exists
2018-05-31 00:39:34 +02:00
donoban
4d103562bd
Revert "Since __lt__ methods are safe, is not needed to stop and reenable sorting."
...
This reverts commit ac92bb5fdf
2018-05-31 00:27:37 +02:00
donoban
47e83f2039
Added standalone VM's to check_updates()
...
Also added an initial call when creating the timer, most users will look
for updates inmediately after start the manager
2018-05-31 00:11:30 +02:00
donoban
ac92bb5fdf
Since __lt__ methods are safe, is not needed to stop and reenable sorting.
...
It causes a short freeze of the main window when reenabling, so better
removing it.
2018-05-31 00:09:34 +02:00
donoban
ae23443608
Added try/except for all __lt__() methods since some VM could be deleted
...
before the signal is received and handled.
It fixes renaming a VM and deleting two domains at same time.
2018-05-31 00:04:46 +02:00
Marek Marczykowski-Górecki
85dc0f9083
Merge remote-tracking branch 'qubesos/pr/94'
...
* qubesos/pr/94:
Fix for bug in VM Settings
2018-05-22 03:51:31 +02:00
Marek Marczykowski-Górecki
24a5850507
Merge remote-tracking branch 'qubesos/pr/93'
...
* qubesos/pr/93:
Tiny fix to make pylint stop complaining
Fixes unwanted behavior in VM settings
2018-05-22 03:50:16 +02:00
Marek Marczykowski-Górecki
5b752fc55b
Merge remote-tracking branch 'qubesos/pr/91'
...
* qubesos/pr/91: (27 commits)
Fix long line warning
Pretty confusion with regex trying to make travis happy
Added exceptions for domain add and remove
Fix pylint and travis errors
Fix misspelling on Updates Timer() and better timeout
Added missing updates() method for some widget
Fix missing template updates-available
Added startup progress dialog
More elegant fix for settings size
Removed debug print
Outdated state cleanup
Revert "Removed progress wait when updating template"
This tries to fix some rare case when it stops receieving dbus events
Added Timer for template updates
Refresh table selection when pause/resume
Added calls to table_selection_changed()
VmRowInTable dbus events moved to VmManagerWindow
Set settings dialog to minimun size, it gets adjusted properly to good view
- Removed unnedeed calls to vms_in_table[vm.qid].update()
- Removed update_single_row() and add direct calls to update() (Some of them could be deleted since dbus events will handle them)
...
2018-05-22 03:30:21 +02:00
donoban
045c3bf98e
Fix long line warning
2018-05-20 22:14:31 +02:00
donoban
fe6a477074
Pretty confusion with regex trying to make travis happy
2018-05-20 22:00:34 +02:00
donoban
b5808296bf
Added exceptions for domain add and remove
2018-05-20 21:50:40 +02:00
donoban
8327e32e1f
Fix pylint and travis errors
2018-05-20 21:30:50 +02:00
Marta Marczykowska-Górecka
d3bd164e2f
Tiny fix to make pylint stop complaining
2018-05-17 19:58:44 +02:00
Marta Marczykowska-Górecka
455fea7d37
Fix for bug in VM Settings
...
Adding a nonexisting service will no longer add "any" service.
2018-05-17 19:56:28 +02:00
Marta Marczykowska-Górecka
744ddfcc80
Fixes unwanted behavior in VM settings
...
Whenever Enter was pressed, the Settings window
closed and applied changes, which was very unintuitive
especially in case of Services tab.
references QubesOS/qubes-issues#3891
2018-05-17 19:41:20 +02:00
donoban
edbc4c4469
Fix misspelling on Updates Timer() and better timeout
...
This func is pretty cheap, less than 0.1ms adding two calls to print(time)
so I think 30s is a reasonable timeout and better for user experience
2018-05-11 10:27:19 +02:00
Peter Gerber
031ad02ff6
Settings window: do not crash when there is no firewall rule
...
When all firewall rules are removed, qubes-vm-settings crashed
trying to check if the last rule accepts or drops all packages.
It is now verifies that there is a last rule.
Also, it is now properly verified that the last rule accept
or drops all packages.
Associated stack trace:
----
line: last_rule = reversed_rules.pop(0)
func: get_firewall_conf
line no.: 227
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: conf = self.get_firewall_conf(vm)
func: set_vm
line no.: 308
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: model.set_vm(vm)
func: __init__
line no.: 111
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: settings_window = VMSettingsWindow(vm, qapp, args.tab)
func: main
line no.: 1133
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: load_entry_point('qubesmanager==4.0.17', 'console_scripts', 'qubes-vm-settings')()
func: <module>
line no.: 9
file: /usr/bin/qubes-vm-settings
2018-05-11 01:24:22 +00:00
donoban
c43a47019e
Added missing updates() method for some widget
...
internal, ip, include_in_backups and last_backup
2018-05-10 17:59:07 +02:00
donoban
a77cc5172d
Fix missing template updates-available
2018-05-10 10:04:17 +02:00
donoban
78ba3057eb
Added startup progress dialog
2018-05-10 09:49:22 +02:00
donoban
1dcfc6e634
Removed debug print
2018-05-09 19:42:45 +02:00
donoban
224c8708fc
Outdated state cleanup
...
Fixes problems showing 'outdated' instead 'to-be-outdated' when template is running
Fixes the removal of the icon calling setVisible(False) before removeWidget()
2018-05-09 19:39:41 +02:00
donoban
e2fccf592a
Revert "Removed progress wait when updating template"
...
This reverts commit 9633f6e9c6
2018-05-09 15:50:39 +02:00
donoban
ce07b9dcb1
This tries to fix some rare case when it stops receieving dbus events
2018-05-09 14:37:46 +02:00
donoban
806915f834
Added Timer for template updates
...
Since there is no template updates dbus events, we need to check it periodically
2018-05-09 14:36:39 +02:00
donoban
bc07e37266
Refresh table selection when pause/resume
...
Since them dont have dbus events we need to manually update the selection
2018-05-09 12:05:07 +02:00
donoban
e2e66cbccb
Added calls to table_selection_changed()
...
If row updated is the selected row we need to update start/pause/stop buttons
2018-05-09 11:48:19 +02:00
donoban
027d106507
VmRowInTable dbus events moved to VmManagerWindow
...
Since we need to do some updates affecting all vms or the Window itself, this is a better place for handling this.
2018-05-09 11:31:44 +02:00
donoban
bfc54b779f
- Removed unnedeed calls to vms_in_table[vm.qid].update()
...
- Fixed unpause case where it was not properly updated
2018-05-07 22:50:13 +02:00
donoban
5e6c0539c2
- Removed update_single_row() and add direct calls to update()
...
(Some of them could be deleted since dbus events will handle them)
- Removed update_table() and TODO refering dbus events
2018-05-07 22:26:39 +02:00
donoban
5b846a73cc
Removed unneeded calls to table.update()
2018-05-07 22:21:17 +02:00
donoban
8753119327
Initial version with dbus
...
- Added connections for PropertiesChanged for each VM in VmRowInTable
- DomainAdded/Removed handled in VmManager
2018-05-07 21:10:15 +02:00
donoban
ddf2e73f20
- Remove some stuff on fill_table since its only called once on startup
...
- Removed table.setEnabled/Disabled tweak since I dont see any improvement, maybe because
fill_table() is only called without the window shown
- Removed unneeded update_table() calls, dbus events will handle them
2018-05-07 20:50:20 +02:00
donoban
be055d8b41
Revert order of fill_table() and show() and removed the timer
...
This does not seem to have any problem and the manager window appears already filled which seems more user friendly
2018-05-07 13:30:03 +02:00
donoban
07d36a9149
Added update() methods on some widgets for update them without recreating
...
Fixed some problems with update/status notifications, probably need some additional tunning
2018-05-07 13:17:43 +02:00
donoban
9633f6e9c6
Removed progress wait when updating template
2018-05-03 11:34:11 +02:00
Marta Marczykowska-Górecka
5cfa0bb9c0
Fix bug in Qube Manager
...
Accidentaly, the fix significantly improves start time (at least on two
of my machines).
fixes QubesOS/qubes-issues#3760
2018-03-30 01:15:23 +02:00
Marek Marczykowski-Górecki
f74783af7e
Merge remote-tracking branch 'qubesos/pr/84'
...
* qubesos/pr/84:
Tiny fix for Qube Manager params
2018-03-28 18:02:16 +02:00
Marta Marczykowska-Górecka
674b80613d
Tiny fix for Qube Manager params
...
Made Qube Manager params consistent with other manager
tools (first Qt, then Qubes).
2018-03-28 17:43:57 +02:00
Marek Marczykowski-Górecki
d4324d4873
Merge remote-tracking branch 'qubesos/pr/83'
...
* qubesos/pr/83:
Fix for updates-available in qube-manager
2018-03-28 17:36:20 +02:00
Marek Marczykowski-Górecki
91fbc43b5e
Merge remote-tracking branch 'qubesos/pr/82'
...
* qubesos/pr/82:
Check if VM needs killing before murdering it
2018-03-28 16:42:55 +02:00
Marek Marczykowski-Górecki
68b6f2351c
Merge remote-tracking branch 'qubesos/pr/81'
...
* qubesos/pr/81:
Less horrible Qube Manager loading
2018-03-28 16:42:15 +02:00
Marta Marczykowska-Górecka
70d139e7f3
Fix for updates-available in qube-manager
...
After fixing another bug, update status for a VM was not
initialized correctly.
fixes QubesOS/qubes-issues#3745
2018-03-26 18:21:46 +02:00
Marta Marczykowska-Górecka
20cabb5563
Check if VM needs killing before murdering it
...
In some cases, when the user waited some time before force-killing a VM,
it could be already dead.
fixes QubesOS/qubes-issues#3730
2018-03-25 12:29:05 +02:00
Marek Marczykowski-Górecki
2d6b6488ea
Merge remote-tracking branch 'qubesos/pr/79'
...
* qubesos/pr/79:
Fixed GUI Restore tool bug
2018-03-20 01:26:44 +01:00
Marta Marczykowska-Górecka
3ca7520b0e
Less horrible Qube Manager loading
...
The window should first display itself, and then get gradually filled with VMs
(more user friendly, less annoying than waiting for something, anything
to appear).
Also fixed a dumb bug with double refreshing and a useless variable.
fixes QubesOS/qubes-issues#3719
2018-03-19 22:40:50 +01:00
Marta Marczykowska-Górecka
7117892f4b
Fixed GUI Restore tool bug
...
GUI Restore tool was unable to open file selection dialog in dom0.
fixes QubesOS/qubes-issues#3701
2018-03-15 00:18:43 +01:00
Marta Marczykowska-Górecka
7ed386985d
Added default_dispvm to Global Settings
...
Added "default dispvm" to Global Settings.
references QubesOS/qubes-issues#3688
2018-03-14 22:21:33 +01:00
Marek Marczykowski-Górecki
e1aca0a393
Merge remote-tracking branch 'qubesos/pr/77'
...
* qubesos/pr/77:
Don't catch AttributeError for is_outdated() call anymore
Call is_outdated() on volume object, not name
2018-03-14 21:36:29 +01:00
Marek Marczykowski-Górecki
feeedb5526
Merge remote-tracking branch 'qubesos/pr/76'
...
* qubesos/pr/76:
Fixed a bunch of useless asserts
2018-03-14 21:33:57 +01:00
Marek Marczykowski-Górecki
b0ebb76bf3
Merge remote-tracking branch 'qubesos/pr/75'
2018-03-14 21:33:01 +01:00
Rusty Bird
24dcb4802e
Don't catch AttributeError for is_outdated() call anymore
2018-03-14 00:07:22 +00:00
Rusty Bird
774b3bb2c9
Call is_outdated() on volume object, not name
...
Note that this is still a no-op, because admin.vm.volume.Info does not
transmit is_outdated, so the qubesadmin wrapper defaults it to False.
2018-03-14 00:07:21 +00:00
Marta Marczykowska-Górecka
fcaca57fc6
Fixed a bunch of useless asserts
...
Replaced them with a more flexible behavior or removed if they were
not actually necessary (and handled elsewhere).
fixes QubesOS/qubes-issues#3623
2018-03-10 22:31:41 +01:00
Marta Marczykowska-Górecka
bce5c32c96
Added "Exit" option to Qube Manager
...
fixes QubesOS/issues#3683
2018-03-10 20:04:57 +01:00
Marta Marczykowska-Górecka
91538f1aaf
Apply changes in global settings only when actual changes occurred
...
Fixed apply methods to check if there is an actual need to apply
changes.
2018-03-02 14:30:56 +01:00
Marta Marczykowska-Górecka
43520331f2
Fix pylint's critique
2018-03-02 01:04:02 +01:00
Marta Marczykowska-Górecka
94c0a45f86
Fixed minor error in previous fix
2018-03-02 00:43:43 +01:00
Marta Marczykowska-Górecka
b08ce9524f
Replaced single check vm updates checkbox
...
Now there is a checkbox for the default for new VMs, and two
buttons to either disable checking for updates in all VMs or enable it
in all VMs.
2018-02-22 22:24:34 +01:00
Marta Marczykowska-Górecka
02117b1870
Restored check-dom0-updates functionality in Global Settings
...
Currently it uses a workaround, manually creating a file in
/var/lib/qubes/updates; once the appropriate attribute will start working
it will be used instead.
2018-02-22 22:22:45 +01:00
Marta Marczykowska-Górecka
0700275586
De-uglify kernel selection in Global Settings
...
Replaced kernel selection with utils.prepare_kernel; also added option
to utils.prepare_choice to treat empty string as None (applicable to
kernels).
2018-02-22 22:22:42 +01:00
Marta Marczykowska-Górecka
4882013a32
De-uglify default template in Global Settings
...
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
84d7e8bf9c
Allow setting default NetVM to None in Global Settings
...
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
29a56d9c88
Fixed error in setting Clockvm to None in Global Settings
...
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
c1e9074cb9
Fixed error in setting Updatevm to None in Global Settings
...
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
2018-02-22 22:21:39 +01:00
Marek Marczykowski-Górecki
fb4870a16b
Merge remote-tracking branch 'qubesos/pr/72'
...
* qubesos/pr/72:
Added 'Apply' button to VM Settings
2018-02-22 18:15:23 +01:00
Marek Marczykowski-Górecki
fb8b19af81
Merge remote-tracking branch 'qubesos/pr/71'
...
* qubesos/pr/71:
Fixed bug 3594
2018-02-22 18:14:28 +01:00
Marek Marczykowski-Górecki
a141e40e9c
Merge remote-tracking branch 'qubesos/pr/70'
...
* qubesos/pr/70:
Allow restarting auto_cleanup=False DispVMs
2018-02-22 18:13:32 +01:00
Marta Marczykowska-Górecka
8218f5fde1
Added 'Apply' button to VM Settings
...
Simple "Apply" button.
fixes QubesOS/qubes-issues#3321
2018-02-20 20:32:00 +01:00
Marta Marczykowska-Górecka
dc0f8c0a9e
Fixed bug 3594
...
Incorrect targetVM display - dom0 was not included, and the code
erroneously assumed that not only it is included, but also it's always
the first in the dropdown. No more assumptions.
fixes QubesOS/qubes-issues#3594
2018-02-20 19:22:57 +01:00
Rusty Bird
07866cbfc4
Allow restarting auto_cleanup=False DispVMs
2018-02-20 08:25:22 +00:00
Marta Marczykowska-Górecka
e95be8a8ed
Is this bug finally dead
...
Yet another attempt at stomp this zombie monstrosity.
fixes QubesOS/qubes-issues#3570
2018-02-13 20:26:55 +01:00
Marek Marczykowski-Górecki
b3699d27d5
Merge remote-tracking branch 'qubesos/pr/67'
...
* qubesos/pr/67:
Boot from device window fix
2018-02-13 05:06:06 +01:00
Marek Marczykowski-Górecki
09805396bb
Merge remote-tracking branch 'qubesos/pr/65'
...
* qubesos/pr/65:
Changes according to @marmarek's request
Shutting down vm from qube manager bug
Refreshing vm list in qube manager fixed
Qube manager updates more sensibly
2018-02-13 05:05:24 +01:00
Marta Marczykowska-Górecka
8640fa7ace
Boot from device window fix
...
The window wasn't closing properly.
2018-02-11 00:20:14 +01:00
Marta Marczykowska-Górecka
45959aef71
Changes according to @marmarek's request
2018-02-10 23:41:36 +01:00
Marek Marczykowski-Górecki
ec7c65de34
Merge remote-tracking branch 'qubesos/pr/64'
...
* qubesos/pr/64:
Bugfixed
Fixed error in creating new VMs from GUI
2018-02-10 23:41:10 +01:00
Marek Marczykowski-Górecki
83936ba93e
Merge remote-tracking branch 'qubesos/pr/66'
...
* qubesos/pr/66:
Fixed incorrect default dispvm settings
2018-02-10 23:35:12 +01:00
Marta Marczykowska-Górecka
c1bb8ba2ad
Bugfixed
...
According to @marmarek's request
2018-02-10 23:34:59 +01:00
Marek Marczykowski-Górecki
712e95617a
Merge remote-tracking branch 'qubesos/pr/63'
...
* qubesos/pr/63:
Fixed bug with template selection
Fixed errors with virt mode choice
2018-02-10 23:28:39 +01:00
Marek Marczykowski-Górecki
1fe280538e
Merge remote-tracking branch 'qubesos/pr/61'
...
* qubesos/pr/61:
Once more to fix this pesky bug
2018-02-10 23:24:17 +01:00
Marta Marczykowska-Górecka
8da0d35110
Fixed incorrect default dispvm settings
...
Fixed error in DispVM selection in VM settings
fixes QubesOS/qubes-issues#3565
2018-02-10 22:54:00 +01:00
Marta Marczykowska-Górecka
5af2709029
Shutting down vm from qube manager bug
...
Hopefully, finally fixes issue #3501 .
fixes QubesOS/qubes-issues#3501
2018-02-09 22:08:07 +01:00
Marta Marczykowska-Górecka
1d995de095
Refreshing vm list in qube manager fixed
...
If a new VM was created via button in vm settings, the refresh button will now correctly display it.
2018-02-09 21:59:43 +01:00
Marta Marczykowska-Górecka
dac7a6f208
Qube manager updates more sensibly
...
Many events now cause the Qube Manager to refresh better - just the appropriate row, for example.
2018-02-09 21:36:30 +01:00
Marta Marczykowska-Górecka
dc9f764baa
Fixed error in creating new VMs from GUI
...
Virt mode was forcibly set to HVM. Now, the virt mode is left as default,
unless a standalone VM with system installed from elsewhere is selected.
fixes QubesOS/qubes-issues#3515
2018-02-06 15:47:00 +01:00
Marta Marczykowska-Górecka
0ec3c704dd
Fixed bug with template selection
...
Template in VM settings was not displayed correctly. It should work now.
2018-02-06 15:38:20 +01:00
Marta Marczykowska-Górecka
2be8f8bcea
Fixed errors with virt mode choice
...
Current virtualization mode wasn't displayed correctly. It should work now.
fixes QubesOS/qubes-issues#3517
2018-02-06 15:31:17 +01:00
Marta Marczykowska-Górecka
81e5a92e66
Once more to fix this pesky bug
...
fixes QubesOS/qubes-issues#3501
2018-01-30 17:11:28 +01:00
Marek Marczykowski-Górecki
b28bd6e797
Merge remote-tracking branch 'qubesos/pr/60'
...
* qubesos/pr/60:
Repaired manager icons
Removed 'Seamless GUI' checkbox from VM settings
Change default Qube Manager size
Renamed 'VM' to 'qube' everywhere in manager
2018-01-29 23:55:07 +01:00
Marta Marczykowska-Górecka
71090b9e72
Change default Qube Manager size
...
So that it will fit all VMs from a default install.
2018-01-28 20:38:40 +01:00
Marta Marczykowska-Górecka
3a60f9146a
Renamed 'VM' to 'qube' everywhere in manager
...
At least I hope it's everywhere.
Note: AppVM and NetVM nomenclature have been kept as before.
2018-01-28 20:26:29 +01:00
Marta Marczykowska-Górecka
cb1519b56c
Fixed error on VM shutdown in Qube Manager
...
fixes QubesOS/qubes-issues#3501
2018-01-28 18:23:18 +01:00
Marta Marczykowska-Górecka
4ec36de20d
Changes as requested by @marmarek
2018-01-26 23:17:02 +01:00
Marta Marczykowska-Górecka
46fe3725d1
Refresh Qube Manager list after closing VM settings
...
Now the Qube Manager refreshes VM list after VM settings are launched
and closed.
2018-01-23 20:44:59 +01:00
Marta Marczykowska-Górecka
cd8a243f5c
Fixes to resizing in Qube Manager
...
Change column resize mode to interactive and stretch last column, so there's no useless space on the right. Also minor fix to sorting last_timestamp column, for more readability and also to fix a rare bug.
2018-01-23 20:28:19 +01:00
Marek Marczykowski-Górecki
81413907bf
Merge remote-tracking branch 'qubesos/pr/55'
...
* qubesos/pr/55:
Fixed according to @marmarek request
Fixed according to @marmarek request
Added 'configure no strict reset for PCI devices' button
Adding a button to list PCI devices and enable no-strict-reset
Fixed some indents and whitespaces
Fixed python2 in settings.py
2018-01-19 03:01:57 +01:00
Marta Marczykowska-Górecka
b158aeccbd
Fixed according to @marmarek request
2018-01-19 02:50:04 +01:00
Marta Marczykowska-Górecka
1b9737c1a7
Fixed according to @marmarek request
2018-01-19 01:48:46 +01:00
Marta Marczykowska-Górecka
03ba645009
Fixed according to @marmarek request
2018-01-19 01:24:11 +01:00
Marta Marczykowska-Górecka
f1964f0c5b
Merge branch 'master' into virt-mode-select-fixes
2018-01-19 00:36:38 +01:00
Marta Marczykowska-Górecka
2cffffdcff
Fixed error in qubesmanager utils
...
Fix in app.labels caused an old workaround to malfunction.
fixes QubesOS/qubes-issues#3475
2018-01-18 23:49:17 +01:00
Marta Marczykowska-Górecka
985f8fb56d
Fixed error in qube-manager
...
Last backup timestamp was not correctly processed.
2018-01-18 23:42:34 +01:00
Marta Marczykowska-Górecka
484f724838
Fixes to make pylint stop complaining
2018-01-17 12:13:04 +01:00
Marta Marczykowska-Górecka
48c3bfa798
Merge branch 'master' into virt-mode-select-fixes
2018-01-16 20:04:16 +01:00
Marta Marczykowska-Górecka
1a5a1fa7ee
Minor fixes to virt_mode select pull request
...
Changes:
- added hints about "which virt mode should I use"
- changed displayed virt modes to show modes in all caps
closes #44
2018-01-16 19:56:45 +01:00
Marta Marczykowska-Górecka
801014f2e5
Added 'configure no strict reset for PCI devices' button
...
The button is in 'devices' tab of VM settings; it allows the user to
select which devices should have 'no-strict-reset' enabled and tells
the user not to change this setting if there are no errors.
fixes QubesOS/qubes-issues#3205
2018-01-13 00:25:48 +01:00
Marta Marczykowska-Górecka
f4fae54057
Adding a button to list PCI devices and enable no-strict-reset
2018-01-13 00:25:46 +01:00
Marta Marczykowska-Górecka
60143e6a91
Fixed some indents and whitespaces
...
Fixed indents and whitespace that pylint was complaining about.
2018-01-13 00:25:02 +01:00
Marta Marczykowska-Górecka
ec3d6eb84a
Fixed python2 in settings.py
...
settings.py was erroneously using python2. Replaced with python3.
2018-01-13 00:19:58 +01:00
Marek Marczykowski-Górecki
90f7f8474d
Merge remote-tracking branch 'qubesos/pr/54'
...
* qubesos/pr/54:
Fixed minor error in VM Settings
2018-01-12 04:39:31 +01:00
Marek Marczykowski-Górecki
57d723c61e
Merge remote-tracking branch 'qubesos/pr/53'
...
* qubesos/pr/53:
Renamed 'VM' to 'qube' in GUI
Added warning that the VM is currently running
Fixed missing import
2018-01-12 04:37:00 +01:00
Marta Marczykowska-Górecka
670c41e4ff
Fixed minor error in VM Settings
...
When init page was 'firewall', the tool incorrectly displayed warnings about wrong firewall vm configuration, without actually checking if they should be displayed.
2018-01-12 04:30:47 +01:00
Marta Marczykowska-Górecka
b1dc2458f6
Code review changes
...
As requested by @marmarek
2018-01-10 02:18:51 +01:00
Marta Marczykowska-Górecka
f86139d0d2
Renamed 'VM' to 'qube' in GUI
...
For consistency with new terminology.
2018-01-08 20:09:56 +01:00
Marta Marczykowska-Górecka
45496f73de
Added warning that the VM is currently running
...
Added warning that the VM is currently running. User still must shut it manually (by design).
2018-01-08 20:05:25 +01:00
Marta Marczykowska-Górecka
839696f6f9
Fixed missing import
...
Fixed missing import in boot-from-cdrom tool.
fixes QubesOS/qubes-issues#3421
2018-01-08 20:00:55 +01:00
Marta Marczykowska-Górecka
1cee3a5fe3
Fixed 'About' window
...
Surprisingly, it has not been touched since 3.2. It should work now.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
e19793ea7a
Minor display fix
...
Changed "size on disk" widget to display only two decimal places.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
899ca6d394
Pylint corrections
...
Removed errors discovered by pylint, or told it to be quiet when needed.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
41b8e6a4fb
Replaced 'VM' with 'Qube'
...
Renamed 'VM' to 'Qube' in the user interface for Qube Manager.
2018-01-08 04:22:54 +01:00
Marta Marczykowska-Górecka
8b5e2a8d66
Qube Manager in working order
...
Everything that should work works. Further improvements that would be nice:
- replace untidy multitude of QtGui Items with one generic type
- restore Qubes Network functionality
- add Boot From Device action (and easy way to install windows tool from there)
fixes QubesOS/qubes-issues#2966
QubesOS/qubes-issues#2132
2018-01-08 04:22:35 +01:00
Marta Marczykowska-Górecka
d57e58ae4d
Further work on qubes manager
2018-01-06 23:05:33 +01:00
Marta Marczykowska-Górecka
443f48c648
Recreation of the old qubes manager in a leaner, cut-down form. First
...
commit, WIP.
2018-01-06 23:03:19 +01:00
Marta Marczykowska-Górecka
bb8abff988
Suggested changes
...
included changes as suggested by @marmarek.
2018-01-06 02:21:07 +01:00
Marta Marczykowska-Górecka
df31207028
Final tiny fix of unused import
...
Threw out unused import of shutil.
2017-12-11 02:41:50 +01:00
Marta Marczykowska-Górecka
67a32b5748
Added 'compression' checkbox to backup GUI
...
Added 'compress the backup' checkbox to the backup GUI.
fixes QubesOS/qubes-issues#943
2017-12-11 02:37:50 +01:00
Marta Marczykowska-Górecka
7fd0c58303
Restored 'cancel' functionality
...
Now user can actually cancel a backup/restore.
2017-12-11 02:28:15 +01:00
Marta Marczykowska-Górecka
14ebf9dc6d
Fixed opening file dialog at the end
...
Now, when "open file dialog to unmount" option is enabled, a fie dialog
actually opens.
2017-12-11 02:07:10 +01:00
Marta Marczykowska-Górecka
a4a58cc527
Fixed progress bars
...
Partial fix - the progress bars now move, although they do not really
indicate progress (just dance back and forth). Future fix would include
making a tray icon to signal backup progress instead.
2017-12-11 01:32:26 +01:00
Marta Marczykowska-Górecka
78b4747e81
Second pylint pass
...
Fixed errors pointed out by pylint on server.
2017-12-11 01:15:07 +01:00
Marta Marczykowska-Górecka
a1c6e72569
First pylint pass
...
Fixed errors pointed out by pylint.
2017-12-11 00:56:27 +01:00
Marta Marczykowska-Górecka
4e2835531e
Usability fixes
...
Added label to inform the user only running VMs are listed in backup
GUI; made "ignore missing" label clearer.
2017-12-11 00:13:15 +01:00
Marta Marczykowska-Górecka
7848b6b2c3
Fixed inability to select which VMs to restore
...
Fixed bug that caused all VMs to be restored, regardless of what the
user selected.
2017-12-10 23:56:22 +01:00
Marta Marczykowska-Górecka
7bcde2158e
Added optional saving of default backup profile
...
Added checkbox for saving default backup profile. Removed useless "should I encrypt" checkbox (yes, you have to encrypt).
2017-12-10 23:19:16 +01:00
Marta Marczykowska-Górecka
9d73ceb99d
Fixed imports
...
Fixed import * and unused imports.
2017-12-10 22:11:07 +01:00
Marta Marczykowska-Górecka
7a4e4b35d5
Initial backup-and-restore GUI restoration
...
Initial restoration: basic backup-and-restore works, but
- progress bar in backup does not work
- selecting only some VMs to restore does not work
- various miscellaneous enhancements are not yet in place
2017-12-10 21:14:14 +01:00
Marek Marczykowski-Górecki
c403fc1e8f
Merge branch 'firewall_warnings'
...
* firewall_warnings:
Sort items in settingsdlg.ui / firewall tab
Enabled Firewall config without a netvm
2017-11-21 02:42:27 +01:00
Marta Marczykowska-Górecka
5b19c825e3
Enabled Firewall config without a netvm
...
Enabled Firewall tab even when there's no working netvm or the netvm
doesn't support qubes-firewall. An appropriate warning label and message
are shown in both cases.
fixes QubesOS/qubes-issues#3290
2017-11-20 14:20:01 +01:00
Marta Marczykowska-Górecka
eeac042662
Fixed bug with firewall GUI settings
...
Fixed bug that led to correct firewall configuration not being
recognized by GUI VM Settings.
fixes QubesOS/qubes-issues#3289
2017-11-17 19:12:06 +01:00
Marta Marczykowska-Górecka
5f1e4803fe
Applied corrections from @marmarek
2017-11-17 17:42:19 +01:00
Marta Marczykowska-Górecka
135060dfe7
Final corrections
...
Errors that my local pylint ignored and travis' pylint didn't.
2017-11-14 15:44:43 +01:00
Marta Marczykowska-Górecka
8cfc93c70c
Misc errors part 2
...
Renamed variable from 'input' to 'input_string' and moved imports to a
better place (that is, at the beginning of the module and not inside of
a function).
2017-11-09 17:57:21 +01:00
Marta Marczykowska-Górecka
8b296fab0d
Disable too-many-attributes warning
...
It's the settings window, it has a lot of attributes.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
95599dff9f
A bunch of misc errors
...
Fixed a bunch of small errors: bad indents, superfluous parentheses,
missing whitespace, superfluous statement.
2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
e543144aec
Too-few-public-methods warning
...
Checked, are sensible, disabled pylint warnings.
2017-11-09 17:41:10 +01:00
