Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,107 Commits 1 Branch 0 Tags 4.4 MiB
a4c63cc939
Commit Graph

788 Commits

Author SHA1 Message Date
donoban
2a437bcfc4
Fix pylint warnings 2018-06-11 01:56:10 +02:00
donoban
b8cb0f625b
Fix very unlikely case when user right clicks the VM in the exact moment he 
deletes it.
 2018-05-31 00:47:38 +02:00
donoban
cb5bc16948
Don't close the settings window if something failed when renaming 
e.g. the VM name already exists
 2018-05-31 00:39:34 +02:00
donoban
4d103562bd
Revert "Since __lt__ methods are safe, is not needed to stop and reenable sorting." 
This reverts commit ac92bb5fdf.
 2018-05-31 00:27:37 +02:00
donoban
47e83f2039
Added standalone VM's to check_updates() 
Also added an initial call when creating the timer, most users will look
for updates inmediately after start the manager
 2018-05-31 00:11:30 +02:00
donoban
ac92bb5fdf
Since __lt__ methods are safe, is not needed to stop and reenable sorting. 
It causes a short freeze of the main window when reenabling, so better
removing it.
 2018-05-31 00:09:34 +02:00
donoban
ae23443608
Added try/except for all __lt__() methods since some VM could be deleted 
before the signal is received and handled.

It fixes renaming a VM and deleting two domains at same time.
 2018-05-31 00:04:46 +02:00
Marek Marczykowski-Górecki
85dc0f9083
Merge remote-tracking branch 'qubesos/pr/94' 
* qubesos/pr/94:
  Fix for bug in VM Settings
 2018-05-22 03:51:31 +02:00
Marek Marczykowski-Górecki
24a5850507
Merge remote-tracking branch 'qubesos/pr/93' 
* qubesos/pr/93:
  Tiny fix to make pylint stop complaining
  Fixes unwanted behavior in VM settings
 2018-05-22 03:50:16 +02:00
Marek Marczykowski-Górecki
5b752fc55b
Merge remote-tracking branch 'qubesos/pr/91' 
* qubesos/pr/91: (27 commits)
  Fix long line warning
  Pretty confusion with regex trying to make  travis happy
  Added exceptions for domain add and remove
  Fix pylint and travis errors
  Fix misspelling on Updates Timer() and better timeout
  Added missing updates() method for some widget
  Fix missing template updates-available
  Added startup progress dialog
  More elegant fix for settings size
  Removed debug print
  Outdated state cleanup
  Revert "Removed progress wait when updating template"
  This tries to fix some rare case when it stops receieving dbus events
  Added Timer for template updates
  Refresh table selection when pause/resume
  Added calls to table_selection_changed()
  VmRowInTable dbus events moved to VmManagerWindow
  Set settings dialog to minimun size, it gets adjusted properly to good view
  - Removed unnedeed calls to vms_in_table[vm.qid].update()
  - Removed update_single_row() and add direct calls to update()  (Some of them could be deleted since dbus events will handle them)
  ...
 2018-05-22 03:30:21 +02:00
donoban
045c3bf98e
Fix long line warning 2018-05-20 22:14:31 +02:00
donoban
fe6a477074
Pretty confusion with regex trying to make travis happy 2018-05-20 22:00:34 +02:00
donoban
b5808296bf
Added exceptions for domain add and remove 2018-05-20 21:50:40 +02:00
donoban
8327e32e1f
Fix pylint and travis errors 2018-05-20 21:30:50 +02:00
Marta Marczykowska-Górecka
d3bd164e2f
Tiny fix to make pylint stop complaining 2018-05-17 19:58:44 +02:00
Marta Marczykowska-Górecka
455fea7d37
Fix for bug in VM Settings 
Adding a nonexisting service will no longer add "any" service.
 2018-05-17 19:56:28 +02:00
Marta Marczykowska-Górecka
744ddfcc80
Fixes unwanted behavior in VM settings 
Whenever Enter was pressed, the Settings window
closed and applied changes, which was very unintuitive
especially in case of Services tab.

references QubesOS/qubes-issues#3891
 2018-05-17 19:41:20 +02:00
donoban
edbc4c4469
Fix misspelling on Updates Timer() and better timeout 
This func is pretty cheap, less than 0.1ms adding two calls to print(time)
so I think 30s is a reasonable timeout and better for user experience
 2018-05-11 10:27:19 +02:00
Peter Gerber
031ad02ff6
Settings window: do not crash when there is no firewall rule 
When all firewall rules are removed, qubes-vm-settings crashed
trying to check if the last rule accepts or drops all packages.
It is now verifies that there is a last rule.

Also, it is now properly verified that the last rule accept
or drops all packages.

Associated stack trace:

----
line: last_rule = reversed_rules.pop(0)
func: get_firewall_conf
line no.: 227
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: conf = self.get_firewall_conf(vm)
func: set_vm
line no.: 308
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: model.set_vm(vm)
func: __init__
line no.: 111
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: settings_window = VMSettingsWindow(vm, qapp, args.tab)
func: main
line no.: 1133
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: load_entry_point('qubesmanager==4.0.17', 'console_scripts', 'qubes-vm-settings')()
func: <module>
line no.: 9
file: /usr/bin/qubes-vm-settings
 2018-05-11 01:24:22 +00:00
donoban
c43a47019e
Added missing updates() method for some widget 
internal, ip, include_in_backups and last_backup
 2018-05-10 17:59:07 +02:00
donoban
a77cc5172d
Fix missing template updates-available 2018-05-10 10:04:17 +02:00
donoban
78ba3057eb
Added startup progress dialog 2018-05-10 09:49:22 +02:00
donoban
1dcfc6e634
Removed debug print 2018-05-09 19:42:45 +02:00
donoban
224c8708fc
Outdated state cleanup 
Fixes problems showing 'outdated' instead 'to-be-outdated' when template is running

Fixes the removal of the icon calling setVisible(False) before removeWidget()
 2018-05-09 19:39:41 +02:00
donoban
e2fccf592a
Revert "Removed progress wait when updating template" 
This reverts commit 9633f6e9c6.
 2018-05-09 15:50:39 +02:00
donoban
ce07b9dcb1
This tries to fix some rare case when it stops receieving dbus events 2018-05-09 14:37:46 +02:00
donoban
806915f834
Added Timer for template updates 
Since there is no template updates dbus events, we need to check it periodically
 2018-05-09 14:36:39 +02:00
donoban
bc07e37266
Refresh table selection when pause/resume 
Since them dont have dbus events we need to manually update the selection
 2018-05-09 12:05:07 +02:00
donoban
e2e66cbccb
Added calls to table_selection_changed() 
If row updated is the selected row we need to update start/pause/stop buttons
 2018-05-09 11:48:19 +02:00
donoban
027d106507
VmRowInTable dbus events moved to VmManagerWindow 
Since we need to do some updates affecting all vms or the Window itself, this is a better place for handling this.
 2018-05-09 11:31:44 +02:00
donoban
bfc54b779f
- Removed unnedeed calls to vms_in_table[vm.qid].update() 
- Fixed unpause case where it was not properly updated
 2018-05-07 22:50:13 +02:00
donoban
5e6c0539c2
- Removed update_single_row() and add direct calls to update() 
(Some of them could be deleted since dbus events will handle them)

- Removed update_table() and TODO refering dbus events
 2018-05-07 22:26:39 +02:00
donoban
5b846a73cc
Removed unneeded calls to table.update() 2018-05-07 22:21:17 +02:00
donoban
8753119327
Initial version with dbus 
- Added connections for PropertiesChanged for each VM in VmRowInTable
- DomainAdded/Removed handled in VmManager
 2018-05-07 21:10:15 +02:00
donoban
ddf2e73f20
- Remove some stuff on fill_table since its only called once on startup 
- Removed table.setEnabled/Disabled tweak since I dont see any improvement, maybe because
fill_table() is only called without the window shown

- Removed unneeded update_table() calls, dbus events will handle them
 2018-05-07 20:50:20 +02:00
donoban
be055d8b41
Revert order of fill_table() and show() and removed the timer 
This does not seem to have any problem and the manager window appears already filled which seems more user friendly
 2018-05-07 13:30:03 +02:00
donoban
07d36a9149
Added update() methods on some widgets for update them without recreating 
Fixed some problems with update/status notifications, probably need some additional tunning
 2018-05-07 13:17:43 +02:00
donoban
9633f6e9c6
Removed progress wait when updating template 2018-05-03 11:34:11 +02:00
Marta Marczykowska-Górecka
5cfa0bb9c0
Fix bug in Qube Manager 
Accidentaly, the fix significantly improves start time (at least on two
of my machines).

fixes QubesOS/qubes-issues#3760
 2018-03-30 01:15:23 +02:00
Marek Marczykowski-Górecki
f74783af7e
Merge remote-tracking branch 'qubesos/pr/84' 
* qubesos/pr/84:
  Tiny fix for Qube Manager params
 2018-03-28 18:02:16 +02:00
Marta Marczykowska-Górecka
674b80613d
Tiny fix for Qube Manager params 
Made Qube Manager params consistent with other manager
tools (first Qt, then Qubes).
 2018-03-28 17:43:57 +02:00
Marek Marczykowski-Górecki
d4324d4873
Merge remote-tracking branch 'qubesos/pr/83' 
* qubesos/pr/83:
  Fix for updates-available in qube-manager
 2018-03-28 17:36:20 +02:00
Marek Marczykowski-Górecki
91fbc43b5e
Merge remote-tracking branch 'qubesos/pr/82' 
* qubesos/pr/82:
  Check if VM needs killing before murdering it
 2018-03-28 16:42:55 +02:00
Marek Marczykowski-Górecki
68b6f2351c
Merge remote-tracking branch 'qubesos/pr/81' 
* qubesos/pr/81:
  Less horrible Qube Manager loading
 2018-03-28 16:42:15 +02:00
Marta Marczykowska-Górecka
70d139e7f3
Fix for updates-available in qube-manager 
After fixing another bug, update status for a VM was not
initialized correctly.

fixes QubesOS/qubes-issues#3745
 2018-03-26 18:21:46 +02:00
Marta Marczykowska-Górecka
20cabb5563
Check if VM needs killing before murdering it 
In some cases, when the user waited some time before force-killing a VM,
it could be already dead.

fixes QubesOS/qubes-issues#3730
 2018-03-25 12:29:05 +02:00
Marek Marczykowski-Górecki
2d6b6488ea
Merge remote-tracking branch 'qubesos/pr/79' 
* qubesos/pr/79:
  Fixed GUI Restore tool bug
 2018-03-20 01:26:44 +01:00
Marta Marczykowska-Górecka
3ca7520b0e
Less horrible Qube Manager loading 
The window should first display itself, and then get gradually filled with VMs
(more user friendly, less annoying than waiting for something, anything
to appear).
Also fixed a dumb bug with double refreshing and a useless variable.

fixes QubesOS/qubes-issues#3719
 2018-03-19 22:40:50 +01:00
Marta Marczykowska-Górecka
7117892f4b
Fixed GUI Restore tool bug 
GUI Restore tool was unable to open file selection dialog in dom0.

fixes QubesOS/qubes-issues#3701
 2018-03-15 00:18:43 +01:00
Marta Marczykowska-Górecka
7ed386985d
Added default_dispvm to Global Settings 
Added "default dispvm" to Global Settings.

references QubesOS/qubes-issues#3688
 2018-03-14 22:21:33 +01:00
Marek Marczykowski-Górecki
e1aca0a393
Merge remote-tracking branch 'qubesos/pr/77' 
* qubesos/pr/77:
  Don't catch AttributeError for is_outdated() call anymore
  Call is_outdated() on volume object, not name
 2018-03-14 21:36:29 +01:00
Marek Marczykowski-Górecki
feeedb5526
Merge remote-tracking branch 'qubesos/pr/76' 
* qubesos/pr/76:
  Fixed a bunch of useless asserts
 2018-03-14 21:33:57 +01:00
Marek Marczykowski-Górecki
b0ebb76bf3
Merge remote-tracking branch 'qubesos/pr/75' 2018-03-14 21:33:01 +01:00
Rusty Bird
24dcb4802e
Don't catch AttributeError for is_outdated() call anymore 2018-03-14 00:07:22 +00:00
Rusty Bird
774b3bb2c9
Call is_outdated() on volume object, not name 
Note that this is still a no-op, because admin.vm.volume.Info does not
transmit is_outdated, so the qubesadmin wrapper defaults it to False.
 2018-03-14 00:07:21 +00:00
Marta Marczykowska-Górecka
fcaca57fc6
Fixed a bunch of useless asserts 
Replaced them with a more flexible behavior or removed if they were
not actually necessary (and handled elsewhere).

fixes QubesOS/qubes-issues#3623
 2018-03-10 22:31:41 +01:00
Marta Marczykowska-Górecka
bce5c32c96
Added "Exit" option to Qube Manager 
fixes QubesOS/issues#3683
 2018-03-10 20:04:57 +01:00
Marta Marczykowska-Górecka
91538f1aaf
Apply changes in global settings only when actual changes occurred 
Fixed apply methods to check if there is an actual need to apply
changes.
 2018-03-02 14:30:56 +01:00
Marta Marczykowska-Górecka
43520331f2
Fix pylint's critique 2018-03-02 01:04:02 +01:00
Marta Marczykowska-Górecka
94c0a45f86
Fixed minor error in previous fix 2018-03-02 00:43:43 +01:00
Marta Marczykowska-Górecka
b08ce9524f
Replaced single check vm updates checkbox 
Now there is a checkbox for the default for new VMs, and two
buttons to either disable checking for updates in all VMs or enable it
in all VMs.
 2018-02-22 22:24:34 +01:00
Marta Marczykowska-Górecka
02117b1870
Restored check-dom0-updates functionality in Global Settings 
Currently it uses a workaround, manually creating a file in
/var/lib/qubes/updates; once the appropriate attribute will start working
it will be used instead.
 2018-02-22 22:22:45 +01:00
Marta Marczykowska-Górecka
0700275586
De-uglify kernel selection in Global Settings 
Replaced kernel selection with utils.prepare_kernel; also added option
to utils.prepare_choice to treat empty string as None (applicable to
kernels).
 2018-02-22 22:22:42 +01:00
Marta Marczykowska-Górecka
4882013a32
De-uglify default template in Global Settings 
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
 2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
84d7e8bf9c
Allow setting default NetVM to None in Global Settings 
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
 2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
29a56d9c88
Fixed error in setting Clockvm to None in Global Settings 
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
 2018-02-22 22:21:39 +01:00
Marta Marczykowska-Górecka
c1e9074cb9
Fixed error in setting Updatevm to None in Global Settings 
Replaced old, manual vm list with a nicer, less disgusting
utils.prepare_vm_choice approach.
 2018-02-22 22:21:39 +01:00
Marek Marczykowski-Górecki
fb4870a16b
Merge remote-tracking branch 'qubesos/pr/72' 
* qubesos/pr/72:
  Added 'Apply' button to VM Settings
 2018-02-22 18:15:23 +01:00
Marek Marczykowski-Górecki
fb8b19af81
Merge remote-tracking branch 'qubesos/pr/71' 
* qubesos/pr/71:
  Fixed bug 3594
 2018-02-22 18:14:28 +01:00
Marek Marczykowski-Górecki
a141e40e9c
Merge remote-tracking branch 'qubesos/pr/70' 
* qubesos/pr/70:
  Allow restarting auto_cleanup=False DispVMs
 2018-02-22 18:13:32 +01:00
Marta Marczykowska-Górecka
8218f5fde1
Added 'Apply' button to VM Settings 
Simple "Apply" button.

fixes QubesOS/qubes-issues#3321
 2018-02-20 20:32:00 +01:00
Marta Marczykowska-Górecka
dc0f8c0a9e
Fixed bug 3594 
Incorrect targetVM display - dom0 was not included, and the code
erroneously assumed that not only it is included, but also it's always
the first in the dropdown. No more assumptions.

fixes QubesOS/qubes-issues#3594
 2018-02-20 19:22:57 +01:00
Rusty Bird
07866cbfc4
Allow restarting auto_cleanup=False DispVMs 2018-02-20 08:25:22 +00:00
Marta Marczykowska-Górecka
e95be8a8ed
Is this bug finally dead 
Yet another attempt at stomp this zombie monstrosity.

fixes QubesOS/qubes-issues#3570
 2018-02-13 20:26:55 +01:00
Marek Marczykowski-Górecki
b3699d27d5
Merge remote-tracking branch 'qubesos/pr/67' 
* qubesos/pr/67:
  Boot from device window fix
 2018-02-13 05:06:06 +01:00
Marek Marczykowski-Górecki
09805396bb
Merge remote-tracking branch 'qubesos/pr/65' 
* qubesos/pr/65:
  Changes according to @marmarek's request
  Shutting down vm from qube manager bug
  Refreshing vm list in qube manager fixed
  Qube manager updates more sensibly
 2018-02-13 05:05:24 +01:00
Marta Marczykowska-Górecka
8640fa7ace
Boot from device window fix 
The window wasn't closing properly.
 2018-02-11 00:20:14 +01:00
Marta Marczykowska-Górecka
45959aef71
Changes according to @marmarek's request 2018-02-10 23:41:36 +01:00
Marek Marczykowski-Górecki
ec7c65de34
Merge remote-tracking branch 'qubesos/pr/64' 
* qubesos/pr/64:
  Bugfixed
  Fixed error in creating new VMs from GUI
 2018-02-10 23:41:10 +01:00
Marek Marczykowski-Górecki
83936ba93e
Merge remote-tracking branch 'qubesos/pr/66' 
* qubesos/pr/66:
  Fixed incorrect default dispvm settings
 2018-02-10 23:35:12 +01:00
Marta Marczykowska-Górecka
c1bb8ba2ad
Bugfixed 
According to @marmarek's request
 2018-02-10 23:34:59 +01:00
Marek Marczykowski-Górecki
712e95617a
Merge remote-tracking branch 'qubesos/pr/63' 
* qubesos/pr/63:
  Fixed bug with template selection
  Fixed errors with virt mode choice
 2018-02-10 23:28:39 +01:00
Marek Marczykowski-Górecki
1fe280538e
Merge remote-tracking branch 'qubesos/pr/61' 
* qubesos/pr/61:
  Once more to fix this pesky bug
 2018-02-10 23:24:17 +01:00
Marta Marczykowska-Górecka
8da0d35110
Fixed incorrect default dispvm settings 
Fixed error in DispVM selection in VM settings

fixes QubesOS/qubes-issues#3565
 2018-02-10 22:54:00 +01:00
Marta Marczykowska-Górecka
5af2709029
Shutting down vm from qube manager bug 
Hopefully, finally fixes issue #3501.

fixes QubesOS/qubes-issues#3501
 2018-02-09 22:08:07 +01:00
Marta Marczykowska-Górecka
1d995de095
Refreshing vm list in qube manager fixed 
If a new VM was created via button in vm settings, the refresh button will now correctly display it.
 2018-02-09 21:59:43 +01:00
Marta Marczykowska-Górecka
dac7a6f208
Qube manager updates more sensibly 
Many events now cause the Qube Manager to refresh better - just the appropriate row, for example.
 2018-02-09 21:36:30 +01:00
Marta Marczykowska-Górecka
dc9f764baa
Fixed error in creating new VMs from GUI 
Virt mode was forcibly set to HVM. Now, the virt mode is left as default,
unless a standalone VM with system installed from elsewhere is selected.

fixes QubesOS/qubes-issues#3515
 2018-02-06 15:47:00 +01:00
Marta Marczykowska-Górecka
0ec3c704dd
Fixed bug with template selection 
Template in VM settings was not displayed correctly. It should work now.
 2018-02-06 15:38:20 +01:00
Marta Marczykowska-Górecka
2be8f8bcea
Fixed errors with virt mode choice 
Current virtualization mode wasn't displayed correctly. It should work now.

fixes QubesOS/qubes-issues#3517
 2018-02-06 15:31:17 +01:00
Marta Marczykowska-Górecka
81e5a92e66
Once more to fix this pesky bug 
fixes QubesOS/qubes-issues#3501
 2018-01-30 17:11:28 +01:00
Marek Marczykowski-Górecki
b28bd6e797
Merge remote-tracking branch 'qubesos/pr/60' 
* qubesos/pr/60:
  Repaired manager icons
  Removed 'Seamless GUI' checkbox from VM settings
  Change default Qube Manager size
  Renamed 'VM' to 'qube' everywhere in manager
 2018-01-29 23:55:07 +01:00
Marta Marczykowska-Górecka
71090b9e72
Change default Qube Manager size 
So that it will fit all VMs from a default install.
 2018-01-28 20:38:40 +01:00
Marta Marczykowska-Górecka
3a60f9146a
Renamed 'VM' to 'qube' everywhere in manager 
At least I hope it's everywhere.
Note: AppVM and NetVM nomenclature have been kept as before.
 2018-01-28 20:26:29 +01:00
Marta Marczykowska-Górecka
cb1519b56c
Fixed error on VM shutdown in Qube Manager 
fixes QubesOS/qubes-issues#3501
 2018-01-28 18:23:18 +01:00
Marta Marczykowska-Górecka
4ec36de20d
Changes as requested by @marmarek 2018-01-26 23:17:02 +01:00
Marta Marczykowska-Górecka
46fe3725d1
Refresh Qube Manager list after closing VM settings 
Now the Qube Manager refreshes VM list after VM settings are launched
and closed.
 2018-01-23 20:44:59 +01:00
Marta Marczykowska-Górecka
cd8a243f5c
Fixes to resizing in Qube Manager 
Change column resize mode to interactive and stretch last column, so there's no useless space on the right. Also minor fix to sorting last_timestamp column, for more readability and also to fix a rare bug.
 2018-01-23 20:28:19 +01:00
Marek Marczykowski-Górecki
81413907bf
Merge remote-tracking branch 'qubesos/pr/55' 
* qubesos/pr/55:
  Fixed according to @marmarek request
  Fixed according to @marmarek request
  Added 'configure no strict reset for PCI devices' button
  Adding a button to list PCI devices and enable no-strict-reset
  Fixed some indents and whitespaces
  Fixed python2 in settings.py
 2018-01-19 03:01:57 +01:00
Marta Marczykowska-Górecka
b158aeccbd
Fixed according to @marmarek request 2018-01-19 02:50:04 +01:00