Commit Graph

1384 Commits

Author SHA1 Message Date
donoban
b5808296bf
Added exceptions for domain add and remove 2018-05-20 21:50:40 +02:00
donoban
8327e32e1f
Fix pylint and travis errors 2018-05-20 21:30:50 +02:00
Marta Marczykowska-Górecka
d3bd164e2f
Tiny fix to make pylint stop complaining 2018-05-17 19:58:44 +02:00
Marta Marczykowska-Górecka
455fea7d37
Fix for bug in VM Settings
Adding a nonexisting service will no longer add "any" service.
2018-05-17 19:56:28 +02:00
Marta Marczykowska-Górecka
744ddfcc80
Fixes unwanted behavior in VM settings
Whenever Enter was pressed, the Settings window
closed and applied changes, which was very unintuitive
especially in case of Services tab.

references QubesOS/qubes-issues#3891
2018-05-17 19:41:20 +02:00
donoban
edbc4c4469
Fix misspelling on Updates Timer() and better timeout
This func is pretty cheap, less than 0.1ms adding two calls to print(time)
so I think 30s is a reasonable timeout and better for user experience
2018-05-11 10:27:19 +02:00
Peter Gerber
031ad02ff6
Settings window: do not crash when there is no firewall rule
When all firewall rules are removed, qubes-vm-settings crashed
trying to check if the last rule accepts or drops all packages.
It is now verifies that there is a last rule.

Also, it is now properly verified that the last rule accept
or drops all packages.

Associated stack trace:

----
line: last_rule = reversed_rules.pop(0)
func: get_firewall_conf
line no.: 227
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: conf = self.get_firewall_conf(vm)
func: set_vm
line no.: 308
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: model.set_vm(vm)
func: __init__
line no.: 111
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: settings_window = VMSettingsWindow(vm, qapp, args.tab)
func: main
line no.: 1133
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: load_entry_point('qubesmanager==4.0.17', 'console_scripts', 'qubes-vm-settings')()
func: <module>
line no.: 9
file: /usr/bin/qubes-vm-settings
2018-05-11 01:24:22 +00:00
donoban
c43a47019e
Added missing updates() method for some widget
internal, ip, include_in_backups and last_backup
2018-05-10 17:59:07 +02:00
donoban
a77cc5172d
Fix missing template updates-available 2018-05-10 10:04:17 +02:00
donoban
78ba3057eb
Added startup progress dialog 2018-05-10 09:49:22 +02:00
donoban
d54ba5b8cf
More elegant fix for settings size
Is the exact minimum size it can get
2018-05-09 19:56:43 +02:00
donoban
1dcfc6e634
Removed debug print 2018-05-09 19:42:45 +02:00
donoban
224c8708fc
Outdated state cleanup
Fixes problems showing 'outdated' instead 'to-be-outdated' when template is running

Fixes the removal of the icon calling setVisible(False) before removeWidget()
2018-05-09 19:39:41 +02:00
donoban
e2fccf592a
Revert "Removed progress wait when updating template"
This reverts commit 9633f6e9c6.
2018-05-09 15:50:39 +02:00
donoban
ce07b9dcb1
This tries to fix some rare case when it stops receieving dbus events 2018-05-09 14:37:46 +02:00
donoban
806915f834
Added Timer for template updates
Since there is no template updates dbus events, we need to check it periodically
2018-05-09 14:36:39 +02:00
donoban
bc07e37266
Refresh table selection when pause/resume
Since them dont have dbus events we need to manually update the selection
2018-05-09 12:05:07 +02:00
donoban
e2e66cbccb
Added calls to table_selection_changed()
If row updated is the selected row we need to update start/pause/stop buttons
2018-05-09 11:48:19 +02:00
donoban
027d106507
VmRowInTable dbus events moved to VmManagerWindow
Since we need to do some updates affecting all vms or the Window itself, this is a better place for handling this.
2018-05-09 11:31:44 +02:00
donoban
5440384142
Set settings dialog to minimun size, it gets adjusted properly to good view
fix https://github.com/QubesOS/qubes-issues/issues/3825
2018-05-07 23:19:15 +02:00
donoban
bfc54b779f
- Removed unnedeed calls to vms_in_table[vm.qid].update()
- Fixed unpause case where it was not properly updated
2018-05-07 22:50:13 +02:00
donoban
5e6c0539c2
- Removed update_single_row() and add direct calls to update()
(Some of them could be deleted since dbus events will handle them)

- Removed update_table() and TODO refering dbus events
2018-05-07 22:26:39 +02:00
donoban
5b846a73cc
Removed unneeded calls to table.update() 2018-05-07 22:21:17 +02:00
donoban
3a5a314d05
Removed 'Refresh' button :) 2018-05-07 21:58:22 +02:00
donoban
8753119327
Initial version with dbus
- Added connections for PropertiesChanged for each VM in VmRowInTable
- DomainAdded/Removed handled in VmManager
2018-05-07 21:10:15 +02:00
donoban
ddf2e73f20
- Remove some stuff on fill_table since its only called once on startup
- Removed table.setEnabled/Disabled tweak since I dont see any improvement, maybe because
fill_table() is only called without the window shown

- Removed unneeded update_table() calls, dbus events will handle them
2018-05-07 20:50:20 +02:00
donoban
be055d8b41
Revert order of fill_table() and show() and removed the timer
This does not seem to have any problem and the manager window appears already filled which seems more user friendly
2018-05-07 13:30:03 +02:00
donoban
07d36a9149
Added update() methods on some widgets for update them without recreating
Fixed some problems with update/status notifications, probably need some additional tunning
2018-05-07 13:17:43 +02:00
donoban
9633f6e9c6
Removed progress wait when updating template 2018-05-03 11:34:11 +02:00
Marta Marczykowska-Górecka
3ec089f827
Added make clean to Makefile 2018-04-12 22:10:37 +02:00
Marta Marczykowska-Górecka
7f4d6e8f77
Improved descriptions in Global Settings window
Makes clear that check_updates_vm is just the default for new VMs and
replaces some more instances of VM with qube. (Note: the size change
is deliberate)

fixes QubesOS/qubes-issues#3732
2018-04-12 22:10:37 +02:00
Marek Marczykowski-Górecki
9f34e058d0
Merge remote-tracking branch 'qubesos/pr/86'
* qubesos/pr/86:
  spec.in: change to 'noarch' rpm package
  spec.in: add changelog placeholder
  Create .spec.in and Source0
2018-04-07 12:38:52 +02:00
Frédéric Pierret
d6c8f7b79f
spec.in: change to 'noarch' rpm package 2018-04-07 04:46:56 -04:00
Marek Marczykowski-Górecki
9aa8f6684f
Merge remote-tracking branch 'qubesos/pr/87'
* qubesos/pr/87:
  Removed useless action Attach Block Device from Qube Manager
2018-04-05 18:23:08 +02:00
Marta Marczykowska-Górecka
1969610150
Removed useless action Attach Block Device from Qube Manager
fixes QubesOS/qubes-issues#3722
2018-04-04 17:57:46 +02:00
Frédéric Pierret
48bcbf43c6
spec.in: add changelog placeholder 2018-04-04 10:09:30 -04:00
Frédéric Pierret
ac83f0a82f
Create .spec.in and Source0 2018-04-04 10:09:30 -04:00
Marta Marczykowska-Górecka
5cfa0bb9c0
Fix bug in Qube Manager
Accidentaly, the fix significantly improves start time (at least on two
of my machines).

fixes QubesOS/qubes-issues#3760
2018-03-30 01:15:23 +02:00
Marek Marczykowski-Górecki
efa3de0171
version 4.0.17 2018-03-28 18:03:56 +02:00
Marek Marczykowski-Górecki
f74783af7e
Merge remote-tracking branch 'qubesos/pr/84'
* qubesos/pr/84:
  Tiny fix for Qube Manager params
2018-03-28 18:02:16 +02:00
Marek Marczykowski-Górecki
fd766dd651
Merge remote-tracking branch 'qubesos/pr/80'
* qubesos/pr/80:
  changes as requested by @marmarek
  Minor textual update for Global Settings

While resolving conflict, reverted global settings window size to sane
value.
2018-03-28 18:00:45 +02:00
Marta Marczykowska-Górecka
a3b56b57fe
changes as requested by @marmarek 2018-03-28 17:46:31 +02:00
Marta Marczykowska-Górecka
674b80613d
Tiny fix for Qube Manager params
Made Qube Manager params consistent with other manager
tools (first Qt, then Qubes).
2018-03-28 17:43:57 +02:00
Marek Marczykowski-Górecki
d4324d4873
Merge remote-tracking branch 'qubesos/pr/83'
* qubesos/pr/83:
  Fix for updates-available in qube-manager
2018-03-28 17:36:20 +02:00
Marek Marczykowski-Górecki
91fbc43b5e
Merge remote-tracking branch 'qubesos/pr/82'
* qubesos/pr/82:
  Check if VM needs killing before murdering it
2018-03-28 16:42:55 +02:00
Marek Marczykowski-Górecki
68b6f2351c
Merge remote-tracking branch 'qubesos/pr/81'
* qubesos/pr/81:
  Less horrible Qube Manager loading
2018-03-28 16:42:15 +02:00
Marta Marczykowska-Górecka
70d139e7f3
Fix for updates-available in qube-manager
After fixing another bug, update status for a VM was not
initialized correctly.

fixes QubesOS/qubes-issues#3745
2018-03-26 18:21:46 +02:00
Marta Marczykowska-Górecka
20cabb5563
Check if VM needs killing before murdering it
In some cases, when the user waited some time before force-killing a VM,
it could be already dead.

fixes QubesOS/qubes-issues#3730
2018-03-25 12:29:05 +02:00
Marek Marczykowski-Górecki
2d6b6488ea
Merge remote-tracking branch 'qubesos/pr/79'
* qubesos/pr/79:
  Fixed GUI Restore tool bug
2018-03-20 01:26:44 +01:00
Marta Marczykowska-Górecka
3ca7520b0e
Less horrible Qube Manager loading
The window should first display itself, and then get gradually filled with VMs
(more user friendly, less annoying than waiting for something, anything
to appear).
Also fixed a dumb bug with double refreshing and a useless variable.

fixes QubesOS/qubes-issues#3719
2018-03-19 22:40:50 +01:00