Qubes/manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,204 Commits 1 Branch 0 Tags 8.6 MiB
e122669aef
Commit Graph

46 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
455fea7d37
Fix for bug in VM Settings 
Adding a nonexisting service will no longer add "any" service.
 2018-05-17 19:56:28 +02:00
Peter Gerber
031ad02ff6
Settings window: do not crash when there is no firewall rule 
When all firewall rules are removed, qubes-vm-settings crashed
trying to check if the last rule accepts or drops all packages.
It is now verifies that there is a last rule.

Also, it is now properly verified that the last rule accept
or drops all packages.

Associated stack trace:

----
line: last_rule = reversed_rules.pop(0)
func: get_firewall_conf
line no.: 227
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: conf = self.get_firewall_conf(vm)
func: set_vm
line no.: 308
file: /usr/lib/python3.5/site-packages/qubesmanager/firewall.py
----
line: model.set_vm(vm)
func: __init__
line no.: 111
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: settings_window = VMSettingsWindow(vm, qapp, args.tab)
func: main
line no.: 1133
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: load_entry_point('qubesmanager==4.0.17', 'console_scripts', 'qubes-vm-settings')()
func: <module>
line no.: 9
file: /usr/bin/qubes-vm-settings
 2018-05-11 01:24:22 +00:00
Marta Marczykowska-Górecka
eeac042662
Fixed bug with firewall GUI settings 
Fixed bug that led to correct firewall configuration not being
recognized by GUI VM Settings.

fixes QubesOS/qubes-issues#3289
 2017-11-17 19:12:06 +01:00
Marta Marczykowska-Górecka
5f1e4803fe
Applied corrections from @marmarek 2017-11-17 17:42:19 +01:00
Marta Marczykowska-Górecka
135060dfe7
Final corrections 
Errors that my local pylint ignored and travis' pylint didn't.
 2017-11-14 15:44:43 +01:00
Marta Marczykowska-Górecka
8cfc93c70c
Misc errors part 2 
Renamed variable from 'input' to 'input_string' and moved imports to a
better place (that is, at the beginning of the module and not inside of
a function).
 2017-11-09 17:57:21 +01:00
Marta Marczykowska-Górecka
95599dff9f
A bunch of misc errors 
Fixed a bunch of small errors: bad indents, superfluous parentheses,
missing whitespace, superfluous statement.
 2017-11-09 17:41:10 +01:00
Marta Marczykowska-Górecka
3d841cf14f
Checked too-many-returns error 
Checked both places with a 'too-many-return-statements' warning, both
were sensible, marked them as such.
 2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
6670f59853
Fixed regex strings 
Fixed regex strings that were not marked as raw.
 2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
0115c931d2
Variables defined outside init 
Defined them inside init and added description.
 2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
b7060e76b2
Fixed no-self-use error 
Turned methods into static methods when possible.
 2017-11-09 17:41:09 +01:00
Marta Marczykowska-Górecka
695303f16a
Fixed unused variables 
When possible removed, otherwise renamed to start with an underscore.
 2017-11-09 16:26:05 +01:00
Marta Marczykowska-Górecka
3f7f5a9da3
Firewall GUI fix 
Fixed error when service would be left empty, but the settings window
would nonetheless emit an error.
 2017-11-09 16:19:14 +01:00
Marta Marczykowska-Górecka
b9e4f99fec
Fixed unusued arguments 
Places where the variable is used in a overriding method were marked for
pylint to ignore them.
 2017-11-09 16:19:12 +01:00
Marta Marczykowska-Górecka
6e5d611f70
Fixed invalid names 
Fixed camel case, too long and too short variable and function names.
 2017-11-09 16:18:16 +01:00
Marta Marczykowska-Górecka
2b24abb8c8
Fixed trailing and bad whitespaces 
Fixed trailing and bad whitespaces
 2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
91572eea2d
Fixed too-long lines 
Fixed lines over 80 characters.
 2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
c252e9ec3c
Fixed wildcard imports 
Fixed wildcard imports and any further problems resulting from them.
 2017-11-06 23:55:58 +01:00
Marta Marczykowska-Górecka
eaccc323fb
Fixed unused imports 
Fixed all unused imports errors.
 2017-11-06 23:20:09 +01:00
Marta Marczykowska-Górecka
3009610a62
Fixed GPL license 
Replaced old, address-having, too-many-characters-in-a-line version with
the new one with URL.
 2017-11-06 21:06:30 +01:00
Marta Marczykowska-Górecka
dd990c04ac
Firewall settings 
Modified VM Settings - Firewall tab to be easier to use and saner.
 2017-10-13 22:41:10 +02:00
Marek Marczykowski-Górecki
402f1db80d
firewall: check for 'qubes-firewall' feature instead of being ProxyVM 
This enable better detection whether firewall settings will really be
respected.

Fixes QubesOS/qubes-issues#2003
 2017-07-16 10:50:07 +02:00
Wojtek Porczyk
37d501c42b rewrite firewall 2017-07-12 15:05:05 +02:00
Wojtek Porczyk
2c3df7bd67 spring cleaning part 5: more python3 fixes 2017-07-12 14:54:14 +02:00
Wojtek Porczyk
f5d83d31dd spring cleaning part 4 
remove old imports
 2017-07-12 14:54:13 +02:00
Marek Marczykowski-Górecki
7c602bf7d2
i18n: wrap strings with self.tr 
Allow translations to handle strings defined in code.

Fixes QubesOS/qubes-issues#2599
 2017-01-22 13:22:26 +01:00
Marek Marczykowski-Górecki
49c209d077
firewall: Warn earlier and improve message on empty service name for TCP/UDP 
Fixes QubesOS/qubes-issues#2093
 2016-06-21 02:05:21 +02:00
Noah Vesely
7395797182 Added SMTPS and ODMR 
Added SMTPS and On-Demand Mail Relay (used by Fetchmail, xODMR). Both of these are in the Fedora 20 /etc/services.
 2015-04-25 13:26:42 -04:00
Marek Marczykowski-Górecki
10ec6014b0 Update to follow core-admin change: rename write_iptables_xenstore_entry 2015-03-28 22:59:13 +01:00
Marek Marczykowski-Górecki
41bf7b448e firewall: add an option to temporary allow full network access (#760) 
Add rule "*" with expire time set.
 2014-03-28 06:41:35 +01:00
Marek Marczykowski-Górecki
3b3846eeb5 firewall: simplify rules handling code 
Use directly rule provided by qubes core, not intermediate class
QubesFirewallRuleItem. This also will improve compatibility - if no
firewall changes made (but still "OK" clicked instead of "Cancel")
really the same settings are saved, even if rules contains some not
supported by Qubes Manager attributes.
 2014-03-28 05:15:52 +01:00
Marek Marczykowski
7ad8330946 fix sorting firewall rules (#652) 2012-08-07 15:03:04 +02:00
Marek Marczykowski
2fb2f6478e fix firewall apply (#600) 
Inhibit infinite loop.
 2012-06-19 00:15:46 +02:00
Marek Marczykowski
bb3b8be82e Reload firewall setting only there where needed 2012-06-05 20:54:50 +02:00
Marek Marczykowski
da09aa79fc Add "Allow connections to Updates Proxy" firewall setting (#582) 2012-06-05 20:29:57 +02:00
Agnieszka Kostrzewa
27226171aa Apply settings only if something was changed. 2012-03-12 15:54:16 +01:00
Agnieszka Kostrzewa
b32be23d39 Firewall tab accepts protocols (ticket #447). 2012-03-04 17:36:25 +01:00
Agnieszka Kostrzewa
82001fe51f Extended firewall tab gui - not implemented. 2012-02-29 10:42:57 +01:00
Agnieszka Kostrzewa
7b5f383f13 Firewall rules window moved to settings tab. 2012-02-10 00:30:45 +01:00
Tomasz Sterna
2cc61172f3 Firewall rules editor improvements. #113 
- wildcard hostname "*" matching all hosts (0.0.0.0/0)
- wildcard port "*" matching the whole host
- port ranges (11-222) support in UI
 2011-03-21 22:08:51 +01:00
Tomasz Sterna
c8781da11e Implemented implicit rule to allow ICMP traffic in firewall 2011-03-21 22:08:39 +01:00
Marek Marczykowski
7228a3968e fwvm -> proxyvm once again 2011-03-14 19:29:37 +01:00
Tomasz Sterna
94c9751d78 Enable OK buton by default on rule edit dialog. 2011-03-09 17:12:20 +01:00
Tomasz Sterna
c1501f2ec9 Implemented new, simplified firewall rules editor. 
- Select firewall default action to accept or deny
- Add host exceptions to above rules
- New "Add address" window validates inputs and allow only correct
- Use service names instead port numbers
- Working "Edit" button
 2011-03-03 22:42:10 +01:00
Tomasz Sterna
ee3cfbb95f Use firewal rules in Python data structure 2011-03-02 15:06:39 +01:00
Tomasz Sterna
f8aadd7998 Implemented Firewall Rules Editor 2011-02-21 18:15:35 +01:00