Marek Marczykowski-Górecki
bdf0951c52
Merge remote-tracking branch 'origin/pr/198'
...
* origin/pr/198:
Fixed new firewall rule window
2019-09-23 03:48:09 +02:00
Marek Marczykowski-Górecki
0dc73fd618
Merge remote-tracking branch 'origin/pr/196'
...
* origin/pr/196:
Added an Advanced tab to Create New Qube dialog
2019-09-23 03:48:07 +02:00
Marta Marczykowska-Górecka
d85940c5a5
Added an Advanced tab to Create New Qube dialog
...
Tab contains a warning, provides_network checkbox,
install_system_after_creation checkbox, storage pool settings
and initial RAM.
references QubesOS/qubes-issues#5127
fixes QubeSOS/qubes-issues#5198
2019-09-20 17:59:23 +02:00
Marta Marczykowska-Górecka
2e152b8dfb
Fixed new firewall rule window
...
Now, an error will not close the window, enabling
the user to correct any mistakes.
fixes QubesOS/qubes-issues#bugfix5234
2019-09-20 17:50:31 +02:00
Marek Marczykowski-Górecki
b0d5263d5e
Merge remote-tracking branch 'origin/pr/199'
...
* origin/pr/199:
Improved display of default disposable VM in Qube Manager
Qube Manager now reacts to changing some global properties
2019-09-20 02:10:15 +02:00
Marta Marczykowska-Górecka
2d644c371f
Improved display of default disposable VM in Qube Manager
...
Now 'default' value will be correctly shown as default (vm name).
2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
9aeacce9c5
Qube Manager now reacts to changing some global properties
...
Properties checked are: default_netvm and default_dispvm. Qube Manager
will now properly update displayed values.
fixes QubesOS/qubes-issues#5328
2019-09-19 01:45:32 +02:00
Marta Marczykowska-Górecka
df9576a0f1
Fixed UI error
...
Qube Manager columns did not resize correctly in Qt5.
fixes QubesOS/qubes-issues#5278
2019-09-06 16:31:27 +02:00
Marek Marczykowski-Górecki
c32d63df58
Merge remote-tracking branch 'origin/pr/181'
...
* origin/pr/181:
Add tooltip to application list in VM settings
2019-08-28 16:50:23 +02:00
Marek Marczykowski-Górecki
1edf363efe
Merge remote-tracking branch 'origin/pr/172'
...
* origin/pr/172:
Say which repository caused the error in warnings
Only make qrexec calls when necessary
Squash more PyLint warnings
Decode stderr in repo qrexec calls
Fix error handling
Fix `self` being undefined when showing warnings
Only apply repo preferences when "OK" is clicked
Don't use asserts for error handling
Check that repo management succeeded
Remove unnecessary assert
Squash some PyLint warnings
Add UI for managing Qubes update repositories
Fix typo
Fixes QubesOS/qubes-issues#4550
2019-08-28 16:42:01 +02:00
Marek Marczykowski-Górecki
1e3c0bfcd8
Merge remote-tracking branch 'origin/pr/194'
...
* origin/pr/194:
Fix arithmetic in init/max mem ratio correction
2019-08-28 15:52:22 +02:00
Marek Marczykowski-Górecki
6107a1fcbf
Merge remote-tracking branch 'origin/pr/192'
...
* origin/pr/192:
Added virt mode column to Qube Manager
2019-08-28 15:50:29 +02:00
Marek Marczykowski-Górecki
b4b3588bf1
Minor fix qt4 -> qt5
...
Pylint detected one more missing QtGui->QtWidgets change.
2019-08-28 15:48:29 +02:00
Marek Marczykowski-Górecki
990e4abbbf
Merge remote-tracking branch 'origin/pr/178'
...
* origin/pr/178:
Update Qt version used in qubesmanager to Qt5
2019-08-28 15:19:26 +02:00
Aras Ergus
bbe14f524d
Fix arithmetic in init/max mem ratio correction
...
Qubes Manager seems to try to guarantee that 10*init_mem is at
least max_mem by automatically adjusting init_mem to max_mem/10 if
inappropriate values are set. However, this may not guarantee that
10*init_mem >= max_mem due to rounding errors. This change fixes
these edge cases by basically rounding up the result of division
by 10.
2019-08-17 15:42:36 +02:00
Marek Marczykowski-Górecki
3c9d7d3da4
firewall: service name can contain digits too
2019-08-10 03:54:35 +02:00
Marta Marczykowska-Górecka
dedde71d7a
Fixed bug with port numbers and services in VM settings
...
Opening an existing FW rule resulted in an invalid port number.
2019-08-09 14:16:30 +02:00
Marta Marczykowska-Górecka
1cd95fceb2
Added virt mode column to Qube Manager
...
Just another column that shows the
contents of virt_mode property.
fixes QubesOS/qubes-issues#4702
2019-08-08 17:30:15 +02:00
Marek Marczykowski-Górecki
d5a4ddb7ef
Merge remote-tracking branch 'origin/pr/191'
...
* origin/pr/191:
Fixed parsing port ranges in VM settings
Better handling of port/service names for VM settings
2019-08-02 20:03:35 +02:00
Marta Marczykowska-Górecka
1d7d51eafd
Fixed parsing port ranges in VM settings
...
Now service names with dash ('-') in them will be parsed
correctly and not result in an error.
fixes QubesOS/qubes-issues#4766
2019-08-02 16:58:30 +02:00
Marta Marczykowska-Górecka
6cd02b47b3
Better handling of port/service names for VM settings
...
Now port will be displayed as port_number [(service name)]
, and not just service name. Also added a tooltip with explanation
of what can be put in the 'port/service' field, renamed
the field to 'Port/service' and added some examples of pure port
numbers to the drop down.
fixes QubesOS/qubes-issues#5211
2019-08-02 16:39:51 +02:00
Marta Marczykowska-Górecka
31e3f72ae0
Kernel sorting fix
...
Fixed bug with kernel versions ending with a letter,
hopefully now the sorting is even more robust and sensible.
fixes QubesOS/qubes-issues#5208
2019-07-31 23:00:00 +02:00
Marek Marczykowski-Górecki
1dadca8ed8
Merge remote-tracking branch 'origin/pr/189'
...
* origin/pr/189:
Better settings for a newly created VM
Changed checking for VM name in use
2019-07-31 17:29:00 +02:00
Marek Marczykowski-Górecki
1a147121f0
Merge remote-tracking branch 'origin/pr/188'
...
* origin/pr/188:
Fixed silent fail in Boot from File window
2019-07-31 17:28:10 +02:00
Marta Marczykowska-Górecka
4e9ed5e261
Better settings for a newly created VM
...
Now a standalone VM not cloned from a template
will not have a kernel and have HVM virt mode.
fixes QubesOS/qubes-issues#5203
2019-07-29 21:53:44 +02:00
Marta Marczykowska-Górecka
b19d9e1373
Changed checking for VM name in use
...
In near future the old way will stop working, so
this is a pre-emptive fix.
2019-07-29 21:52:40 +02:00
Marta Marczykowska-Górecka
349fb693be
Fixed silent fail in Boot from File window
...
Now, when selecting a file fails for some reason
(lack of installed file manager, VM crashed on start,
anything), the user will get an error message.
references QubesOS/qubes-issues#5202
2019-07-29 19:23:42 +02:00
xaki23
61cb9acf3b
make else/default branch of version-detection non-fatal since any new-and-coming debian variants at this point probably are 4371 fixed to begin with
2019-07-09 23:37:26 +02:00
AJ Jordan
7245603628
Say which repository caused the error in warnings
2019-07-03 01:48:55 -07:00
AJ Jordan
352c0d0386
Only make qrexec calls when necessary
...
This helps in situations where the qrexec calls are forbidden; it also
prevents settings from being unintentionally changed and gives a
noticeable performance boost when the "OK" button is clicked.
2019-07-03 01:46:39 -07:00
AJ Jordan
e0919beec1
Squash more PyLint warnings
...
This definitely worked before, and I haven't touched this code recently
so I have no idea why these errors are just now popping up... but
whatever.
2019-07-02 16:04:04 -07:00
AJ Jordan
6a5823b74a
Decode stderr in repo qrexec calls
...
Before this change, "foobar\n" on stderr would be rendered (in the
warning dialog) as "b'foobar\n'", which is ugly. Now it'll be rendered
just as "foobar", followed by an actual newline character.
2019-07-02 13:45:21 -07:00
AJ Jordan
4931bf9401
Fix error handling
...
Apparently Python exceptions don't take **kwargs, so we just pass a
dictionary as the second (regular) argument. While we're at it, we
pretty-print said dictionary when displaying error messages.
2019-07-02 13:37:29 -07:00
AJ Jordan
33ef478626
Fix self
being undefined when showing warnings
2019-07-02 13:07:06 -07:00
AJ Jordan
026a844a91
Only apply repo preferences when "OK" is clicked
2019-07-02 12:36:29 -07:00
AJ Jordan
f3305b8288
Don't use asserts for error handling
2019-07-02 12:36:22 -07:00
AJ Jordan
8f9989a61d
Check that repo management succeeded
2019-07-01 17:23:49 -07:00
AJ Jordan
047cfbc407
Remove unnecessary assert
...
First of all, the method that was being called has asserts of its own,
so it's guaranteed to either succeed or crash the program with
AssertionError. Second, asserts are optimized out by the interpreter
when -O is passed. Therefore, this code is buggy because it sometimes
wouldn't be run, but we need the side effects.
2019-07-01 17:23:48 -07:00
AJ Jordan
df48c749c4
Squash some PyLint warnings
2019-07-01 17:23:46 -07:00
AJ Jordan
fdd06d32a5
Add UI for managing Qubes update repositories
...
Depends on QubesOS/qubes-core-admin-linux#48
Fixes QubesOS/qubes-issues#4550
2019-07-01 17:23:40 -07:00
AJ Jordan
a8df324b2d
Fix typo
2019-07-01 17:23:31 -07:00
Marta Marczykowska-Górecka
d0b99ef438
Cleaned up QThreads usage in VM Settings
...
fixes QubesOS/qubes-issues#4949
2019-06-14 21:13:56 +02:00
Marta Marczykowska-Górecka
4567707207
Add tooltip to application list in VM settings
...
The 'Comment' field will now be displayed as a tooltip in VM settings.
Requires https://github.com/QubesOS/qubes-desktop-linux-common/pull/12
references QubesOS/qubes-issues#5076
2019-06-10 16:01:44 +02:00
Marek Marczykowski-Górecki
ccdddc6a7e
Merge remote-tracking branch 'origin/pr/183'
...
* origin/pr/183:
Sorted kernels in VM settings
2019-06-10 03:49:13 +02:00
Marek Marczykowski-Górecki
b2e6c1556a
Merge remote-tracking branch 'origin/pr/182'
...
* origin/pr/182:
Added 'provides network' checkbox to VM settings
2019-06-10 03:48:13 +02:00
Marta Marczykowska-Górecka
65d07eca0d
Sorted kernels in VM settings
...
Kernels are sorted with a rough algorithm, comparing groups of numbers
numerically, and names consisting of strings alphabetically.
fixes QubesOS/qubes-issues#5084
2019-06-10 00:37:32 +02:00
Marta Marczykowska-Górecka
1f9b462bd3
Added 'provides network' checkbox to VM settings
...
A simple checkbox in the 'Advanced' tab. Does not allow disabling
'provides_network' if the VM is in use as NetVM; instead, a tooltip
informs the user which VMs use it.
fixes QubesOS/qubes-issues#5079
2019-06-07 20:13:24 +02:00
Marek Marczykowski-Górecki
09178bc00c
Merge remote-tracking branch 'origin/pr/180'
...
* origin/pr/180:
More safeguards for a VM that started in a weird way
2019-06-06 04:15:28 +02:00
Marta Marczykowska-Górecka
8c1a9e5120
More safeguards for a VM that started in a weird way
...
If for any reason adding a VM failed, Qube Manager will attempt to add it on the next state event it receives.
references QubesOS/qubes-issues#5066
2019-06-03 21:21:48 +02:00
Marta Marczykowska-Górecka
e79724f9db
Update Qt version used in qubesmanager to Qt5
...
Fixed dependencies, places where obsolete functions stopped working,
code fragments that started throwing warnings and an .ui file that
stopped being readable after the update.
2019-05-30 21:33:49 +02:00
Marta Marczykowska-Górecka
7e17d23003
Added Virtual DNS display to VM settings
...
fixes QubesOS/qubes-issues#5050
2019-05-29 22:24:24 +02:00
Marek Marczykowski-Górecki
43cf50858f
Fix handling buster in dsa-4371-update script
...
Fixes QubesOS/qubes-issues#5057
2019-05-29 18:23:52 +02:00
Marek Marczykowski-Górecki
6550070135
Merge remote-tracking branch 'qubesos/pr/175'
...
* qubesos/pr/175:
More fixes to force tests to work
Tests for Create New VM
Tests for VM settings
Fixed spec
Tests for backup_utils file
Tests for Qubes Backup
Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176
Tests for qube manager
Tests for global settings
2019-05-24 12:18:26 +02:00
Marta Marczykowska-Górecka
5d3c870c1b
More fixes to force tests to work
...
Fixed yet another odd QT behavior when tests
were run all together.
2019-05-20 23:23:03 +02:00
Marta Marczykowska-Górecka
d92c782ec9
Tests for Create New VM
2019-05-12 20:50:21 +02:00
Marta Marczykowska-Górecka
d4965c5b27
Tests for VM settings
2019-05-12 20:50:20 +02:00
Marta Marczykowska-Górecka
526799022d
Fixed spec
2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9764479aff
Tests for backup_utils file
2019-05-12 19:47:13 +02:00
Marta Marczykowska-Górecka
9252dad222
Tests for Qubes Backup
2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
893764a50c
Test changes related to fixes in https://github.com/QubesOS/qubes-manager/pull/176
2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
702ef75d1c
Tests for qube manager
2019-05-12 19:47:12 +02:00
Marta Marczykowska-Górecka
4fb9672d66
Tests for global settings
2019-05-12 19:47:12 +02:00
Marek Marczykowski-Górecki
af555fa9b1
Merge remote-tracking branch 'origin/pr/176'
...
* origin/pr/176:
Fixed logs display in Qube Manager
Protected loading manager settings from malformed config files
Fixed bug with hiding last visible column
Added additional check for cloning a VM
Fixed unnecessary property set in Global Settings
Fixed bug in Global Settings
2019-05-07 00:09:01 +02:00
Marek Marczykowski-Górecki
e997b4708d
Merge remote-tracking branch 'origin/pr/173'
...
* origin/pr/173:
Changed wording in Create New Qube and fixed minor bug
Made terminology in Create New VM GUI clearer
2019-05-07 00:06:33 +02:00
Marta Marczykowska-Górecka
768bfac019
Changed wording in Create New Qube and fixed minor bug
...
references QubesOS/qubes-issues#4723
2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
2634b3b229
Made terminology in Create New VM GUI clearer
...
Changed the terms used in Create New VM Gui to the following:
-Qube based on a template (AppVM)
-Standalone qube
-Standalone qube copied from a template
references QubesOS/qubes-issues#4723
2019-05-06 17:39:14 +02:00
Marta Marczykowska-Górecka
cb70b9bd65
Fixed logs display in Qube Manager
...
Logs menu was not updated correctly on all occassions.
2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
f5586e770b
Protected loading manager settings from malformed config files
...
Malformed config files will no longer prevent Qube Manager from
starting.
2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
0bb92311ba
Fixed bug with hiding last visible column
...
Removed old buggy code, replaced it with disabling hiding the 'name'
column (because manager is useless without VM name).
2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
ddb70fe8ea
Added additional check for cloning a VM
...
An attempt to clone a VM to a name that is already in use will
fail more gracefully and with an explicit warning message.
2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
733f00ddf2
Fixed unnecessary property set in Global Settings
2019-05-03 14:41:01 +02:00
Marta Marczykowska-Górecka
b9316bcd62
Fixed bug in Global Settings
...
Incorrect handling of Check dom0 updates being set to false.
fixes QubesOS/qubes-issues#4988
2019-05-03 14:41:00 +02:00
xaki23
f063aa5eea
treat kali-* as a variant of buster/sid
2019-04-11 01:06:01 +02:00
Marek Marczykowski-Górecki
baeabc2e8c
Merge remote-tracking branch 'qubesos/pr/171'
...
* qubesos/pr/171:
Fixed error in VM settings
2019-04-05 22:10:24 +02:00
Marta Marczykowska-Górecka
6b6621abfc
Fixed error in VM settings
...
fixes QubesOS/qubes-issues#4951
2019-04-05 21:35:46 +02:00
Marek Marczykowski-Górecki
6585ab4f29
Merge remote-tracking branch 'origin/pr/166'
...
* origin/pr/166:
Refactored QThread classes for more clarity and less code duplication
Fixed inconsisted icon in Qube Manager messages
2019-04-05 00:53:32 +02:00
Marta Marczykowska-Górecka
6e10daa309
Refactored QThread classes for more clarity and less code duplication
2019-04-04 22:58:10 +02:00
Marek Marczykowski-Górecki
f4d0417e1a
Merge remote-tracking branch 'origin/pr/170'
...
* origin/pr/170:
Fix error on reverting Qube Manager to an older version
2019-04-04 01:28:35 +02:00
Marek Marczykowski-Górecki
0cdbda5df9
Merge remote-tracking branch 'origin/pr/168'
...
* origin/pr/168:
Fixed device handling in VM settings widget
2019-04-04 01:27:08 +02:00
Marek Marczykowski-Górecki
278a72d461
Merge remote-tracking branch 'origin/pr/167'
...
* origin/pr/167:
More documentation and added another column for default_dispvm to Qube Manager
Added DVM Template column to Qube Manager
Rewritten Qube Manager widgets
2019-04-04 01:26:03 +02:00
Marta Marczykowska-Górecka
d2ad60edd2
Fix error on reverting Qube Manager to an older version
...
In rare case (when the Qube Manager was reverted to an older version
that does not have a column on which it was last sorted) downgrading
Qube Manager could result in a crash on start.
2019-04-03 20:49:33 +02:00
Marta Marczykowska-Górecka
077bcb3a8e
Fixed device handling in VM settings widget
...
PCI devices are now handled as DeviceInfo objects, not (string,name) tuples;
furthermore, a device that no longer exists in the system can be
correctly removed via VM settings window (it is displayed as Unknown
device).
fixes QubesOS/qubes-issues#2789
2019-04-03 20:47:09 +02:00
Marta Marczykowska-Górecka
c2e7010b25
More documentation and added another column for default_dispvm to Qube Manager
...
Including also a minor visual fix - the headers in Qube Manager
will now be multi-line when it looks needed.
fixes QubesOS/qubes-issues#4912
2019-04-03 19:21:25 +02:00
Marek Marczykowski-Górecki
8318db9b4e
Merge remote-tracking branch 'origin/pr/169'
...
* origin/pr/169:
Fixed device list behavior for a running VM in VM settings
2019-04-03 16:43:37 +02:00
Marek Marczykowski-Górecki
1d65d692ad
Merge remote-tracking branch 'origin/pr/154'
...
* origin/pr/154:
Fix too long lines
Moved busy_cursor() inside save_changes()
Removed unneded calls to Override/Restore cursor
Removed duplicated call to save_changes()
Removed unneeded Cursor override/restore
Added busy_cursor()
Added BusyCursor for notify manager is working
Revert "Added progress bar to __save_changes__"
Revert "Increase progress wait time to 2s"
Increase progress wait time to 2s
Added progress bar to __save_changes__
Remove unneeded slot connections and reject overwrite
2019-04-03 16:19:10 +02:00
Marta Marczykowska-Górecka
6cf0e83b1d
Fixed device list behavior for a running VM in VM settings
...
PCI devices will now correctly be unmodifiable if the VM is running.
fixes QubesOS/qubes-issues#4933
2019-04-02 22:16:55 +02:00
donoban
b7228e8419
Fix too long lines
2019-04-01 11:48:11 +02:00
Marek Marczykowski-Górecki
57376456a7
Merge remote-tracking branch 'origin/pr/165'
...
* origin/pr/165:
Set the window title when cloning a qube
2019-03-31 23:00:25 +02:00
Marek Marczykowski-Górecki
1d68a70356
Merge remote-tracking branch 'origin/pr/164'
...
* origin/pr/164:
Fixed minor error in Qubes Backup
2019-03-31 23:00:07 +02:00
donoban
34adc75752
Moved busy_cursor() inside save_changes()
2019-03-31 20:04:04 +02:00
donoban
c85d6e4e8b
Removed unneded calls to Override/Restore cursor
2019-03-31 20:01:38 +02:00
donoban
16f2997222
Removed duplicated call to save_changes()
2019-03-31 19:59:55 +02:00
donoban
1fbf6c9a59
Removed unneeded Cursor override/restore
2019-03-31 19:58:52 +02:00
donoban
8e383e3022
Added busy_cursor()
...
fix https://github.com/QubesOS/qubes-issues/issues/4744
2019-03-31 19:56:01 +02:00
donoban
9750d990a7
Merge remote-tracking branch 'upstream/master'
2019-03-30 15:06:07 +01:00
Marta Marczykowska-Górecka
cf1dd0d355
Added DVM Template column to Qube Manager
...
It is labelled "Template for DispVMs" and behaves like every
other column.
fixes QubesOS/qubes-issues#4912
2019-03-29 19:04:45 +01:00
Marta Marczykowska-Górecka
2ce6e8b1cc
Rewritten Qube Manager widgets
...
Less duplicate code and more extendability - now most
widgets are based on a single class.
2019-03-29 18:33:51 +01:00
Marta Marczykowska-Górecka
fe810c5ad0
Fixed inconsisted icon in Qube Manager messages
...
Now success will not be accompanied by a 'warning'
icon.
fixes QubesOS/qubes-issues#4922
2019-03-29 17:01:15 +01:00
AJ Jordan
868632555b
Set the window title when cloning a qube
2019-03-27 21:37:27 -04:00
Marta Marczykowska-Górecka
8fbf3fd2a6
Fixed minor error in Qubes Backup
...
Possibly due to changes in how services work,
the run_service_for_stdio was returning path with trailing
whitespace.
fixes QubesOS/qubes-issues#4921
2019-03-27 18:31:26 +01:00
Marek Marczykowski-Górecki
26462a32ab
Merge remote-tracking branch 'origin/pr/163'
...
* origin/pr/163:
fix incorrect behavior after backup error
2019-03-23 03:25:20 +01:00
Marta Marczykowska-Górecka
00ccce4816
Fixed minor errors found when debugging feature settings
...
the check-updates default was being incorrectly set
2019-03-21 14:47:03 +01:00
Marta Marczykowska-Górecka
597a3e728f
fix incorrect behavior after backup error
...
the Backup Qubes tool failed to allow user to exit correctly
after backup errored out in any way.
fixes QubesOS/qubes-issues#4885
2019-03-20 23:34:19 +01:00
donoban
8816a764ee
Merge remote-tracking branch 'upstream/master'
2019-03-17 17:09:13 +01:00
Marta Marczykowska-Górecka
1c06d241f0
Fix bug with fixed bug in VM Settings
...
fixes QubesOS/qubes-issues#4866
2019-03-11 22:02:32 +01:00
Marta Marczykowska-Górecka
e556c8f848
Fix bug with VM Settings
...
Bug related to previous fixes to 'apply'; part of the code still
incorrectly assumed some attributes may not exist
fixes QubesOS/qubes-issues#4866
2019-03-09 16:45:22 +01:00
Marek Marczykowski-Górecki
f6c8103f46
Fix boot CD image path validation
...
re.match checks only beginning of the path. There should be
re.fullmatch.
Fixes QubesOS/qubes-issues#4860
2019-03-07 02:54:10 +01:00
donoban
6469dd8341
Merge remote-tracking branch 'upstream/master'
2019-03-06 21:59:56 +01:00
Marek Marczykowski-Górecki
7874aa73fe
Merge remote-tracking branch 'origin/pr/158'
...
* origin/pr/158:
Fixed error in displaying error on VM Rename
2019-02-26 23:12:35 +01:00
Marta Marczykowska-Górecka
26779a4826
Fixed error in displaying error on VM Rename
...
VM rename was incorrectly trying to display an error by itself and not
use QThreads embedded mechanism.
fixes QubesOS/qubes-issues#4843
fixes QubesOS/qubes-issues#4767
2019-02-26 21:10:22 +01:00
Marek Marczykowski-Górecki
94cefc9d09
Merge remote-tracking branch 'qubesos/pr/157'
...
* qubesos/pr/157:
Fixed error in detecting dvm-template having different NetVM
2019-02-26 19:50:21 +01:00
Marek Marczykowski-Górecki
74987f6554
Merge remote-tracking branch 'qubesos/pr/156'
...
* qubesos/pr/156:
Fixed incorrect behavior after 'Apply' in Settings
2019-02-26 19:49:04 +01:00
Marta Marczykowska-Górecka
b31a154e32
Fixed error in detecting dvm-template having different NetVM
...
when the currect VM is the same as the dvm_template, there should be no
warning
fixes QubesOS/qubes-issues#4844
2019-02-26 19:31:41 +01:00
Marta Marczykowska-Górecka
d23dafed28
Fixed incorrect behavior after 'Apply' in Settings
...
Changes in some fields (to be precise, drop-downs) were discarded
in VM Settings when changed after an 'Apply' and before an 'OK'.
fixes QubesOS/qubes-issues#4833
2019-02-26 18:02:36 +01:00
Marek Marczykowski-Górecki
9afa6faca0
Merge remote-tracking branch 'origin/pr/151'
...
* origin/pr/151:
Added "set as dvm template" to VM settings
2019-02-23 18:40:07 +01:00
Marta Marczykowska-Górecka
ef6288f1ff
Added "set as dvm template" to VM settings
...
Added an 'Advanced' settings checkbox that allows the user to set a given
VM as template fo dispvms. It sets both the template_for_dispvms property
and the appmenus-dispvm feature - instead of delving into particulars
of how and which should be set, the user can just turn off the
whole setting if they want to make some changes in the vm and then turn
it on again.
fixes QubesOS/qubes-issues#4004
2019-02-23 18:27:22 +01:00
Marta Marczykowska-Górecka
faae2d0026
Added warning when setting NetVM
...
When NetVM is set to something else than default_dispvm has set, a warning
icon appears.
2019-02-19 22:27:28 +01:00
donoban
17fdb3c263
Added BusyCursor for notify manager is working
...
https://github.com/QubesOS/qubes-issues/issues/4744
2019-02-19 21:58:33 +01:00
donoban
56cc6c79e5
Revert "Added progress bar to __save_changes__"
...
This reverts commit bb7b8c79ae
.
2019-02-19 21:46:38 +01:00
donoban
dda98610d5
Revert "Increase progress wait time to 2s"
...
This reverts commit 0e9f8d4c45
.
2019-02-19 21:46:17 +01:00
donoban
0e9f8d4c45
Increase progress wait time to 2s
2019-02-17 20:37:16 +01:00
donoban
bb7b8c79ae
Added progress bar to __save_changes__
2019-02-16 15:56:46 +01:00
donoban
a9a2022206
Remove unneeded slot connections and reject overwrite
2019-02-16 15:54:22 +01:00
Marek Marczykowski-Górecki
52188318b8
Enable seamless mode buttons for Windows template-based qubes too
...
Fixes QubesOS/qubes-issues#4813
2019-02-12 22:23:38 +01:00
Marek Marczykowski-Górecki
9b8f5a460e
Apply DSA-4371 fix before launching updates
...
Script by @HW42 slightly modified.
QubesOS/qubes-issues#4752
2019-01-23 06:16:16 +01:00
Marek Marczykowski-Górecki
59dd11e137
Merge remote-tracking branch 'origin/pr/148'
...
* origin/pr/148:
Fix error on warning in Settings on Rename VM
2019-01-21 23:01:19 +01:00
Marek Marczykowski-Górecki
5e9b33ebc1
Merge remote-tracking branch 'origin/pr/146'
...
* origin/pr/146:
global_settings: Use MiB, not M as the unit
2019-01-21 22:59:17 +01:00
Marta Marczykowska-Górecka
60944bb2fd
Fix error on warning in Settings on Rename VM
...
fixes QubesOS/qubes-issues#4745
2019-01-21 19:53:12 +01:00
Marek Marczykowski-Górecki
2745266bf2
Merge remote-tracking branch 'origin/pr/145'
...
* origin/pr/145:
Added info to Restore Backup widget about dom0 restore
More consistent 'include_in_backups' behavior
Fixed Backup tool's QT bug
2019-01-17 22:26:17 +01:00
M. Vefa Bicakci
7df475e0aa
global_settings: Use MiB, not M as the unit
...
Prior to this commit, clicking on the "OK" button in the global settings
window would cause the dom0 memory boost and minimum VM memory fields to
be saved incorrectly, due to the fact that the code calculates the
values to be saved using the "MiB" as the units (i.e., factors of
1024), whereas the code would save the corresponding string into the
qmemman configuration file with the "M" suffix (indicating factors of
1000 instead of 1024).
Due to this bug, the aforementioned fields' values would be scaled down
every time the user clicked on the "OK" button in the global settings
window. For example, if the user entered 400 and hit 'OK', opening the
global settings window again would show the value 381.
2019-01-16 21:17:52 -05:00
Marta Marczykowska-Górecka
3cf9ff3ee2
Qube Manager conservative updating
...
Only update the widget changed, if possible; look at the event
that caused the update and update whatever was actually changed not
the whole VM row.
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
a9c8d524c7
Added label update to Qube Manager
...
Manager will now properly display label changes.
fixes QubesOS/qubes-issues#3675
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
0347eb6b1a
Added info to Restore Backup widget about dom0 restore
...
Added a label that makes it a bit more clear where the dom0 restore
backup data went.
references QubesOS/qubes-issues#3975
2019-01-16 21:11:43 +01:00
Marta Marczykowska-Górecka
60f62ff7cf
More consistent 'include_in_backups' behavior
...
Instead of always selecting for backup all the VMs that were selected
during last saved backup, now the GUI tool will disregard last selected
VMs and instead use VM attribute 'include_in_backups'
fixes QubesOS/qubes-issues#4713
2019-01-16 20:43:08 +01:00
Marta Marczykowska-Górecka
f047a56906
Fixed Backup tool's QT bug
...
Exiting the program was handled incorrectly.
fixes QubesOS/qubes-issues#4677
2019-01-16 20:21:46 +01:00
Marek Marczykowski-Górecki
0410518d29
Merge remote-tracking branch 'origin/pr/144'
...
* origin/pr/144:
Fixed DispVM handling in Template Manager
2019-01-16 00:38:13 +01:00
Marek Marczykowski-Górecki
4c3de619fc
Merge remote-tracking branch 'origin/pr/142'
...
* origin/pr/142:
Opens services file as utf-8 even in edge cases
2019-01-16 00:33:11 +01:00
Marta Marczykowska-Górecka
b7cf59c134
Fixed DispVM handling in Template Manager
...
DispVMs are now correctly excluded from Template Manager.
fixes QubesOS/qubes-issues#4704
fixes QubesOS/qubes-issues#4703
2019-01-14 14:57:00 +01:00
Marta Marczykowska-Górecka
6b0fa9551e
Opens services file as utf-8 even in edge cases
...
In edge cases (usually when system locale is not installed) Gtk falls
back to 'C' (not C.utf-8 ...) locale. Fixed that to enforce utf-8 always.
fixes QubesOS/qubes-issues#4475
2018-12-28 17:41:53 +01:00
Marta Marczykowska-Górecka
470390d789
Added explanatory tooltip to root resize
...
If system storage cannot be resized (due to belonging to an AppVM), the
system storage max field is grayed out without explanation; now it
will have a tooltip.
fixes QubesOS/qubes-issues#4617
2018-12-28 17:13:39 +01:00
Marta Marczykowska-Górecka
9727a0938b
Changed handling of maxmem/memory balancing in VM Settings
...
According to changes in 4dc8631010
,
memory balancing is now handled not by a special service but by
magic value of 0 maxmem. Added handling thereof to VM Settings -
also, settings will store the last used maxmem value in
qubesmanager.maxmem_value feature.
fixes QubesOS/qubes-issues#4480
2018-12-18 16:40:51 +01:00
Marek Marczykowski-Górecki
e122669aef
Merge remote-tracking branch 'origin/pr/139'
...
* origin/pr/139:
Changed to not force default netvm in Create New VM
2018-12-09 18:42:12 +01:00
Marek Marczykowski-Górecki
25586d972f
Merge remote-tracking branch 'origin/pr/138'
...
* origin/pr/138:
Fixed behavior of Create Standalone VM based on template
2018-12-09 18:42:00 +01:00
Marta Marczykowska-Górecka
fa6db59ba3
Changed to not force default netvm in Create New VM
...
To avoid conflict with scripts that make whonix magic,
if the user selects default netvm, we do not set any netvm and
trust the create_vm method to properly set it as default appropriate
for the given template.
fixes QubesOS/qubes-issues#1954
2018-12-08 23:09:39 +01:00
Marta Marczykowska-Górecka
bca68b24ba
Fixed behavior of Create Standalone VM based on template
...
private volume is now ignored
fixes QubesOS/qubes-issues#4045
2018-12-08 22:24:48 +01:00
Marek Marczykowski-Górecki
7dfa33b633
Merge remote-tracking branch 'origin/pr/135'
...
* origin/pr/135:
Fixed bug in handling state changes
Improved template manager UI
Missing file added
Added links to template manager to qube manager
Initial template manager
2018-12-08 01:25:04 +01:00
Marta Marczykowska-Górecka
24adad8094
Fixed bug in handling state changes
2018-12-07 19:02:23 +01:00
Marta Marczykowska-Górecka
c0eb8b55ab
Improved template manager UI
...
changed it to be more intuitive and less annoying.
2018-12-04 01:01:03 +01:00
Marta Marczykowska-Górecka
21224a6cbd
Missing file added
...
I might have forgotten to include the .ui file.
2018-12-04 00:57:00 +01:00
Marta Marczykowska-Górecka
13c4c748f1
Added links to template manager to qube manager
...
Added a shortcut to template manager to qube manager main window and some minor pylint fixes.
2018-12-03 18:25:49 +01:00
Marta Marczykowska-Górecka
ce20377e39
Initial template manager
...
A working template manager; at the moment it only provides means
to easily change templates of multiple VMs at once, but it should also give tools to install new templates.
fixes QubeSOS/qubes-issues#4085
2018-12-03 18:25:49 +01:00
Marta Marczykowska-Górecka
f0357623e6
Refresh Apps in vm settings now refreshes the vm and template both
...
requires e26debfe97
fixes QubesOS/qubes-issues#4383
2018-11-30 21:47:15 +01:00
Marek Marczykowski-Górecki
334fefe559
Merge remote-tracking branch 'origin/pr/132'
...
* origin/pr/132: (48 commits)
Fixed unreachable code thanks to travis
Clear searchbox pressing esc without need of selecting it
Fix errors when some domain fails to start
wait thread to finish when aborting
Don't terminate backup thread when aborting
Fix iterating and removing over list
Use 'qube' instead 'Qube'
Qube -> qube
Catch possible KeyError when starting dispVM
Fix authorship and python version
Create backup_window on the stack
Removed sigchld_handler old code
Fix pylint
Do not terminate the thread
Fix error/success message on dialog
Fix opening settings/boot dialog after VM creation
Add pylint disable too-few-methods
Fix travis errors
Removed unused import
Workaround for backup dialog modeless behaviour
...
2018-11-28 01:13:48 +01:00
donoban
fd845a1219
Fixed unreachable code thanks to travis
2018-11-25 19:33:16 +01:00
donoban
b2bdae2c2d
Clear searchbox pressing esc without need of selecting it
2018-11-25 19:28:07 +01:00
donoban
4deaedd1e0
Fix errors when some domain fails to start
2018-11-25 19:15:56 +01:00
donoban
6fdf16278e
wait thread to finish when aborting
2018-11-25 18:53:31 +01:00
donoban
f477084bfe
Don't terminate backup thread when aborting
2018-11-25 18:49:02 +01:00
donoban
22a9823871
Fix iterating and removing over list
...
Return after removing and raise exception if removable item not found
2018-11-25 18:37:34 +01:00
donoban
0ce73df57d
Use 'qube' instead 'Qube'
2018-11-25 18:16:40 +01:00
Marek Marczykowski-Górecki
a760a64a85
Merge remote-tracking branch 'origin/pr/136'
...
* origin/pr/136:
Add missing space
2018-11-21 01:58:40 +01:00
AJ Jordan
5619ee82bd
Add missing space
2018-11-18 17:59:43 -05:00
donoban
9a2975616d
Qube -> qube
2018-11-18 20:25:41 +01:00
donoban
287fc441f3
Catch possible KeyError when starting dispVM
2018-11-18 20:23:26 +01:00
donoban
935a6ca6c7
Fix authorship and python version
2018-11-18 20:22:27 +01:00
donoban
a39f3a64d0
Create backup_window on the stack
...
Otherwise it can casue an error:
RuntimeError: wrapped C/C++ object of type QProgressBar has been deleted
at line 1277
of file /usr/lib/python3.5/site-packages/qubesmanager/qube_manager.py.
I don't know how to avoid it.
2018-11-18 20:14:57 +01:00
Marek Marczykowski-Górecki
5edb1fdc6a
Merge remote-tracking branch 'origin/pr/134'
...
* origin/pr/134:
Fix error in qube manager
2018-11-16 16:53:38 +01:00
Marek Marczykowski-Górecki
f93feb82ce
Merge remote-tracking branch 'origin/pr/133'
...
* origin/pr/133:
Added GUI for toggling of seamless mode for windows
2018-11-16 16:52:10 +01:00
donoban
cbc5d364bf
Removed sigchld_handler old code
2018-11-04 18:19:16 +01:00
Marta Marczykowska-Górecka
8098466a07
Fix error in qube manager
...
In some cases (when a VM quickly appears and disappears)
the events were handled in a wrong order.
fixes QubesOS/qubes-issues#4414
2018-10-29 23:00:59 +01:00
donoban
5c8f19b598
Fix pylint
2018-10-27 13:21:33 +02:00
donoban
c42203098f
Do not terminate the thread
...
self.back_restore.canceled will do the abort
2018-10-27 13:00:19 +02:00
donoban
988b7a6479
Fix error/success message on dialog
2018-10-27 12:58:58 +02:00
donoban
6045f451c6
Fix opening settings/boot dialog after VM creation
2018-10-25 09:45:12 +02:00
donoban
7f572b5c81
Add pylint disable too-few-methods
2018-10-24 11:27:47 +02:00
donoban
fd1e5d740a
Fix travis errors
2018-10-24 10:58:36 +02:00
donoban
042ff808b3
Removed unused import
2018-10-24 10:14:48 +02:00
donoban
971ec085ee
Workaround for backup dialog modeless behaviour
...
Since now it's modeless, user could have already it opened
but we have to destroy it and recreate when closed for vm list
being refreshed (at least for now)
2018-10-24 10:05:43 +02:00
donoban
531b9daad2
Signal rewrite to new style
...
old is not supported in pyqt5
2018-10-24 09:46:16 +02:00
donoban
461cb7ae8c
Don't close main about dialog when close some child dialog
2018-10-24 09:45:29 +02:00
donoban
23e9ae8d33
Remove loop since we have vm name
2018-10-24 00:03:17 +02:00
Marta Marczykowska-Górecka
65b50c0f3b
Added GUI for toggling of seamless mode for windows
...
Added two buttons to enable/disable seamless mode
for windows qubes.
references QubesOS/qubes-issues#3585
references QubesOS/qubes-issues#4342
2018-10-23 22:51:28 +02:00
donoban
e124d83edc
Removed processEvents() calls
2018-10-23 00:07:55 +02:00
donoban
9102d200bd
restart wizzard when wrong password or backup corrupted
...
fix: https://github.com/QubesOS/qubes-issues/issues/1589
2018-10-22 23:47:51 +02:00
donoban
0e951dc156
Deleted unused method show_error()
...
clear_threads() handles messages now
2018-10-22 20:03:20 +02:00
donoban
edb13aec17
Thread.error renamed to Thread.msg
...
Since it could be used for both error or sucess
messages, I think msg is a better name
2018-10-22 20:00:37 +02:00
donoban
60af90ec5f
Adding # pylint: disable=too-few-public-methods
2018-10-22 10:14:26 +02:00
donoban
4aea47c9f7
...
2018-10-21 22:52:52 +02:00
donoban
df15c4e3ae
Fix pylint warnings and errors
2018-10-21 22:38:41 +02:00
donoban
a7537a323a
Wops
...
I did not notice on my pylint because it complains about all imports
2018-10-21 00:16:23 +02:00
donoban
c46b38ab42
Travis3
2018-10-21 00:06:37 +02:00
donoban
f93908f5b7
Fix travis build2
2018-10-20 23:23:06 +02:00
donoban
831769d2dd
Fix travis build
2018-10-20 23:01:35 +02:00
donoban
38051ad243
Fixes in ProgressDialogs and settings window close
2018-10-20 22:09:39 +02:00
donoban
2347f75633
Clear SearchBox with ESC key
2018-10-20 21:54:25 +02:00
donoban
ad1bcc55b9
Deleted unneded method _clone_vm()
2018-10-20 21:25:13 +02:00
donoban
11cc8b7a67
Remove debug print
2018-10-20 19:20:39 +02:00
donoban
29ca4eb3a8
Migration from python threads and to QThread obj
...
Simple design and better performance, just start() thread and finished
call back will show any error or msg, stop progress dialog and do cleanup.
Full remove of QT process_events() calls.
2018-10-20 18:34:15 +02:00
donoban
35cdf5e1e5
Modeless backup window
...
Let the main window work while doing backups
2018-10-20 16:50:45 +02:00
donoban
759dc5412c
Pylint ident warnings
2018-10-20 16:49:50 +02:00