Commit Graph

987 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
3cf9ff3ee2
Qube Manager conservative updating
Only update the widget changed, if possible; look at the event
that caused the update and update whatever was actually changed not
the whole VM row.
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
a9c8d524c7
Added label update to Qube Manager
Manager will now properly display label changes.

fixes QubesOS/qubes-issues#3675
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
0347eb6b1a
Added info to Restore Backup widget about dom0 restore
Added a label that makes it a bit more clear where the dom0 restore
backup data went.

references QubesOS/qubes-issues#3975
2019-01-16 21:11:43 +01:00
Marta Marczykowska-Górecka
60f62ff7cf
More consistent 'include_in_backups' behavior
Instead of always selecting for backup all the VMs that were selected
during last saved backup, now the GUI tool will disregard last selected
VMs and instead use VM attribute 'include_in_backups'

fixes QubesOS/qubes-issues#4713
2019-01-16 20:43:08 +01:00
Marta Marczykowska-Górecka
f047a56906
Fixed Backup tool's QT bug
Exiting the program was handled incorrectly.

fixes QubesOS/qubes-issues#4677
2019-01-16 20:21:46 +01:00
Marek Marczykowski-Górecki
0410518d29
Merge remote-tracking branch 'origin/pr/144'
* origin/pr/144:
  Fixed DispVM handling in Template Manager
2019-01-16 00:38:13 +01:00
Marek Marczykowski-Górecki
4c3de619fc
Merge remote-tracking branch 'origin/pr/142'
* origin/pr/142:
  Opens services file as utf-8 even in edge cases
2019-01-16 00:33:11 +01:00
Marta Marczykowska-Górecka
b7cf59c134
Fixed DispVM handling in Template Manager
DispVMs are now correctly excluded from Template Manager.

fixes QubesOS/qubes-issues#4704
fixes QubesOS/qubes-issues#4703
2019-01-14 14:57:00 +01:00
Marta Marczykowska-Górecka
6b0fa9551e
Opens services file as utf-8 even in edge cases
In edge cases (usually when system locale is not installed) Gtk falls
back to 'C' (not C.utf-8 ...) locale. Fixed that to enforce utf-8 always.

fixes QubesOS/qubes-issues#4475
2018-12-28 17:41:53 +01:00
Marta Marczykowska-Górecka
470390d789
Added explanatory tooltip to root resize
If system storage cannot be resized (due to belonging to an AppVM), the
system storage max field is grayed out without explanation; now it
will have a tooltip.

fixes QubesOS/qubes-issues#4617
2018-12-28 17:13:39 +01:00
Marta Marczykowska-Górecka
9727a0938b
Changed handling of maxmem/memory balancing in VM Settings
According to changes in 4dc8631010 ,
memory balancing is now handled not by a special service but by
magic value of 0 maxmem. Added handling thereof to VM Settings -
also, settings will store the last used maxmem value in
qubesmanager.maxmem_value feature.

fixes QubesOS/qubes-issues#4480
2018-12-18 16:40:51 +01:00
Marek Marczykowski-Górecki
e122669aef
Merge remote-tracking branch 'origin/pr/139'
* origin/pr/139:
  Changed to not force default netvm in Create New VM
2018-12-09 18:42:12 +01:00
Marek Marczykowski-Górecki
25586d972f
Merge remote-tracking branch 'origin/pr/138'
* origin/pr/138:
  Fixed behavior of Create Standalone VM based on template
2018-12-09 18:42:00 +01:00
Marta Marczykowska-Górecka
fa6db59ba3
Changed to not force default netvm in Create New VM
To avoid conflict with scripts that make whonix magic,
if the user selects default netvm, we do not set any  netvm and
trust the create_vm method to properly set it as default appropriate
for the given template.

fixes QubesOS/qubes-issues#1954
2018-12-08 23:09:39 +01:00
Marta Marczykowska-Górecka
bca68b24ba
Fixed behavior of Create Standalone VM based on template
private volume is now ignored

fixes QubesOS/qubes-issues#4045
2018-12-08 22:24:48 +01:00
Marek Marczykowski-Górecki
7dfa33b633
Merge remote-tracking branch 'origin/pr/135'
* origin/pr/135:
  Fixed bug in handling state changes
  Improved template manager UI
  Missing file added
  Added links to template manager to qube manager
  Initial template manager
2018-12-08 01:25:04 +01:00
Marta Marczykowska-Górecka
24adad8094
Fixed bug in handling state changes 2018-12-07 19:02:23 +01:00
Marta Marczykowska-Górecka
c0eb8b55ab
Improved template manager UI
changed it to be more intuitive and less annoying.
2018-12-04 01:01:03 +01:00
Marta Marczykowska-Górecka
21224a6cbd
Missing file added
I might have forgotten to include the .ui file.
2018-12-04 00:57:00 +01:00
Marta Marczykowska-Górecka
13c4c748f1
Added links to template manager to qube manager
Added a shortcut to template manager to qube manager main window and some minor pylint fixes.
2018-12-03 18:25:49 +01:00
Marta Marczykowska-Górecka
ce20377e39
Initial template manager
A working template manager; at the moment it only provides means
to easily change templates of multiple VMs at once, but it should also give tools to install new templates.

fixes QubeSOS/qubes-issues#4085
2018-12-03 18:25:49 +01:00
Marta Marczykowska-Górecka
f0357623e6
Refresh Apps in vm settings now refreshes the vm and template both
requires e26debfe97

fixes QubesOS/qubes-issues#4383
2018-11-30 21:47:15 +01:00
Marek Marczykowski-Górecki
334fefe559
Merge remote-tracking branch 'origin/pr/132'
* origin/pr/132: (48 commits)
  Fixed unreachable code thanks to travis
  Clear searchbox pressing esc without need of selecting it
  Fix errors when some domain fails to start
  wait thread to finish when aborting
  Don't terminate backup thread when aborting
  Fix iterating and removing over list
  Use 'qube' instead 'Qube'
  Qube -> qube
  Catch possible KeyError when starting dispVM
  Fix authorship and python version
  Create backup_window on the stack
  Removed sigchld_handler old code
  Fix pylint
  Do not terminate the thread
  Fix error/success message on dialog
  Fix opening settings/boot dialog after VM creation
  Add pylint disable too-few-methods
  Fix travis errors
  Removed unused import
  Workaround for backup dialog modeless behaviour
  ...
2018-11-28 01:13:48 +01:00
donoban
fd845a1219
Fixed unreachable code thanks to travis 2018-11-25 19:33:16 +01:00
donoban
b2bdae2c2d
Clear searchbox pressing esc without need of selecting it 2018-11-25 19:28:07 +01:00
donoban
4deaedd1e0
Fix errors when some domain fails to start 2018-11-25 19:15:56 +01:00
donoban
6fdf16278e
wait thread to finish when aborting 2018-11-25 18:53:31 +01:00
donoban
f477084bfe
Don't terminate backup thread when aborting 2018-11-25 18:49:02 +01:00
donoban
22a9823871
Fix iterating and removing over list
Return after removing and raise exception if removable item not found
2018-11-25 18:37:34 +01:00
donoban
0ce73df57d
Use 'qube' instead 'Qube' 2018-11-25 18:16:40 +01:00
Marek Marczykowski-Górecki
a760a64a85
Merge remote-tracking branch 'origin/pr/136'
* origin/pr/136:
  Add missing space
2018-11-21 01:58:40 +01:00
AJ Jordan
5619ee82bd
Add missing space 2018-11-18 17:59:43 -05:00
donoban
9a2975616d
Qube -> qube 2018-11-18 20:25:41 +01:00
donoban
287fc441f3
Catch possible KeyError when starting dispVM 2018-11-18 20:23:26 +01:00
donoban
935a6ca6c7
Fix authorship and python version 2018-11-18 20:22:27 +01:00
donoban
a39f3a64d0
Create backup_window on the stack
Otherwise it can casue an error:
RuntimeError: wrapped C/C++ object of type QProgressBar has been deleted
at line 1277
of file /usr/lib/python3.5/site-packages/qubesmanager/qube_manager.py.

I don't know how to avoid it.
2018-11-18 20:14:57 +01:00
Marek Marczykowski-Górecki
5edb1fdc6a
Merge remote-tracking branch 'origin/pr/134'
* origin/pr/134:
  Fix error in qube manager
2018-11-16 16:53:38 +01:00
Marek Marczykowski-Górecki
f93feb82ce
Merge remote-tracking branch 'origin/pr/133'
* origin/pr/133:
  Added GUI for toggling of seamless mode for windows
2018-11-16 16:52:10 +01:00
donoban
cbc5d364bf
Removed sigchld_handler old code 2018-11-04 18:19:16 +01:00
Marta Marczykowska-Górecka
8098466a07
Fix error in qube manager
In some cases (when a VM quickly appears and disappears)
the events were handled in a wrong order.

fixes QubesOS/qubes-issues#4414
2018-10-29 23:00:59 +01:00
donoban
5c8f19b598
Fix pylint 2018-10-27 13:21:33 +02:00
donoban
c42203098f
Do not terminate the thread
self.back_restore.canceled will do the abort
2018-10-27 13:00:19 +02:00
donoban
988b7a6479
Fix error/success message on dialog 2018-10-27 12:58:58 +02:00
donoban
6045f451c6
Fix opening settings/boot dialog after VM creation 2018-10-25 09:45:12 +02:00
donoban
7f572b5c81
Add pylint disable too-few-methods 2018-10-24 11:27:47 +02:00
donoban
fd1e5d740a
Fix travis errors 2018-10-24 10:58:36 +02:00
donoban
042ff808b3
Removed unused import 2018-10-24 10:14:48 +02:00
donoban
971ec085ee
Workaround for backup dialog modeless behaviour
Since now it's modeless, user could have already it opened
but we have to destroy it and recreate when closed for vm list
being refreshed (at least for now)
2018-10-24 10:05:43 +02:00
donoban
531b9daad2
Signal rewrite to new style
old is not supported in pyqt5
2018-10-24 09:46:16 +02:00
donoban
461cb7ae8c
Don't close main about dialog when close some child dialog 2018-10-24 09:45:29 +02:00
donoban
23e9ae8d33
Remove loop since we have vm name 2018-10-24 00:03:17 +02:00
Marta Marczykowska-Górecka
65b50c0f3b
Added GUI for toggling of seamless mode for windows
Added two buttons to enable/disable seamless mode
for windows qubes.

references QubesOS/qubes-issues#3585
references QubesOS/qubes-issues#4342
2018-10-23 22:51:28 +02:00
donoban
e124d83edc
Removed processEvents() calls 2018-10-23 00:07:55 +02:00
donoban
9102d200bd
restart wizzard when wrong password or backup corrupted
fix: https://github.com/QubesOS/qubes-issues/issues/1589
2018-10-22 23:47:51 +02:00
donoban
0e951dc156
Deleted unused method show_error()
clear_threads() handles messages now
2018-10-22 20:03:20 +02:00
donoban
edb13aec17
Thread.error renamed to Thread.msg
Since it could be used for both error or sucess
messages, I think msg is a better name
2018-10-22 20:00:37 +02:00
donoban
60af90ec5f
Adding # pylint: disable=too-few-public-methods 2018-10-22 10:14:26 +02:00
donoban
4aea47c9f7
... 2018-10-21 22:52:52 +02:00
donoban
df15c4e3ae
Fix pylint warnings and errors 2018-10-21 22:38:41 +02:00
donoban
a7537a323a
Wops
I did not notice on my pylint because it complains about all imports
2018-10-21 00:16:23 +02:00
donoban
c46b38ab42
Travis3 2018-10-21 00:06:37 +02:00
donoban
f93908f5b7
Fix travis build2 2018-10-20 23:23:06 +02:00
donoban
831769d2dd
Fix travis build 2018-10-20 23:01:35 +02:00
donoban
38051ad243
Fixes in ProgressDialogs and settings window close 2018-10-20 22:09:39 +02:00
donoban
2347f75633
Clear SearchBox with ESC key 2018-10-20 21:54:25 +02:00
donoban
ad1bcc55b9
Deleted unneded method _clone_vm() 2018-10-20 21:25:13 +02:00
donoban
11cc8b7a67
Remove debug print 2018-10-20 19:20:39 +02:00
donoban
29ca4eb3a8
Migration from python threads and to QThread obj
Simple design and better performance, just start() thread and finished
call back will show any error or msg, stop progress dialog and do cleanup.

Full remove of QT process_events() calls.
2018-10-20 18:34:15 +02:00
donoban
35cdf5e1e5
Modeless backup window
Let the main window work while doing backups
2018-10-20 16:50:45 +02:00
donoban
759dc5412c
Pylint ident warnings 2018-10-20 16:49:50 +02:00
donoban
76b6de9d00
removed subprocess.check_call()
This way modal works better (in KDE the main window goes gray).
2018-10-20 16:43:15 +02:00
donoban
612cfc15d6
Loading Qube Manager progress using setValue()
This is the recommended QT way for updating the progress bar.

setMininumDuration() sets the time when the progress dialog will appear,
if it finishes before it won't be shown. Qt default is 4 seconds, maybe
pretty high for this case.
2018-10-20 16:33:25 +02:00
donoban
228aaed2f4
Removed progress.setWindowFlags() call
I am not sure what this wants, but it seems that doesn't affect
xfce but on kde does the progress bar appear randomly in the screen

without it on both cases it appears at center of screen
2018-10-20 16:28:19 +02:00
Marta Marczykowska-Górecka
77cf9bf1d2
Fixed error in qube manager of change of global settings
Changing global properties fired an event that crashed qube
manager.

fixes QubesOS/qubes-issues#4385
2018-10-19 20:06:30 +02:00
donoban
af8bc69314
Revert "Deleted unneeded thread_monitor"
This reverts commit fea560b5cd.
2018-10-18 15:53:35 +02:00
donoban
fea560b5cd
Deleted unneeded thread_monitor 2018-10-18 14:13:20 +02:00
donoban
b45f318a3a
Just moved method to better place 2018-10-18 14:13:06 +02:00
donoban
afcdba3029
Replaced python threading with QThreads 2018-10-18 14:11:25 +02:00
Marek Marczykowski-Górecki
70adf9cca9
Merge remote-tracking branch 'origin/pr/127'
* origin/pr/127:
  Changed blank kernelopts in VM settings from [] to -
  Fixed kernelopts in VM settings
2018-09-29 13:53:50 +02:00
Marta Marczykowska-Górecka
4ff111eb81
Changed blank kernelopts in VM settings from [] to -
as requested by @marmarek
2018-09-27 21:34:56 +02:00
Marta Marczykowska-Górecka
bc15ef91ec
Fixed kernelopts in VM settings
For some reason, they were not being displayed at all. Now fixed.

fixes QubesOS/qubes-issues#4188
2018-09-21 14:09:07 +02:00
Marta Marczykowska-Górecka
f618716548
Fix error on refresh when a VM has vanished
Fixes error that can occur when VM-removed and VM-changed
events fire too closely together.

fixes QubesOS/qubes-issues#4317
2018-09-21 12:46:49 +02:00
Marek Marczykowski-Górecki
3b4e3dd5d0
Merge remote-tracking branch 'origin/pr/89'
* origin/pr/89:
  Changes as requested by @marmarek
  Added instructions for tests
  Initials tests for qube manager
  Backup tests
  Tests for Backup
  Numbered tests for Global Settings
  Removed unused import from global settings test
  Tests for global settings
2018-09-17 00:03:56 +02:00
Marta Marczykowska-Górecka
e18058039f
Changes as requested by @marmarek 2018-09-16 23:33:17 +02:00
Marta Marczykowska-Górecka
f99df0d577
Added instructions for tests 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
b0c7aed800
Initials tests for qube manager 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
a69c061b49
Backup tests 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
f6bda2e9f6
Tests for Backup
Initial tests.
2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
fc6c886543
Numbered tests for Global Settings 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
44163be96d
Removed unused import from global settings test 2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
f5d94c2bf7
Tests for global settings
Unit tests for global settings window; based on QtTest
2018-09-16 17:48:54 +02:00
Marta Marczykowska-Górecka
cbf2e2154d
Fixed a small bug with Qube Manager status refresh
On change of template Vm status, qube Manager errored
out. It no logner does that.
2018-09-14 18:01:20 +02:00
Marek Marczykowski-Górecki
8d99fdd11b
Remove all dbus references
Including package dependencies
2018-09-12 16:32:37 +02:00
Marta Marczykowska-Górecka
3ad70484e6
Corrections as requested by @marmarek 2018-09-12 16:23:14 +02:00
Marta Marczykowska-Górecka
a761875b60
Pylint fixes 2018-09-10 18:04:45 +02:00
Marta Marczykowska-Górecka
4fc295e6a7
Added AdminAPI events to Qube Manager
rewritten parts of Qube Manager to use AdminAPI events (with quamash
to combine PyQt with asyncio).

hopefully fixes QubesOS/qubes-issues#4116
hopefully fixes QubesOS/qubes-issues#4258
hopefully fixes QubesOS/qubes-issues#4244
obsoletes/fixes QubesOS/qubes-issues#4190
hopefully fixes QubesOS/qubes-issues#3675
2018-09-10 17:48:14 +02:00
Marta Marczykowska-Górecka
20ee51f3d1
Fixed error with asynchronous handling of VM remove and VM halting
It will hopefully fix QubesOS/qubes-issues#4163 .

references QubesOS/qubes-issues#4163
2018-08-06 21:53:09 +02:00
Marek Marczykowski-Górecki
146ce683f7
Merge remote-tracking branch 'qubesos/pr/122'
* qubesos/pr/122:
  And also fixed problem with setting default template to None
  Fixed problem with setting default_dispvm to None in Global Settings
2018-07-24 01:39:33 +02:00
Marta Marczykowska-Górecka
a4c63cc939
And also fixed problem with setting default template to None
The bug was the same.
2018-07-22 23:57:50 +02:00
Marta Marczykowska-Górecka
6377983f9a
Fixed problem with setting default_dispvm to None in Global Settings
fixes QubesOS/qubes-issues#4114
2018-07-22 23:55:09 +02:00
Marta Marczykowska-Górecka
7b29a044d6
Fixed column widths in Qube Manager
Columns were resizing incorrectly (with too large minimums).

fixes QubesOS/qubes-issues#4002
2018-07-20 23:14:06 +02:00
Marta Marczykowska-Górecka
5e52b16fd3
Minor changes as requested
Minor changes as requested by @marmarek
2018-07-20 17:48:39 +02:00
Marta Marczykowska-Górecka
027abd8ac3
Pylint corrections
Pylint 2.0 was complaining. Cosmetic fixes to make it stop.
2018-07-20 00:25:27 +02:00
Christopher Laprise
b2fdbb950a
Handling VM dependencies in GUI tools
Added the following reactions ot VM dependencies in GUI tools:
- Qube Manager will inform the user why they cannot delete a VM (which
properties of which VMS [or global] are using the VM)
- Settings window will try to intelligently rename VMs (change
properties to the new name, if possible, and inform the user what went
wrong if not)
- Settings window will inform the user why they cannot delete a VM
Also, renaming VM from Settings launched from Qube Manager will
refresh the VM list through a horrible hack, to be replaced by a neater
Admin API solution in some near future.

depends on ca848ca7bd

fixes QubesOS/qubes-issues#3992
fixes QubesOS/qubes-issues#3993
fixes QubesOS/qubes-issues#3892
fixes QubesOS/qubes-issues#3499
2018-07-20 00:03:37 +02:00
Marta Marczykowska-Górecka
d46bf2aa8e
Improved communication on Remove VM in Qube Manager
When a user tries to remove a VM that's used by other VMs
or Global Settings from Qube Manager, they get information
about where the VM is used.

Depends on https://github.com/QubesOS/qubes-core-admin-client/pull/73
2018-07-18 23:51:37 +02:00
Marek Marczykowski-Górecki
b8c1ec8dac
Merge remote-tracking branch 'qubesos/pr/119'
* qubesos/pr/119:
  Make Qube Manager remember its size from last time
2018-07-17 15:57:59 +02:00
Marek Marczykowski-Górecki
9bb6a8cc94
Merge remote-tracking branch 'qubesos/pr/118'
* qubesos/pr/118:
  Fixed incorrect kernel display in VM settings
2018-07-17 15:56:09 +02:00
Marta Marczykowska-Górecka
e5dee2d70c
Make Qube Manager remember its size from last time
Qube Manager will now remember its size from last time it was run, and
also it will no longer force itself to appear at top left corner of
the screen.

fixes QubesOS/qubes-issues#4049
2018-07-16 18:47:07 +02:00
Marta Marczykowska-Górecka
af5aa233bb
Fixed incorrect kernel display in VM settings
Kernel set to 'None' was incorrectly displayed as 'default'.

fixes QubesOS/qubes-issues#4043
2018-07-16 17:35:35 +02:00
Marek Marczykowski-Górecki
18d45e53c6
Merge remote-tracking branch 'qubesos/pr/115'
* qubesos/pr/115:
  Make 'NetVm' column in Qube Manager clearer with regars to defaults
2018-07-16 14:15:12 +02:00
Marta Marczykowska-Górecka
7fb41f5cd6
Make 'NetVm' column in Qube Manager clearer with regars to defaults
When a VM has netvm set to 'default', now Qube Manager will display
'(default)' in front of the netvm's name.

references QubesOS/qubes-issues#3567
2018-07-16 14:07:27 +02:00
Marek Marczykowski-Górecki
f62aeb51d6
Merge remote-tracking branch 'qubesos/pr/116'
* qubesos/pr/116:
  Add a list of Suggested Services to VM settings
2018-07-16 13:52:47 +02:00
Marta Marczykowska-Górecka
6f4870bc8d
Changes to for pylint 2.0
Fixes to make pylint 2.0 stop complaining.
2018-07-16 02:17:48 +02:00
Marta Marczykowska-Górecka
63a202f3bd
Add a list of Suggested Services to VM settings
Added a list of suggested services to the Services tab in VM Settings.
The list is drawn from man qvm-services (manually, not automatically).

fixes QubesOS/qubes-issues#3891
2018-07-16 01:33:20 +02:00
Marta Marczykowska-Górecka
3f0af4498c
Fixed VM name validation in GUI tools (Create VM, Settings, Manager)
VM name validation in various places in Manager did not allow a
perfectly legal '_' character.

references QubesOS/qubes-issues#2422
2018-07-13 21:05:00 +02:00
Marek Marczykowski-Górecki
0a44c931da
Merge remote-tracking branch 'qubesos/pr/109'
* qubesos/pr/109:
  Pylint whitespace fix
  Fixed Backup GUI size
  Add option to turn off computer after backup to Backup GUI
2018-07-12 23:47:35 +02:00
Marek Marczykowski-Górecki
0c103e08b7
Merge remote-tracking branch 'qubesos/pr/106'
* qubesos/pr/106:
  Offset context menu in Manager to avoid accidental clicks
2018-07-12 23:42:55 +02:00
Marek Marczykowski-Górecki
5e4ac80ed2
Merge remote-tracking branch 'qubesos/pr/105'
* qubesos/pr/105:
  Remove templates from listing in UpdateVM and ClockVm in Global Settings
2018-07-12 23:41:47 +02:00
Marek Marczykowski-Górecki
bd7d3e576a
Merge remote-tracking branch 'qubesos/pr/103'
* qubesos/pr/103:
  Fixed identation and other problems on merge
  Fix minor performance bug
  Removed unneeded manual sort
  Avoid lag on loading dialog
  Removed unneeded try/except
  Protect update() from accesing deleted domains
  Sort performance boost
2018-07-12 23:40:15 +02:00
Marta Marczykowska-Górecka
9d16bec870
Pylint whitespace fix
Removed superfluous whitespace.
2018-07-12 23:31:30 +02:00
Marek Marczykowski-Górecki
635171c4f4
Merge remote-tracking branch 'qubesos/pr/100'
* qubesos/pr/100:
  Modified Qube Manager menu for dom0
2018-07-12 23:27:53 +02:00
Marta Marczykowska-Górecka
80b3a82963
Add option to turn off computer after backup to Backup GUI
A simple checkbox to turn off the computer after backup finishes
successfully. It is off by default and must be switched on every time
(unexpected system shutdowns are a huge pain, much more problematic
than forgetting to shut down can be).

fixes QubesOS/qubes-issues#2039
2018-07-12 22:47:02 +02:00
Marta Marczykowska-Górecka
5bdca303b1
Offset context menu in Manager to avoid accidental clicks
Small fix to Qubes Manager to open the context menu slightly to the
right of the mouse to avoid accidental clicks. Originally created by
@unman , ported to 4.0 and including changes to context menu from
pull request#100.

fixes QubesOS/qubes-issues#1911
2018-07-12 21:47:01 +02:00
Marta Marczykowska-Górecka
efa2b2d858
Remove templates from listing in UpdateVM and ClockVm in Global Settings
A user should not be able to set a TemplateVM as an UpdateVM or ClockVM
in Global Settings.

fixes QubesOS/qubes-issues#1831
2018-07-12 21:22:15 +02:00
Marta Marczykowska-Górecka
2f2217060e
Modified Qube Manager menu for dom0
Instead of generic menu with almost everything grayed-out, now
context menu for dom0 has only Global Settings, Logs and update.

references QubesOS/qubes-issues#1382
fixes QubesOS/qubes-issues#1165
2018-07-12 15:38:27 +02:00
donoban
d886983c02
Fixed identation and other problems on merge 2018-07-12 02:00:17 +02:00
donoban
8096a50f7f
Merge remote-tracking branch 'upstream/master'
# Conflicts:
#	qubesmanager/table_widgets.py
2018-07-12 01:42:36 +02:00
donoban
5ddd029d34
Fix minor performance bug 2018-07-12 01:26:34 +02:00
Marek Marczykowski-Górecki
b0e275bb3e
Merge remote-tracking branch 'qubesos/pr/101'
* qubesos/pr/101:
  Removed 'close window' button in progress dialogs in Qube Manager
2018-07-12 01:23:45 +02:00
donoban
1d80837cd0
Removed unneeded manual sort
Same its called later during init process
2018-07-12 01:22:28 +02:00
donoban
14f58fe8c1
Avoid lag on loading dialog 2018-07-12 01:21:04 +02:00
donoban
632f23c298
Removed unneeded try/except 2018-07-12 01:19:20 +02:00
donoban
bd919e44c1
Protect update() from accesing deleted domains 2018-07-12 01:17:48 +02:00
donoban
06f7262140
Sort performance boost
Cached all variables used by sort functions
2018-07-12 01:10:00 +02:00
Marta Marczykowska-Górecka
ce80245626
Removed 'close window' button in progress dialogs in Qube Manager
The ability to close window suggested to the user (falsely) that
they can close the window and thus abort the operation (like deleting
a VM). To avoid confusion, the button has been exorcised.

fixes QubesOS/qubes-issues#1479
2018-07-11 17:58:56 +02:00
Marta Marczykowska-Górecka
d4ecd23d0a
Correct sorting of VMs in Qube Manager
Fixed two situations in which there was no sub-sorting alphabetically.

fixes QubesOS/qubes-issues#1022
2018-07-11 16:13:26 +02:00
Marek Marczykowski-Górecki
16ced0466a
Merge remote-tracking branch 'qubesos/pr/97'
* qubesos/pr/97:
  Fixed error with large logs
  Log dialog viewer as a separate tool
2018-06-27 03:28:32 +02:00
Marek Marczykowski-Górecki
7a5c304c1e
Merge remote-tracking branch 'qubesos/pr/95'
* qubesos/pr/95:
  Revert last and removed pylint disables
  Added BaseException
  Show updates pending while running domain
  Fix search coherence when adding a domain
  Last no-member
  Try with disable=no-member
  Another try for travis
  Disable no-name-in-module
  Fix pylint warnings
  Fix very unlikely case when user right clicks the VM in the exact moment he deletes it.
  Don't close the settings window if something failed when renaming e.g. the VM name already exists
  Revert "Since __lt__ methods are safe, is not needed to stop and reenable sorting."
  Added standalone VM's to check_updates() Also added an initial call when creating the timer, most users will look for updates inmediately after start the manager
  Since __lt__ methods are safe, is not needed to stop and reenable sorting. It causes a short freeze of the main window when reenabling, so better removing it.
  Added try/except for all __lt__() methods since some VM could be deleted before the signal is received and handled.
2018-06-27 03:07:46 +02:00
Marta Marczykowska-Górecka
4933c6b580
Fixed error with large logs
Due to change in file.seek() behavior, the log
viewer errorer when faced with a very large file.
2018-06-20 23:08:22 +02:00
Marta Marczykowska-Górecka
6b206d2050
Log dialog viewer as a separate tool
Added entry point and main() to enable
using log viewer as a separate tool.
2018-06-20 21:01:49 +02:00
donoban
3b1057c2e9
Revert last and removed pylint disables 2018-06-14 01:28:07 +02:00
donoban
877eeaac2a
Added BaseException 2018-06-13 21:38:39 +02:00
Marta Marczykowska-Górecka
8de26419c1
Fixed a bug with warnings not modal in VM Settings
Warnings and error messages in VM settings were not
modal and thus could be erroneously hidden.

fixes QubesOS/qubes-issues#3959
2018-06-12 22:50:03 +02:00
donoban
34bcabd79a
Show updates pending while running domain
Maybe it is not useful for templates but I think it is better for StandaloneVMs since you will not notice pending updates until shutdown them with the other version.
2018-06-12 11:42:07 +02:00
donoban
52c38b67c6
Fix search coherence when adding a domain
A new domain was not properly filtered with the current
search string
2018-06-11 21:20:18 +02:00
donoban
9101f35245
Last no-member 2018-06-11 03:18:11 +02:00
donoban
b8d1cc4205
Try with disable=no-member 2018-06-11 03:06:35 +02:00
donoban
643147f525
Another try for travis 2018-06-11 02:46:31 +02:00
donoban
0c4047ffde
Disable no-name-in-module
Maybe travis works this way
2018-06-11 02:26:02 +02:00
donoban
2a437bcfc4
Fix pylint warnings 2018-06-11 01:56:10 +02:00