Commit Graph

952 Commits

Author SHA1 Message Date
Marta Marczykowska-Górecka
ef6288f1ff
Added "set as dvm template" to VM settings
Added an 'Advanced' settings checkbox that allows the user to set a given
VM as template fo dispvms. It sets both the template_for_dispvms property
and the appmenus-dispvm feature - instead of delving into particulars
of how and which should be set, the user can just turn off the
whole setting if they want to make some changes in the vm and then turn
it on again.

fixes QubesOS/qubes-issues#4004
2019-02-23 18:27:22 +01:00
Marta Marczykowska-Górecka
faae2d0026
Added warning when setting NetVM
When NetVM is set to something else than default_dispvm has set, a warning
icon appears.
2019-02-19 22:27:28 +01:00
donoban
17fdb3c263
Added BusyCursor for notify manager is working
https://github.com/QubesOS/qubes-issues/issues/4744
2019-02-19 21:58:33 +01:00
donoban
56cc6c79e5
Revert "Added progress bar to __save_changes__"
This reverts commit bb7b8c79ae.
2019-02-19 21:46:38 +01:00
donoban
dda98610d5
Revert "Increase progress wait time to 2s"
This reverts commit 0e9f8d4c45.
2019-02-19 21:46:17 +01:00
donoban
0e9f8d4c45
Increase progress wait time to 2s 2019-02-17 20:37:16 +01:00
donoban
bb7b8c79ae
Added progress bar to __save_changes__ 2019-02-16 15:56:46 +01:00
donoban
a9a2022206
Remove unneeded slot connections and reject overwrite 2019-02-16 15:54:22 +01:00
Marek Marczykowski-Górecki
52188318b8
Enable seamless mode buttons for Windows template-based qubes too
Fixes QubesOS/qubes-issues#4813
2019-02-12 22:23:38 +01:00
Marek Marczykowski-Górecki
9b8f5a460e
Apply DSA-4371 fix before launching updates
Script by @HW42 slightly modified.

QubesOS/qubes-issues#4752
2019-01-23 06:16:16 +01:00
Marek Marczykowski-Górecki
59dd11e137
Merge remote-tracking branch 'origin/pr/148'
* origin/pr/148:
  Fix error on warning in Settings on Rename VM
2019-01-21 23:01:19 +01:00
Marek Marczykowski-Górecki
5e9b33ebc1
Merge remote-tracking branch 'origin/pr/146'
* origin/pr/146:
  global_settings: Use MiB, not M as the unit
2019-01-21 22:59:17 +01:00
Marta Marczykowska-Górecka
60944bb2fd
Fix error on warning in Settings on Rename VM
fixes QubesOS/qubes-issues#4745
2019-01-21 19:53:12 +01:00
Marek Marczykowski-Górecki
2745266bf2
Merge remote-tracking branch 'origin/pr/145'
* origin/pr/145:
  Added info to Restore Backup widget about dom0 restore
  More consistent 'include_in_backups' behavior
  Fixed Backup tool's QT bug
2019-01-17 22:26:17 +01:00
M. Vefa Bicakci
7df475e0aa
global_settings: Use MiB, not M as the unit
Prior to this commit, clicking on the "OK" button in the global settings
window would cause the dom0 memory boost and minimum VM memory fields to
be saved incorrectly, due to the fact that the code calculates the
values to be saved using the "MiB" as the units (i.e., factors of
1024), whereas the code would save the corresponding string into the
qmemman configuration file with the "M" suffix (indicating factors of
1000 instead of 1024).

Due to this bug, the aforementioned fields' values would be scaled down
every time the user clicked on the "OK" button in the global settings
window. For example, if the user entered 400 and hit 'OK', opening the
global settings window again would show the value 381.
2019-01-16 21:17:52 -05:00
Marta Marczykowska-Górecka
3cf9ff3ee2
Qube Manager conservative updating
Only update the widget changed, if possible; look at the event
that caused the update and update whatever was actually changed not
the whole VM row.
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
a9c8d524c7
Added label update to Qube Manager
Manager will now properly display label changes.

fixes QubesOS/qubes-issues#3675
2019-01-16 22:00:54 +01:00
Marta Marczykowska-Górecka
0347eb6b1a
Added info to Restore Backup widget about dom0 restore
Added a label that makes it a bit more clear where the dom0 restore
backup data went.

references QubesOS/qubes-issues#3975
2019-01-16 21:11:43 +01:00
Marta Marczykowska-Górecka
60f62ff7cf
More consistent 'include_in_backups' behavior
Instead of always selecting for backup all the VMs that were selected
during last saved backup, now the GUI tool will disregard last selected
VMs and instead use VM attribute 'include_in_backups'

fixes QubesOS/qubes-issues#4713
2019-01-16 20:43:08 +01:00
Marta Marczykowska-Górecka
f047a56906
Fixed Backup tool's QT bug
Exiting the program was handled incorrectly.

fixes QubesOS/qubes-issues#4677
2019-01-16 20:21:46 +01:00
Marek Marczykowski-Górecki
0410518d29
Merge remote-tracking branch 'origin/pr/144'
* origin/pr/144:
  Fixed DispVM handling in Template Manager
2019-01-16 00:38:13 +01:00
Marek Marczykowski-Górecki
4c3de619fc
Merge remote-tracking branch 'origin/pr/142'
* origin/pr/142:
  Opens services file as utf-8 even in edge cases
2019-01-16 00:33:11 +01:00
Marta Marczykowska-Górecka
b7cf59c134
Fixed DispVM handling in Template Manager
DispVMs are now correctly excluded from Template Manager.

fixes QubesOS/qubes-issues#4704
fixes QubesOS/qubes-issues#4703
2019-01-14 14:57:00 +01:00
Marta Marczykowska-Górecka
6b0fa9551e
Opens services file as utf-8 even in edge cases
In edge cases (usually when system locale is not installed) Gtk falls
back to 'C' (not C.utf-8 ...) locale. Fixed that to enforce utf-8 always.

fixes QubesOS/qubes-issues#4475
2018-12-28 17:41:53 +01:00
Marta Marczykowska-Górecka
470390d789
Added explanatory tooltip to root resize
If system storage cannot be resized (due to belonging to an AppVM), the
system storage max field is grayed out without explanation; now it
will have a tooltip.

fixes QubesOS/qubes-issues#4617
2018-12-28 17:13:39 +01:00
Marta Marczykowska-Górecka
9727a0938b
Changed handling of maxmem/memory balancing in VM Settings
According to changes in 4dc8631010 ,
memory balancing is now handled not by a special service but by
magic value of 0 maxmem. Added handling thereof to VM Settings -
also, settings will store the last used maxmem value in
qubesmanager.maxmem_value feature.

fixes QubesOS/qubes-issues#4480
2018-12-18 16:40:51 +01:00
Marek Marczykowski-Górecki
e122669aef
Merge remote-tracking branch 'origin/pr/139'
* origin/pr/139:
  Changed to not force default netvm in Create New VM
2018-12-09 18:42:12 +01:00
Marek Marczykowski-Górecki
25586d972f
Merge remote-tracking branch 'origin/pr/138'
* origin/pr/138:
  Fixed behavior of Create Standalone VM based on template
2018-12-09 18:42:00 +01:00
Marta Marczykowska-Górecka
fa6db59ba3
Changed to not force default netvm in Create New VM
To avoid conflict with scripts that make whonix magic,
if the user selects default netvm, we do not set any  netvm and
trust the create_vm method to properly set it as default appropriate
for the given template.

fixes QubesOS/qubes-issues#1954
2018-12-08 23:09:39 +01:00
Marta Marczykowska-Górecka
bca68b24ba
Fixed behavior of Create Standalone VM based on template
private volume is now ignored

fixes QubesOS/qubes-issues#4045
2018-12-08 22:24:48 +01:00
Marek Marczykowski-Górecki
7dfa33b633
Merge remote-tracking branch 'origin/pr/135'
* origin/pr/135:
  Fixed bug in handling state changes
  Improved template manager UI
  Missing file added
  Added links to template manager to qube manager
  Initial template manager
2018-12-08 01:25:04 +01:00
Marta Marczykowska-Górecka
24adad8094
Fixed bug in handling state changes 2018-12-07 19:02:23 +01:00
Marta Marczykowska-Górecka
c0eb8b55ab
Improved template manager UI
changed it to be more intuitive and less annoying.
2018-12-04 01:01:03 +01:00
Marta Marczykowska-Górecka
21224a6cbd
Missing file added
I might have forgotten to include the .ui file.
2018-12-04 00:57:00 +01:00
Marta Marczykowska-Górecka
13c4c748f1
Added links to template manager to qube manager
Added a shortcut to template manager to qube manager main window and some minor pylint fixes.
2018-12-03 18:25:49 +01:00
Marta Marczykowska-Górecka
ce20377e39
Initial template manager
A working template manager; at the moment it only provides means
to easily change templates of multiple VMs at once, but it should also give tools to install new templates.

fixes QubeSOS/qubes-issues#4085
2018-12-03 18:25:49 +01:00
Marta Marczykowska-Górecka
f0357623e6
Refresh Apps in vm settings now refreshes the vm and template both
requires e26debfe97

fixes QubesOS/qubes-issues#4383
2018-11-30 21:47:15 +01:00
Marek Marczykowski-Górecki
334fefe559
Merge remote-tracking branch 'origin/pr/132'
* origin/pr/132: (48 commits)
  Fixed unreachable code thanks to travis
  Clear searchbox pressing esc without need of selecting it
  Fix errors when some domain fails to start
  wait thread to finish when aborting
  Don't terminate backup thread when aborting
  Fix iterating and removing over list
  Use 'qube' instead 'Qube'
  Qube -> qube
  Catch possible KeyError when starting dispVM
  Fix authorship and python version
  Create backup_window on the stack
  Removed sigchld_handler old code
  Fix pylint
  Do not terminate the thread
  Fix error/success message on dialog
  Fix opening settings/boot dialog after VM creation
  Add pylint disable too-few-methods
  Fix travis errors
  Removed unused import
  Workaround for backup dialog modeless behaviour
  ...
2018-11-28 01:13:48 +01:00
donoban
fd845a1219
Fixed unreachable code thanks to travis 2018-11-25 19:33:16 +01:00
donoban
b2bdae2c2d
Clear searchbox pressing esc without need of selecting it 2018-11-25 19:28:07 +01:00
donoban
4deaedd1e0
Fix errors when some domain fails to start 2018-11-25 19:15:56 +01:00
donoban
6fdf16278e
wait thread to finish when aborting 2018-11-25 18:53:31 +01:00
donoban
f477084bfe
Don't terminate backup thread when aborting 2018-11-25 18:49:02 +01:00
donoban
22a9823871
Fix iterating and removing over list
Return after removing and raise exception if removable item not found
2018-11-25 18:37:34 +01:00
donoban
0ce73df57d
Use 'qube' instead 'Qube' 2018-11-25 18:16:40 +01:00
Marek Marczykowski-Górecki
a760a64a85
Merge remote-tracking branch 'origin/pr/136'
* origin/pr/136:
  Add missing space
2018-11-21 01:58:40 +01:00
AJ Jordan
5619ee82bd
Add missing space 2018-11-18 17:59:43 -05:00
donoban
9a2975616d
Qube -> qube 2018-11-18 20:25:41 +01:00
donoban
287fc441f3
Catch possible KeyError when starting dispVM 2018-11-18 20:23:26 +01:00
donoban
935a6ca6c7
Fix authorship and python version 2018-11-18 20:22:27 +01:00
donoban
a39f3a64d0
Create backup_window on the stack
Otherwise it can casue an error:
RuntimeError: wrapped C/C++ object of type QProgressBar has been deleted
at line 1277
of file /usr/lib/python3.5/site-packages/qubesmanager/qube_manager.py.

I don't know how to avoid it.
2018-11-18 20:14:57 +01:00
Marek Marczykowski-Górecki
5edb1fdc6a
Merge remote-tracking branch 'origin/pr/134'
* origin/pr/134:
  Fix error in qube manager
2018-11-16 16:53:38 +01:00
Marek Marczykowski-Górecki
f93feb82ce
Merge remote-tracking branch 'origin/pr/133'
* origin/pr/133:
  Added GUI for toggling of seamless mode for windows
2018-11-16 16:52:10 +01:00
donoban
cbc5d364bf
Removed sigchld_handler old code 2018-11-04 18:19:16 +01:00
Marta Marczykowska-Górecka
8098466a07
Fix error in qube manager
In some cases (when a VM quickly appears and disappears)
the events were handled in a wrong order.

fixes QubesOS/qubes-issues#4414
2018-10-29 23:00:59 +01:00
donoban
5c8f19b598
Fix pylint 2018-10-27 13:21:33 +02:00
donoban
c42203098f
Do not terminate the thread
self.back_restore.canceled will do the abort
2018-10-27 13:00:19 +02:00
donoban
988b7a6479
Fix error/success message on dialog 2018-10-27 12:58:58 +02:00
donoban
6045f451c6
Fix opening settings/boot dialog after VM creation 2018-10-25 09:45:12 +02:00
donoban
7f572b5c81
Add pylint disable too-few-methods 2018-10-24 11:27:47 +02:00
donoban
fd1e5d740a
Fix travis errors 2018-10-24 10:58:36 +02:00
donoban
042ff808b3
Removed unused import 2018-10-24 10:14:48 +02:00
donoban
971ec085ee
Workaround for backup dialog modeless behaviour
Since now it's modeless, user could have already it opened
but we have to destroy it and recreate when closed for vm list
being refreshed (at least for now)
2018-10-24 10:05:43 +02:00
donoban
531b9daad2
Signal rewrite to new style
old is not supported in pyqt5
2018-10-24 09:46:16 +02:00
donoban
461cb7ae8c
Don't close main about dialog when close some child dialog 2018-10-24 09:45:29 +02:00
donoban
23e9ae8d33
Remove loop since we have vm name 2018-10-24 00:03:17 +02:00
Marta Marczykowska-Górecka
65b50c0f3b
Added GUI for toggling of seamless mode for windows
Added two buttons to enable/disable seamless mode
for windows qubes.

references QubesOS/qubes-issues#3585
references QubesOS/qubes-issues#4342
2018-10-23 22:51:28 +02:00
donoban
e124d83edc
Removed processEvents() calls 2018-10-23 00:07:55 +02:00
donoban
9102d200bd
restart wizzard when wrong password or backup corrupted
fix: https://github.com/QubesOS/qubes-issues/issues/1589
2018-10-22 23:47:51 +02:00
donoban
0e951dc156
Deleted unused method show_error()
clear_threads() handles messages now
2018-10-22 20:03:20 +02:00
donoban
edb13aec17
Thread.error renamed to Thread.msg
Since it could be used for both error or sucess
messages, I think msg is a better name
2018-10-22 20:00:37 +02:00
donoban
60af90ec5f
Adding # pylint: disable=too-few-public-methods 2018-10-22 10:14:26 +02:00
donoban
4aea47c9f7
... 2018-10-21 22:52:52 +02:00
donoban
df15c4e3ae
Fix pylint warnings and errors 2018-10-21 22:38:41 +02:00
donoban
a7537a323a
Wops
I did not notice on my pylint because it complains about all imports
2018-10-21 00:16:23 +02:00
donoban
c46b38ab42
Travis3 2018-10-21 00:06:37 +02:00
donoban
f93908f5b7
Fix travis build2 2018-10-20 23:23:06 +02:00
donoban
831769d2dd
Fix travis build 2018-10-20 23:01:35 +02:00
donoban
38051ad243
Fixes in ProgressDialogs and settings window close 2018-10-20 22:09:39 +02:00
donoban
2347f75633
Clear SearchBox with ESC key 2018-10-20 21:54:25 +02:00
donoban
ad1bcc55b9
Deleted unneded method _clone_vm() 2018-10-20 21:25:13 +02:00
donoban
11cc8b7a67
Remove debug print 2018-10-20 19:20:39 +02:00
donoban
29ca4eb3a8
Migration from python threads and to QThread obj
Simple design and better performance, just start() thread and finished
call back will show any error or msg, stop progress dialog and do cleanup.

Full remove of QT process_events() calls.
2018-10-20 18:34:15 +02:00
donoban
35cdf5e1e5
Modeless backup window
Let the main window work while doing backups
2018-10-20 16:50:45 +02:00
donoban
759dc5412c
Pylint ident warnings 2018-10-20 16:49:50 +02:00
donoban
76b6de9d00
removed subprocess.check_call()
This way modal works better (in KDE the main window goes gray).
2018-10-20 16:43:15 +02:00
donoban
612cfc15d6
Loading Qube Manager progress using setValue()
This is the recommended QT way for updating the progress bar.

setMininumDuration() sets the time when the progress dialog will appear,
if it finishes before it won't be shown. Qt default is 4 seconds, maybe
pretty high for this case.
2018-10-20 16:33:25 +02:00
donoban
228aaed2f4
Removed progress.setWindowFlags() call
I am not sure what this wants, but it seems that doesn't affect
xfce but on kde does the progress bar appear randomly in the screen

without it on both cases it appears at center of screen
2018-10-20 16:28:19 +02:00
Marta Marczykowska-Górecka
77cf9bf1d2
Fixed error in qube manager of change of global settings
Changing global properties fired an event that crashed qube
manager.

fixes QubesOS/qubes-issues#4385
2018-10-19 20:06:30 +02:00
donoban
af8bc69314
Revert "Deleted unneeded thread_monitor"
This reverts commit fea560b5cd.
2018-10-18 15:53:35 +02:00
donoban
fea560b5cd
Deleted unneeded thread_monitor 2018-10-18 14:13:20 +02:00
donoban
b45f318a3a
Just moved method to better place 2018-10-18 14:13:06 +02:00
donoban
afcdba3029
Replaced python threading with QThreads 2018-10-18 14:11:25 +02:00
Marek Marczykowski-Górecki
70adf9cca9
Merge remote-tracking branch 'origin/pr/127'
* origin/pr/127:
  Changed blank kernelopts in VM settings from [] to -
  Fixed kernelopts in VM settings
2018-09-29 13:53:50 +02:00
Marta Marczykowska-Górecka
4ff111eb81
Changed blank kernelopts in VM settings from [] to -
as requested by @marmarek
2018-09-27 21:34:56 +02:00
Marta Marczykowska-Górecka
bc15ef91ec
Fixed kernelopts in VM settings
For some reason, they were not being displayed at all. Now fixed.

fixes QubesOS/qubes-issues#4188
2018-09-21 14:09:07 +02:00
Marta Marczykowska-Górecka
f618716548
Fix error on refresh when a VM has vanished
Fixes error that can occur when VM-removed and VM-changed
events fire too closely together.

fixes QubesOS/qubes-issues#4317
2018-09-21 12:46:49 +02:00
Marek Marczykowski-Górecki
3b4e3dd5d0
Merge remote-tracking branch 'origin/pr/89'
* origin/pr/89:
  Changes as requested by @marmarek
  Added instructions for tests
  Initials tests for qube manager
  Backup tests
  Tests for Backup
  Numbered tests for Global Settings
  Removed unused import from global settings test
  Tests for global settings
2018-09-17 00:03:56 +02:00
Marta Marczykowska-Górecka
e18058039f
Changes as requested by @marmarek 2018-09-16 23:33:17 +02:00
Marta Marczykowska-Górecka
f99df0d577
Added instructions for tests 2018-09-16 17:48:54 +02:00